From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8A893DAAA4 for ; Tue, 4 Aug 2026 15:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785856098; cv=none; b=PrIqDfT92QFfyMXhCdJKGpLZUFMg014E82NltXaxGAvrl5nNAW18ghypS/pfAC1AZFT8sNKwi4CzMBZzpRjMXAF+KlXCdgeEVb6HrjHgOmqEMK1qDG6P6eLtThwE6nO1Umqe+9A61a0szo7wtlQa1WEQ8gen5sRGRIyev3ygDFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785856098; c=relaxed/simple; bh=s4p6juCwQ475aHXTn+wYPeV0BPHhmlo0G++9AOmJWt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=inWIZXYpG/BRT+VSFIcHXhJvhcwPLyHEjb4UewhksSUScMHt+M2+j49SPM1CHfQGqxP2K0TS7vzWyg3rIjbjHOvWgZqmvkspoh8io96K40TEedjDdUCobUE8hCx2J/ucBi+Un2Gki/URwJ/D/kSaNuAuuQNjIaYxEsVBLEDzEjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UVV2WGgI; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UVV2WGgI" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-848595b338cso5921469b3a.0 for ; Tue, 04 Aug 2026 08:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785856097; x=1786460897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S4Qg2o+emc3m6rF47B2E/svsOXDIcQrkgOFSzKR4MaY=; b=UVV2WGgIHTSiMeZNrU9W2yknVXj9o3So2xx4hrGTg6MxxpPy+L0tn+W9hYNRD1RklW CqfpX/D+bbvq4MfN1Np4736CFVPA39RctRFcXJFpI5JXlKH0qpvZf1hih0Vlgo1AzSQz vDmej0JKt94+tD2QqPvTNT6s907d0bCZv1fw+UwTyCiMCFc4C3oLoK9Yv4tsAlA+qwFb v+5/OpjS/x/Qnb3cv7SeBdzp4hX2raNlxBqbt3A6EujgbEJTQ3TzcnCjabdQM5xl5gF5 3EAz4JYseuxhVxjWSTfzvucR0lgT1HO46cjpIVVviUfxcxnu5Du8UBiequFUg9MkVM0U gYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785856097; x=1786460897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S4Qg2o+emc3m6rF47B2E/svsOXDIcQrkgOFSzKR4MaY=; b=JpJYkHY4j52L4+c5IDgBi09PJaoUzZbUYg0QNQx0q4zNqsM//x0U98fuYZeW79cE/p mh9rh0zqPF+DVY7JJ9XO89IHtKpiFQN7zoJxm2h2uHrnzvlN2h1yz5NjN04dbPAkhfM1 u0Il3/FkMLelZyg5jxauTfhi+7oVBd7cRz0NS2whuQvgsvzymMV3FSuC5JAMgrMMw2ae pwa5zPYU/RFOsJDulwyhysvcneWjf1rGs0OTuPnQKT+t7LBe/BYd5WB72uMj5a8MC2SU pTt20/BnWSH+BeT9I2IMV4t+OxFp8VDW5VvoQNBKiQDvCaKN+KLpMekO/uqTsBKLJKGx spvw== X-Forwarded-Encrypted: i=1; AHgh+RrkbCsSC87SIMxSu0i9hFFVCkuqri5VaR2mUor3nBTN6mWzoDx++9EQSserAx0V1r0dtjiJdZ+D9dqGU1Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx18EF1467EO92HwWqXB/bOhiy7q3Fft0IibVz5spgBLLapyhgK kJmOeDhP7cW8TxczdI3UwpiOS3NZaX6xpCJoSQ7HAG2IZIHRB7uYm8c= X-Gm-Gg: AR+sD10aRKcEiss+Kf/8T3/2hn2/ZYljwsGbFFhJIt+ZidI+b4v5c8XT0nnSz2RJEoi QZ+4CXETxHWi4uCaVoOcRFb/Ssvd2T3P1cvFMhmaq0IcXpnUkGr/cLqfKr/5AUXyYkZrDI89DAd h0GbT/otDhl2PeWb+uUpYnx+Ov2tlKhkcMLcj5sIntmE31YfpeVAWOACaopLSM6Wet/kzHOcNyU zY6OiJgUJJb0NW8LoBBnyp5bwYzaMBv5RzQkZDJysnNi/iLdPEQhF8ITFY4TTd0uax1x1Bfs8p/ C4htz/hqPsKHg6AQFxixHVrkR2nBxQ1ULoijL4n2jh7sIrGbIZZobrztzTNdSK1CUgslC9HfkwI ICbOlAxb4CYmpCriZNc+5Eb/LRrFBTFOsxBm/V7362HmYHezLdkK5toyeG6rycMs7+0O++6vMpQ 57J8PABvgTrDNpqSjsBNVIOWK4O3uW2Et5w5BkN8CiA6NuCCVi0Fw1OTl6vkTbM3wT/Ll1zr+cy WAaTdBZc08s+227f0QsF9UO3q/fXgGqAqOffT3Tx/+kkiXHzgIhh6RR5eBhF1VtTULdh+IfMzv0 XN2JxpCjmaSr9WKU+kT33E8= X-Received: by 2002:a05:6a00:ad1:b0:845:4126:222b with SMTP id d2e1a72fcca58-84ee47d8768mr14159742b3a.28.1785856096851; Tue, 04 Aug 2026 08:08:16 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc41ca4dsm5420587b3a.52.2026.08.04.08.08.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 04 Aug 2026 08:08:15 -0700 (PDT) From: Myeonghun Pak To: Neil Armstrong Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot , oe-kbuild-all@lists.linux.dev, stable@vger.kernel.org, Ijae Kim Subject: [PATCH v2] drm/meson: clean up KMS polling on register failure Date: Wed, 5 Aug 2026 00:08:02 +0900 Message-ID: <20260804150802.45262-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com> References: <20260524160657.17802-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit meson_drv_bind_master() starts the KMS polling helper before registering the DRM device. If drm_dev_register() fails, probe unwinds the IRQ and DRM device without stopping the polling helper. Call drm_kms_helper_poll_fini() on that failure path before freeing the IRQ. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Reviewed-by: Neil Armstrong --- Changes in v2: - Avoid the unused uninstall_irq label reported by the kernel test robot. - Link to v1: https://lore.kernel.org/r/20260524160657.17802-1-mhun512@gmail.com drivers/gpu/drm/meson/meson_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 49ff9f1f16..bcc36f2cdc 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -351,8 +351,10 @@ static int meson_drv_bind_master(struct device *dev, bool has_components) platform_set_drvdata(pdev, priv); ret = drm_dev_register(drm, 0); - if (ret) + if (ret) { + drm_kms_helper_poll_fini(drm); goto uninstall_irq; + } drm_client_setup(drm, NULL); -- 2.47.1