From: Mohit Mishra <mishraloopmohit@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Nikolay Kulikov <nikolayof23@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Mohit Mishra <mishraloopmohit@gmail.com>
Subject: [PATCH v2] staging: rtl8723bs: convert swing index variables from u8 to int
Date: Tue, 4 Aug 2026 22:31:37 +0530 [thread overview]
Message-ID: <20260804170137.20708-1-mishraloopmohit@gmail.com> (raw)
In-Reply-To: <YOUR-ORIGINAL-MESSAGE-ID>
In ODM_TxPwrTrackSetPwr_8723B(), Final_OFDM_Swing_Index and
Final_CCK_Swing_Index are declared as u8. Using u8 for variables involved
in arithmetic calculations and lower-bound comparisons (<= 0) is unusual
and triggers static analysis warnings.
Convert both variables from u8 to int to clean up the variable types,
aligning with the TODO item to "convert any remaining unusual variable
types".
Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 6c5f56d5a1f4..2ec2d4aada56 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -160,8 +160,8 @@ void ODM_TxPwrTrackSetPwr_8723B(
u8 PwrTrackingLimit_OFDM = 34; /* 0dB */
u8 PwrTrackingLimit_CCK = 28; /* 2dB */
u8 TxRate = 0xFF;
- u8 Final_OFDM_Swing_Index = 0;
- u8 Final_CCK_Swing_Index = 0;
+ int Final_OFDM_Swing_Index = 0;
+ int Final_CCK_Swing_Index = 0;
{
u16 rate = *(pDM_Odm->pForcedDataRate);
--
2.43.0
parent reply other threads:[~2026-08-04 17:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <YOUR-ORIGINAL-MESSAGE-ID>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804170137.20708-1-mishraloopmohit@gmail.com \
--to=mishraloopmohit@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox