From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA4EDDA9 for ; Tue, 4 Aug 2026 21:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878332; cv=none; b=WYvZsGN0xvwEaR23PHzavPlflFPPiF6tUWmigp1dfqBC0eOF5k6kDrCA1rvu/vLq7WWnCLm4BW1+/aKa4+d5tKW3VN+auFtgxaZCiW4SLuptjCnByl+N+VXLbPfmuOk5xG1KNDeqic06d+LT1cXJ56k1FKr7w/w4IZ56xHo8nLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878332; c=relaxed/simple; bh=7A9rE23m+RL+UaQQuX5flCQdY9RHFtZjjqn2wxodAtU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m5dmi2WtlNMG2nD3LPK7NTrjYoamz/S6ApIzYIZqPQzBJz3r3mgYxm64ZrVMPN92mhHfUfcHSAkP3SCfwGc8R6ecXmh/9rmRf8MFQxs/VrqnHaj/mg6+DcSeLct7YNE4Od2GoTOUpC2JYA2ExgbMHXOXPcQl5fUKhFKoctDOK9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eNXdl9Ni; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=s5YfT3rH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eNXdl9Ni"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="s5YfT3rH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785878329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1TP38q0K01L56osFLXqQbZAP99zP82MPli6vDMYBEJU=; b=eNXdl9NifdVscctW2p6ZYm7mWH/gMAFrothgIHsQhHRAtZnwWltYm/rjVMKSo1ClEd3K1D /ZderwWPgaSynirBM4yurKwYB7qNxHK8aJ1ANu0KNRuEN86OJ5uD/0KlD7pFaXSKZyDWkE 0EuY3Il0EedtSV9B7tpEjLE58FCJNRM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-32EyTgw9MaSVSJCR2mcUBw-1; Tue, 04 Aug 2026 17:18:38 -0400 X-MC-Unique: 32EyTgw9MaSVSJCR2mcUBw-1 X-Mimecast-MFC-AGG-ID: 32EyTgw9MaSVSJCR2mcUBw_1785878317 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47f6e658363so127010f8f.3 for ; Tue, 04 Aug 2026 14:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785878317; x=1786483117; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1TP38q0K01L56osFLXqQbZAP99zP82MPli6vDMYBEJU=; b=s5YfT3rHTQqK4YXnZQuEGvTt1q41dwTeQO6HFjB8/4YxRmbsGt9B4aJw8hodKkjbv0 DG+HWjEx9WsIMYESLakU0b2BqpyCvrZHRrIslGIDSP0oRxGTkxdBtFpGhwh3GVerISzf wzajn11gdmSHB51lN2zMq87KJw2ZNrqGwaIMqMgRaQzRXjgaluyvwTNW36TSvwUAumid q8ROZpfBsQzQySJXSNS1oJOmSfPmnztvahJddOtsiuEZPvHbJBprdqtWloKpiIGKlpCi c+GsmKnfKBPPPUht5jdnuh5ELzbstZeU8OAYXq9c9/cWFd5bhzmKqj7nMYJ0ouHsR8La tbLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785878317; x=1786483117; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1TP38q0K01L56osFLXqQbZAP99zP82MPli6vDMYBEJU=; b=WKo52DWt9JWjZC0DTJ/WqE0uA7EsllBGgJZx1Zau1GVTUDu4FtSYEi6ghtp4iMZ907 M8fp6CHGMTSKiWb9duoCXGI0CDrnBzEbI7hs5KdIVCvbL9srjBXWrNNOOHo5NXld8n73 XfXpsHe/Fa4VcjBX90u8V2kRmuMNp/WXraRaOaS3IIjF1zP1LjPyP7OCXDGWgzFwmDVS V5SVxR7vR00lZHr9TC3YDSOybWXC4EjcpV2ZeKC/dgSX3/ASBBvQDuhciumYWEzGBofJ LHgv6AZkjen1DrUlPBPWilFpHUtktQ2AInzaEG9ap/ZH0Ckddk/Ltz0y4m6/jUKruQ2T Ayog== X-Forwarded-Encrypted: i=1; AHgh+Rqsw7nDHeFAiwb93zGnt5qd51B8i7G1XHuyhJgnxZdlTC9nIoKvzcpZyUyBrA2MA6yjMK6eD5BWDuf1RmE=@vger.kernel.org X-Gm-Message-State: AOJu0YztEbKzP0utgrjrOs4+wGNWwLNkmEkrf8GjCNyykZR9/rDuiWhN gmPQZCg1HHwpqNaGLftGxfMLuWv10Xfm0oIKIhyKbTwNlsi0l1S7Saj1cOrnJhDScQwwHscYa9P qNvBD6ZUyegWlxmx/o9TXUbYSId8EigKsX7ltgqpGzi3YLjJYgqOid1vgmzlc5DNJjw== X-Gm-Gg: AR+sD11XLxiW6s9Kg5WPb08nin9WdHoymT4mkTLrHPnJow/87nKDH1+hXqXMDykhMCT BKk/cE5Ygn7TiSeWaWBULGkhddr/gw6jP6cShv583TiWWAacnW3PdZeYXmHe08BznQRfXQq34Qz w1FShszMZmSIhfKqFPIBUNvLv2fcE+N86v1w5kaXqU4hEGamLJLT9RCKTlgsoEjRFU4dJASLLvT Of3DS7vslnbaz9eNkoerPixZ76lniTzbBjvze3+29n1NOWoltF5FIVM4m2vrljq3RQPidXE0tJF TbG6ycQfvurRKPKql+/WzKxn+V/xAiLYKtzNGRscSXvR4WYfRDbCUpoVL25wGoEFoMgBbmhseHH 0aGZfYH3FduOxsjUHRt0Mkg== X-Received: by 2002:a05:600c:2142:b0:495:5858:8101 with SMTP id 5b1f17b1804b1-4994e7cbcbfmr11546285e9.15.1785878317052; Tue, 04 Aug 2026 14:18:37 -0700 (PDT) X-Received: by 2002:a05:600c:2142:b0:495:5858:8101 with SMTP id 5b1f17b1804b1-4994e7cbcbfmr11545645e9.15.1785878316524; Tue, 04 Aug 2026 14:18:36 -0700 (PDT) Received: from redhat.com (IGLD-80-230-28-14.inter.net.il. [80.230.28.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994a0f7b73sm151709455e9.9.2026.08.04.14.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:18:36 -0700 (PDT) Date: Tue, 4 Aug 2026 17:18:33 -0400 From: "Michael S. Tsirkin" To: Xiong Weimin Cc: Zhu Lingshan , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa: ifcvf: Put device on unsupported feature error Message-ID: <20260804171710-mutt-send-email-mst@kernel.org> References: <20260804092626.1344371-1-xiongweimin@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804092626.1344371-1-xiongweimin@kylinos.cn> On Tue, Aug 04, 2026 at 05:26:26PM +0800, Xiong Weimin wrote: > Route unsupported provisioned features through the common error path after > vdpa_alloc_device() so the allocated device and adapter pointer are > released consistently. > > Signed-off-by: Xiong Weimin I have no idea what this means. This is not how a commit log should look. An example template: Currently .... This is a problem because ... We can not do .... because ... To address .... And then .... > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index ab6d6ab3b..3cd2c35db 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -724,7 +724,8 @@ static int ifcvf_vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name, > if (config->device_features & ~device_features) { > IFCVF_ERR(pdev, "The provisioned features 0x%llx are not supported by this device with features 0x%llx\n", > config->device_features, device_features); > - return -EINVAL; > + ret = -EINVAL; > + goto err; > } > device_features &= config->device_features; > } > @@ -748,6 +749,7 @@ static int ifcvf_vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name, > return 0; > > err: > + ifcvf_mgmt_dev->adapter = NULL; > put_device(&adapter->vdpa.dev); > return ret; > } > -- > 2.43.0