From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58BA94C6EF8 for ; Tue, 4 Aug 2026 20:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785873963; cv=none; b=a6xBdI/sUbioTqW+OmyWxxnHvRdgADhw+H5c5q/BfnJlW4fX11W5n5Ju/NMHUxGsbqaOj5Apswc1rEk9A2H1n36waEpT8ren6LDiu2p1Yq9gsELQcUfxrBVb03eBYXZTVvIYk1ZkdIgLEv0HsLcMHhpMp9JdYnlYNye2ud64OBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785873963; c=relaxed/simple; bh=Rzyg2r9Gw+DBv9EyDkN9C4yX0l0alqk7TysPz7LzNDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tMk/JVrxBA+ZyQ9QbzR3psvKJYymcIHyeuuswL/VPpf4KYMPZp9XA/Is+scKI4eBnwAUT2LroOYiUXa6guOYv3kIS4DRPVFVvNMxiUVBUrKG+JbNhbgkrPUZO4h9ShOuZiqjGvwjG3azBbNRrjwRLuYLwUeCbDymTdOWPskNLV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qkEpgrKW; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qkEpgrKW" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ce98cb8165so3417175ad.1 for ; Tue, 04 Aug 2026 13:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785873957; x=1786478757; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wk0tZ9b//2KmUpK5oczo+l+IRmx2KRAWrszmUttdFGo=; b=qkEpgrKWzxfecsUm0L1SHi2xYptO/sVqsOzItY/NzZ8s/Ssa6/0YaqxP0iP4Dxaa0z Ne3FWzf9TE1SZK6GGQi3hOOIdZ2tT2Rdo94/Q5Y8m1KYZKwml/kbvACg+y4mDsdspXEB B2gMmkLaaPO8EhpX/ZXXMDaqDysia0Yx/7pvlFUKhJCcajeN/S684XNxUyDipM/ZSAa4 S65XwkeMLz8b+UNPkiVvgABV7sLLstSJXSYQn2V1qHkerqQzSE9ozx9ES2A3VQVDh+e/ jwmIMKZoPkeQTdxLdWBcajLx7mov6uoRm24joIhowWlcBfjxRkVkSZtZX41QJydL5g3w ov0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785873957; x=1786478757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Wk0tZ9b//2KmUpK5oczo+l+IRmx2KRAWrszmUttdFGo=; b=hdVZEnG2cf0I+9C1PC4iJ0x5o/yfJszLbJthgwGfjAWzGRjD0amRUh6wZd/kBL0QXw OjtWhIxZ2s/QFHcN4sfYmeNtpHKzu3y/vPzR3oJhGy1Q1Ws8kw8bv/6k3MoAs5pn3EOa ZQaaNG5M5xSaqbjw0oVTa1bLKnT73Rfwk5Xa/qhquDg4lLjrK/SzRjzlngbpY+L/INbf aJLWK8TZ7LYobtdhnEyvgpdT6Ha+YW62oGHj3AK6+F6YVDVG/guXrNox5IixUy9o+N6Z PgrhqBT4l70wp+j7vUdPyp+uc/ve1PZlbISUfIa+B8GEgPu4KKqULyF1RAni0Vvuee0t AqKg== X-Forwarded-Encrypted: i=1; AHgh+RorTFBu0uWd5EIzZv2CnAIx/9v3Djxef8gpljdTdO/32GX1b+l4d1Pao1I5LUxLrS4e3EAsNIoi4a55Y94=@vger.kernel.org X-Gm-Message-State: AOJu0YxBVlfY5XKMZxkvAVxO861kUZzyda5qA3+V7CboWkP++FpaLl5w FGKQbLm6Nz4vKcc5fhXUF8p+nD2UG/DpjGs8OYmJwqdBfW5U+F/HUV12 X-Gm-Gg: AR+sD11pG2CUsPpwasE0VU0djTv1/WfNR1nNoGz/cE9FQ4qvGonLinDXaKe/U+92Tgf vH7oMv1dz6IgBDLVmy1KaTYU+TYAJ0/GRf2M3I0SqML6wRGGxNwSD5zhnpn3ZU18AfqFOcrbkNB LudtAvMxVd2AOEHrp6gWQmWrJpxgj3xIahtzk90W8LlGulCWMydc6bLNW0BXZRjj1x1nr3ZJuV2 UJFRwIvRmKyQFMK62aowRGj2HMYFubrqLuyVepif9L6x6Dm+GsHCeUtqqo3hddRkKuIG2IvxjDY z2KTub/3a8Ceg61zDNIYfULONeEcT2lZSBQOJTg8tND1vz543RpucmXcHZvehMQLv2P05yTae8o il8Jy20U6K+gBJNDdMQYKsVFnzp6eYZr16z34bJk7r20zrH4pPfuNtMKE/z0lqOajsCsASmeJOn 2KZcf/30W1160aNdkmJreK7SlbJgucRJsNB1MVey4VrvxAUvZPTFC1JlsZ89ht+vTu7vAWiUHtY 6zZDg8SC5q+4JDlJF0dOGmVPb1ssw1QwV3KwQy2JrjERoLEE85zbydOtRIhl+FJbKfifNM= X-Received: by 2002:a17:902:d54a:b0:2c9:d56d:afa3 with SMTP id d9443c01a7336-2d08ab5dc4fmr60130665ad.15.1785873957038; Tue, 04 Aug 2026 13:05:57 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0a9f93621sm12975185ad.9.2026.08.04.13.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 13:05:56 -0700 (PDT) From: Ivy Lopez To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, Ivy Lopez Subject: [PATCH v2] staging: rtl8723bs: use kfree_sensitive() for key material in rtw_set_key() Date: Tue, 4 Aug 2026 14:05:40 -0600 Message-ID: <20260804200540.78104-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730231315.79688-1-skunkolee@gmail.com> References: <20260730231315.79688-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit psetkeyparm holds WEP/TKIP/AES key material copied in via memcpy from psecuritypriv before being freed. Use kfree_sensitive() instead of kfree() so the key bytes are zeroed before the memory is released, consistent with how psetstakey_para is already handled elsewhere in this driver. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Ivy Lopez --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 1196ec011455..fb45f7295386 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1926,14 +1926,14 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp break; default: res = _FAIL; - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); goto exit; } if (enqueue) { pcmd = kzalloc_obj(*pcmd); if (!pcmd) { - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); res = _FAIL; /* try again */ goto exit; } @@ -1949,7 +1949,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp res = rtw_enqueue_cmd(pcmdpriv, pcmd); } else { setkey_hdl(adapter, (u8 *)psetkeyparm); - kfree(psetkeyparm); + kfree_sensitive(psetkeyparm); } exit: return res; -- 2.55.0