The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nguyen Quang Le Kien <khiemtranzo532001@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+098999e05b6b877c01b3@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] usb: gadget: f_phonet: fix use-after-free in pn_bind
Date: Tue, 4 Aug 2026 10:21:40 +0200	[thread overview]
Message-ID: <2026080445-dyslexia-shell-2db3@gregkh> (raw)
In-Reply-To: <20260804081853.2921752-1-khiemtranzo532001@gmail.com>

On Tue, Aug 04, 2026 at 04:18:53PM +0800, Nguyen Quang Le Kien wrote:
> On Tue, Aug 04, 2026 at 09:52:53AM +0200, Greg KH wrote:
> > Did this new version properly run through syzbot and it reported it succeeded?
> >
> > This isn't needed as you added it to the .h file, right?
> >
> > And you didn't answer my question about LLM use.
> 
> Not yet - I sent v2 about 30 minutes ago and syzbot hasn't picked it up.
> I'll wait for the test result before sending v3.

Please always do that before asking a human to review it.

> You're right about the redundant include; that will be gone in v3.
> 
> On the LLM question: I used it as a drafting assistant for the v1
> changelog and comment wording, but the race analysis and the actual fix
> are my own, and I build-tested the patch. The over-formulaic changelog
> and leaving the old stale "no race" comment in v1 were on me. I wrote v2
> and the upcoming v3 directly. Will send v3 once syzbot reports back.

Please always document your LLM usage, as our rules require you to.

thanks,

greg k-h

  reply	other threads:[~2026-08-04  8:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  3:33 [PATCH] usb: gadget: f_phonet: fix use-after-free in pn_bind Nguyen Quang Le Kien
2026-08-04  6:30 ` Greg KH
2026-08-04  7:44   ` [PATCH v2] " Nguyen Quang Le Kien
2026-08-04  7:52     ` Greg KH
2026-08-04  8:18       ` Nguyen Quang Le Kien
2026-08-04  8:21         ` Greg KH [this message]
2026-08-05  4:08           ` Nguyen Quang Le Kien
2026-08-05  4:57             ` Greg KH
2026-08-05  6:57               ` [PATCH v3] " Nguyen Quang Le Kien
2026-08-05  7:51                 ` Greg KH
2026-08-05  8:24                   ` Nguyen Quang Le Kien
2026-08-05  8:37                     ` Greg KH
2026-08-05  9:23                       ` Nguyen Quang Le Kien
2026-08-04  8:25       ` [PATCH v2] " Nguyen Quang Le Kien
2026-08-04  8:25         ` syzbot
2026-08-05  4:13     ` [PATCH v3] " Nguyen Quang Le Kien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026080445-dyslexia-shell-2db3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=khiemtranzo532001@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=syzbot+098999e05b6b877c01b3@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox