From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFDF13BBFB3 for ; Wed, 5 Aug 2026 04:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785903890; cv=none; b=DwUtI3iNsCSBN5q0LI9b4hmtoSCwC63RYt9hv6KpgaZhPetpLfGrQf9y4eFsGRsQQhBpF/K/qD1VtxZZSN/Que34o6R8AMA18183uSi0Md48pFZsdLIjyC/Xet/MZovLjQ5MNjt4UlBYhJ5JLJpY825G7z+RoJkSIh5oyOGlXw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785903890; c=relaxed/simple; bh=BkKPJmVHyb+jgnlH6d6TKR0RXMa70aeLG+hWcgoOaWs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aAzFgQGimQGDU08uNZ0ox6kgXCHIkT4znn4ORBBCu8OaNunVLUX4Gr2pQFMtPa71tr2GZ/UmepTstxK95OK67UPmlvyVVvRKyJvv/qgdIyWgi+aa8dj0clbMKcHMPyZUGVk4ydr5bP7POP3cwSqpd9lD4RBDtw01RZIyIFAXzkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VhiAaKEO; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VhiAaKEO" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ceaf8a1265so9016785ad.2 for ; Tue, 04 Aug 2026 21:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785903887; x=1786508687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cwRdoBc/EmK1WOPOfn5hh+h3aMhUdxfVRSZXe1BrYw8=; b=VhiAaKEO5+W8XeFiGGsAoJSEdRAYFavmXNNXoV9J0MHoip5tQixuDgSEy9iW94Z+SZ OF594leeUS8sH5FKiOEumNkemApXZs0qA1RIAm4NRBVZL5ADEeJeGKGjj0h9XBlu0HsG YI3cnWlxuzCf5usIm5Fb60glAwr4M//aYsUTu50TOZEhREACdinHqr+EQjWLqGFpENdG s0+99sK1a5fy35pXiHolhFhIaoUo+20bcupBM8aSHaxMHAVuIgWno3hb40GvNkZV11+w JIpWGTXuyQDHjs6+ka9gBYAzHbeQ4lU4HEZVgtQR6g8YwmmMXaSwqfQGHRjfbkjNozzY SkCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785903887; x=1786508687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cwRdoBc/EmK1WOPOfn5hh+h3aMhUdxfVRSZXe1BrYw8=; b=GM/mnJLz9xuoBKlFK8sI+Umj9CXC2QEQZvA3nuZ/Dl2B5In+2u61IqFA9U1veEQEgA 6tSnQkz8Klhx+OnddqwsMtF2aPvvlpydbCa7qMDET20f3Dtz1c41p0mcjk2qLlj2B/Mt LEyPF12cTtWC86t2oSAzSDx1AbmykwJZpuFEOMRo0vJpwKwtkRON+I58dDVD/933xvVF 4EcyUv/7PTro46MuHREED/UNiCvVi42pRWJSR/Ll7adI0F3GgbT5EybDllTAWXHgiGPb iQnmp4sFeeUGYf+z3wh5f+IH+I61+dTMhgXLg9AvFi0jRmmDCNwwpvY9YMsHaPqHhuSE 0PUw== X-Forwarded-Encrypted: i=1; AHgh+RpwnT8okHqL/4KFAcYPceOBk/Etmq853tAccN6/tI5ouKnhF90dqjrOoR0yieSJgtqG8w73jkUV2CIIPlk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt2gqJNSsNTQ/640/zqojO5ToYkYiPeXMDT+dhYSEunGEcqOsA uXYaOhcLezAR33+zdPmhdSS8IcSaEKafj+dgp/vxR6HaV247rszM5OVO X-Gm-Gg: AR+sD10R8MnvgnDtGTLHHem8rksutOPXLJGUm7RbRUXqO64keOqlm4im5NfPd1f+otq 7PP+y0a/m7qqtBG5UWYAg8VnpZr2tegZW6++uCmyv7tN7i0mkF3gNhzeBNKVEnvoDl+RUr1peuk wn+QrY8TORiTvplyQDamcYsxxUFfxzxeiOBSkT7GtLudEl7P0HiphfMTMVcrnW9dWg96dJArfBw iF02TLYGwx9atF6oxW2mJLZHtaATlaZ538B1VTK5tp1ooRp2lXACcU9i0H9QThCfQcBHGBnh12f g5GdzEl9gbx63tnB0CFylnKaczec67O5uHTOA7bpWks79l0zng7hcELwlppQi/zSivw/mz4Ip91 A6NGXR0C6ypyzBfmBH/ytj3D9zhMyrLZOrIIW0Upx0rdo69ZapC9/242YbV2h0nQYiTukCWqIxo xh8nooblBaLukw2fZ7b3vuZyDbYOf+dYLWuxgFYqBB9C9iubHJfKwxapXCpHBSrk0+VYmxK0nag fG735IVWvd+Rt4yZTWpGrZ2mOs= X-Received: by 2002:a05:6a21:50b:b0:3c3:8aa8:6caf with SMTP id adf61e73a8af0-3cb85efb72bmr4598957637.27.1785903887193; Tue, 04 Aug 2026 21:24:47 -0700 (PDT) Received: from localhost.localdomain ([152.59.182.249]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3158673b7f4sm11815957eec.17.2026.08.04.21.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 21:24:46 -0700 (PDT) From: Krishan Singh To: linux@armlinux.org.uk Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krishan Singh Subject: [PATCH] net: sfp: Fix memory leak of hwmon_name on hwmon registration failure Date: Wed, 5 Aug 2026 09:54:35 +0530 Message-Id: <20260805042435.194101-1-krishanmohan298@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hwmon_sanitize_name() allocates sfp->hwmon_name before hwmon_device_register_with_info() is called. If the registration fails, sfp->hwmon_dev is left as an error pointer while sfp->hwmon_name remains allocated. Later, when the SFP module is removed, sfp_hwmon_remove() is still called. However, it frees sfp->hwmon_name only when !IS_ERR_OR_NULL(sfp->hwmon_dev) is true. Since sfp->hwmon_dev is an error pointer in the failure case, the cleanup block is skipped and hwmon_name is leaked. Fix this by cleaning up hwmon_name independently of hwmon_dev. Continue to unregister the hwmon device only when hwmon_dev is valid, but free hwmon_name whenever it is a valid allocated pointer. Fixes: 3f118c449c8e ("net: sfp: use hwmon_sanitize_name()") Suggested-by: Andrew Lunn Signed-off-by: Krishan Singh --- drivers/net/phy/sfp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index f52020673..f605fb399 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1895,9 +1895,13 @@ static void sfp_hwmon_probe(struct work_struct *work) sfp->hwmon_name, sfp, &sfp_hwmon_chip_info, NULL); - if (IS_ERR(sfp->hwmon_dev)) + if (IS_ERR(sfp->hwmon_dev)) { dev_err(sfp->dev, "failed to register hwmon device: %ld\n", PTR_ERR(sfp->hwmon_dev)); + kfree(sfp->hwmon_name); + sfp->hwmon_name = NULL; + sfp->hwmon_dev = NULL; + } } static int sfp_hwmon_insert(struct sfp *sfp) -- 2.34.1