From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2723C3FC5B7 for ; Wed, 5 Aug 2026 09:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922553; cv=none; b=ZDx0/AJwHkq8uYsocflqQchNrJuAN/o6dsiiG/eZovfJvDkfxgCqEokWn7epnaRkDPBDvrUAaJjEGh47wt37FXCHE5v0ff0O+yxX+LI8L+XUOZFqQChEDDJYcxtIzrBS1IKzlIrShb8WYrNKZLjKHsR6LwmAehSBRCxfMOsYLvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785922553; c=relaxed/simple; bh=KXowkc/ljD5yI4iSSJBvq6TaV/Gb23GeEQGfZKg1n+E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=mjJhB862pHuvrM/yzCw6WHzDwTFuYL166pUrjNMXOOAOv2Xz1Sy8/jWXffEbVqSnX5/BMU4fqCs7lRIVkQKrpeXUJwOZOUs1pHHvbJHBiLcVJpRF29O5F57cqFR/SPjqSuLDRfIEudPEKIaom4O/LY0S0HCM0FVDi0EAGJmdGVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ICYYqaON; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ICYYqaON" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c15ca7a7ca9so83079166b.0 for ; Wed, 05 Aug 2026 02:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785922548; x=1786527348; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Ku8QTspetYj8lLR50mkVMOWBFvWv4K2J0SdwVp76moE=; b=ICYYqaON6w1OENaZTBLK1QBt2nGos+J4K9Qz+DSEcoWRgCTLEC250oFfpftu/81pOw OL/nQ/xPB5VVgPwWLZWY/eyiYBRK68n7QeO0R9k3wUBTPWJpteS7WFp1eLgcpzRWTf2r dsf6VsPxjq8wJRlNxLSPNph8bpRLX3Yqf5DcEaiKI8y7e24z4CKT+QjcjGQhoAIasVh4 z0ja1Rfo9i7tFNC3nr+ggRgGsisnVQ2dZJgZ96h+C1Eu+/D7mN2zVjfM0q0mUml7uH+4 9Nl74NYt6wZffIGJCln4vo2RXUUky/+3+i2wt/iWiPCnLutGMUeLy84AOuDG+fKH67uC NkPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785922548; x=1786527348; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ku8QTspetYj8lLR50mkVMOWBFvWv4K2J0SdwVp76moE=; b=O1CXaKl59h++QCWxWVek3v9q4J3eUdiS9c869Hq1Jggk7rhQ0KEMIZiw+rIV+uo6jo qDJ0tfgZ7SKxe/ixVNzVq3NA9laLffQMNBx7S83NfcNm4ZyYu2OtiDbzvhuHKyeI+7zD YrdwWkgKSONFMOwlKFb2Ol/z/4FdUfgHmjpM8BkCEOI2fbf+5l6ZC562HVHpZH4DOVl/ MS3f6x7bgA39CJi464SZfM+RUueZmCUB0A4+WdaE/rc0vkri/9OWqUPgL1u/JSy820lL TTaOD4vWNF+AaepTKDQ+M951qTK6ZKnLuxAOYT8LMI3GMTzwEtkTl1xheeAqL1igcMBg z6Eg== X-Forwarded-Encrypted: i=1; AHgh+Rp00jAmRmkkpzS/nyrJSgB1PhqZOiBUfIPspxVaIR+hp3Jsz5ccJRemZ2JfFohP9rjIqBqzmWLVYPEZkcQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy7EqDZbxyOGcsyRMeBH+aJmv7vAdZVY6C5z8lFygefkTA6v/n jsSLvYzRAazH1AQbzztZAVPhbQumxgfvmyIM4wect3GuvJTnENx3q4aF X-Gm-Gg: AR+sD13JEC4i6AU3Ybrbw9vu/lhtabVVGIXgmVGNt4ZTDs1stneLqT0Vz2kxFyZzU4N dayRqxeHE/kPeqmykaadNcxKjuzPMuZGrSB+F73yyaU3fnv69+PVZViDkwHsaJqCZo16mvSQyfe 6CLsI2I0rGemxdN2GlaeqDdqBI6sVj68Ys3MYk7EdBVK4RK55Mste7O5KjMKoBS1jpNe/zYdpvK q7IYVR5bKvUmBQyfP/B5AezhcxJFa4Np+y2yGR0CLZdbFPhEq+NgR/UqFn00l7NHJcgQropJiyA /Cj4sc2e7WmuU3FWcZIhcdi3i8QapTqkO5OftB8KjZiwtv6jvXPYTLVH2X7JvmshCzSoPNWcc7J YzwUSgxtGjH1ZuH3wAIoSVPNTHfWeMRjeHW2lfilH7HjYgf4089GnPGLqtFpuEjF3MBqZ0WsGDN mnwR5fvu55gU05LDe1uIfci9WHWLBnmDBfY4oBNaCFBQl0Fc5We9s1To0F15Ekgf6VB5yHZguJz pwo2pm7NUjBpvzj X-Received: by 2002:a17:907:9455:b0:c15:bea2:d209 with SMTP id a640c23a62f3a-c2039abd3e8mr244824666b.4.1785922548220; Wed, 05 Aug 2026 02:35:48 -0700 (PDT) Received: from localhost (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203645c087sm87197666b.58.2026.08.05.02.35.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Aug 2026 02:35:47 -0700 (PDT) From: Eli Billauer To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, corbet@lwn.net, Eli Billauer Subject: [PATCH v4 5/7] char: xillybus: Integer arithmetic improvements Date: Wed, 5 Aug 2026 11:34:34 +0200 Message-Id: <20260805093436.59740-6-eli.billauer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260805093436.59740-1-eli.billauer@gmail.com> References: <20260805093436.59740-1-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Choose unsigned integers instead of signed where natural, and also ensure overflow wraps as expected. Simplify an arithmetic expression too. No functional change is expected, as the relevant variables normally never reach values where this transition matters. Assisted-by: Deepseek:v4-pro Kimi:K2.6 ChatGPT:GPT-5.5 Claude:Sonnet-4.6 Signed-off-by: Eli Billauer --- Notes: Changelog: ========= No change on v3->v4. Changes v2->v3: -- Add Assisted-by tag to description No change on v1->v2. drivers/char/xillybus/xillybus_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c index 7acebc1e6050..b264578b2572 100644 --- a/drivers/char/xillybus/xillybus_core.c +++ b/drivers/char/xillybus/xillybus_core.c @@ -343,7 +343,8 @@ static int xilly_map_single(struct xilly_endpoint *ep, static int xilly_get_dma_buffers(struct xilly_endpoint *ep, struct xilly_alloc_state *s, struct xilly_buffer **buffers, - int bufnum, int bytebufsize) + unsigned int bufnum, + unsigned int bytebufsize) { int i, rc; dma_addr_t dma_addr; @@ -431,8 +432,8 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, struct device *dev = ep->dev; int i, entry, rc; struct xilly_channel *channel; - int channelnum, bufnum, bufsize, format, is_writebuf; - int bytebufsize; + unsigned int channelnum, bufnum, bufsize, format, is_writebuf; + unsigned int bytebufsize; int synchronous, allowpartial, exclusive_open, seekable; int supports_nonempty; int msg_buf_done = 0; @@ -531,8 +532,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, channel->log2_element_size = ((format > 2) ? 2 : format); - bytebufsize = bufsize * - (1 << channel->log2_element_size); + bytebufsize = bufsize << channel->log2_element_size; buffers = devm_kcalloc(dev, bufnum, sizeof(struct xilly_buffer *), @@ -589,7 +589,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, static int xilly_scan_idt(struct xilly_endpoint *endpoint, struct xilly_idt_handle *idt_handle) { - int count = 0; + unsigned int count = 0; unsigned char *idt = endpoint->channels[1]->wr_buffers[0]->addr; unsigned char *end_of_idt = idt + endpoint->idtlen - 4; unsigned char *scan; -- 2.34.1