From: Simon Horman <horms@kernel.org>
To: Fan Wu <fanwu01@zju.edu.cn>
Cc: netdev@vger.kernel.org, david@ixit.cz, mgreer@animalcreek.com,
oe-linux-nfc@lists.linux.dev, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v3 0/2] nfc: trf7970a: fix lifetime ordering around IRQ setup and teardown
Date: Wed, 5 Aug 2026 12:50:54 +0100 [thread overview]
Message-ID: <20260805115054.GR51943@horms.kernel.org> (raw)
In-Reply-To: <20260801051058.354165-1-fanwu01@zju.edu.cn>
On Sat, Aug 01, 2026 at 05:10:56AM +0000, Fan Wu wrote:
> Two lifetime-ordering fixes for the trf7970a NFC digital driver.
>
> Patch 1 sets up the lock and timeout work before the threaded IRQ is
> registered, and moves the lock to devm_mutex_init() so its teardown is
> part of the devres lifetime.
>
> Patch 2 depends on patch 1 and drains the timeout work across removal:
> it marks a running handler to skip completion, handles LISTENING_MD in
> shutdown, and cancels the work after the digital core stops issuing
> commands and before the digital device is freed.
>
> These were previously sent as standalone patches. Per review feedback
> from Simon Horman they are respun as a series.
>
> ---
>
> v3:
> - Respun as a 2-patch series with an explicit dependency.
> - Patch 1: switch to devm_mutex_init(); remove the explicit
> mutex_destroy() calls and the now-empty err_destroy_lock label.
> - Patch 2: set ignore_timeout before send_err_upstream; handle
> TRF7970A_ST_LISTENING_MD in shutdown.
> - Patch 1 was previously sent standalone.
>
> init-order v1: https://lore.kernel.org/netdev/20260728031021.230831-1-fanwu01@zju.edu.cn/
> teardown v2: https://lore.kernel.org/netdev/20260728030716.230626-1-fanwu01@zju.edu.cn/
> teardown v1: https://lore.kernel.org/netdev/20260721133539.3195899-1-fanwu01@zju.edu.cn/
For the series:
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-08-05 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 5:10 [PATCH net v3 0/2] nfc: trf7970a: fix lifetime ordering around IRQ setup and teardown Fan Wu
2026-08-01 5:10 ` [PATCH net v3 1/2] nfc: trf7970a: set up lock and timeout work before requesting IRQ Fan Wu
2026-08-01 5:10 ` [PATCH net v3 2/2] nfc: trf7970a: quiesce timeout work before teardown Fan Wu
2026-08-05 11:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805115054.GR51943@horms.kernel.org \
--to=horms@kernel.org \
--cc=david@ixit.cz \
--cc=fanwu01@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox