From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A793955FE for ; Wed, 5 Aug 2026 15:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785945084; cv=none; b=SyiqIXTjCQ7HReolf7PYMYj4y4tg6/ARepF7kAU6UlKPeioGoI/dbPi4mZ6XsqUUcIlXE/iL1Qhs8HYqrdkNtRIjKDjYFWLkL3ZakZfUhoni445cOwI+hzRmjZxwFnIth8QtP7tAo2nCDEMbRpTVV99dOoLvyFQ96qRzmlBfrrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785945084; c=relaxed/simple; bh=aqxi35qz8X0Jeybg10HKbsHNV5CZpS0quNYjwJCSOIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SAIayc2RylCzojtE3IevqlpJLPMnlhjJA38hSzDWGDyDmVl5mvZrlW+v4GrebOwizpT65Op/R9B+YYWuMpDDjid9ZLuDyOteRlOpHPLWG09uHK65h3WzRkDUm4V3BI/MPZDHguYYs/63P+tcOaL3J1FyKoJ6dsT3F3o+qu99oRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PiuPOajk; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PiuPOajk" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47c2ae992beso87616f8f.2 for ; Wed, 05 Aug 2026 08:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785945079; x=1786549879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aqxi35qz8X0Jeybg10HKbsHNV5CZpS0quNYjwJCSOIM=; b=PiuPOajk2Vdi8dyRQUkGO3ldmd9NxZ6BelFi1f8LTc7e+IZ/tszFM1kCVVHq7NbI3u +AWCI2AR2+nQWR0DYU57qZWvk079sZqYEd8MKTslahOsAoNH9vJ4/o3w4LCjtW1Lce4G b3kaIx9lXlz6NVVqV3eykGLs2tkDZJY2T29fz/SWLwgyj3vAUCdCCPyFuHPBETbKA+BQ IUyew2mP37HdutiycjZGtzEC/lK7jjF2iGXr0f8WXc2DoYmjSClGGM18itSX9turECud /rQn+aN7f1bEYM4Ps+W/nf7HALo6MojlIyxzzBtjtsklD8viDsyMQg+yP801ERwfREtD JaDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785945079; x=1786549879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aqxi35qz8X0Jeybg10HKbsHNV5CZpS0quNYjwJCSOIM=; b=DgoACSF/deHO+RYfYLVAKBeLxPkgVNC6yJ3NhAX3XoodmTCF6OxG8VYih9GuzuIMJB SUYx4pgliaeVnWQYIBRGDCe92VE5OylNrZrqFfbohCg1a+IW3jvJoPadqCSFo9/lSH4x 37vpAbE5bqpvCPVAn2d4IfywE4CKVl5KLi6NbYUGVL/CNNZtCTj/jVeCVdFb3m0k/hir fBol6Xgpf2NtAKxMdqnq9wqRGo4UPYDmbqtOtxr7CrPoyDMDP6izX6EvwFE2FNpV8cTY 7wUpU69Q/Cg45G1LEocSySk34LMZhNTLM9I7mJ6HyDgQZRyzbWJYFp1rwnbTkPFjH/8u rSYA== X-Forwarded-Encrypted: i=1; AHgh+Rr0NlwflW63kkC5t07LJor+CKRyVlF64TpIBSDNRlWAwL4ueRPczIJtReBAlt7kCWkTduipDSxV/VnGJAs=@vger.kernel.org X-Gm-Message-State: AOJu0YyqHFYEVmeGgHofL5ZBPkg9d0vo8OpYIY3B22x5KFS/QvnyhhuI kTa0LarRXW34RvQoVrrDOviWfQICKdKli0V7t0KUssZCqUlkvRScTswZ X-Gm-Gg: AR+sD13Mquvxm+vSkPThKbn2y+ebQhArASKiZm+CsUYh3UnbmFwOSZVMBAnFTGQy9SP kU9tY/59q7f+r4RGZ/OBTOa8/XOnXqpMo8QmKj4qZijEaqmZAHVFw+ByQQ5HXsuwlUlT79Ge+cF DGiJ6BQ5pdx3d8zLH8hCKGLa0SrfrUIbJ0sreom1vlEyXi918JC5KkP8U4Yi7gstnJlGQczIbSJ weFP34v6YbkYwKLWv5cRicBoqf5uLH0AYEMHSrOzBy82f7P6kYy1kx5THzZmlXIousmdtdEX5LR xfGp+QVRpgpx3Z1vJneGKQADqX0TO0Vrfj5U1L4JJGv3kUh5WQg2jhPuBpkRdgXtwuHMrf9q7Hj 7vNraPBawDgThHCRmpw/gE7gsuVh9E+ZJqgKg6/+TuAw7yXqp6Nco/3kkJqc1F5Is/jOf8Tp+iS xf2LPsWkvD9mlEbjODpFagBAPJztIHuNYOijHjvLsrgXFsQoCXXObyIyxLijLx5ivbNhYbVQY7u QseafD0BQPrZfGYhN7B0rlI2WFFatnpdwjj/WInlcObomrb4FW5A+dqS40nmButGKLV X-Received: by 2002:a05:600c:1550:b0:493:ad11:6d5c with SMTP id 5b1f17b1804b1-4994e7cf0dcmr48652415e9.4.1785945079009; Wed, 05 Aug 2026 08:51:19 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B86F10001BE789C6EE938EE.dsl.pool.telekom.hu. [2001:4c4e:1b86:f100:1be:789c:6ee9:38ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e0356d4sm101820155e9.10.2026.08.05.08.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 08:51:18 -0700 (PDT) From: Igor Paunovic To: dri-devel@lists.freedesktop.org Cc: Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Cristian Ciocaltea Subject: Re: [PATCH v2] drm/rockchip: dw_hdmi_qp: attach the HDMI Colorspace connector property Date: Wed, 5 Aug 2026 17:51:04 +0200 Message-ID: <20260805155107.11167-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260805154418.8133B1F00A3A@smtp.kernel.org> References: <20260805154418.8133B1F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, Thank you for the review. The lifetime mismatch is real and worth spelling out precisely: hdmi is allocated with drmm_kzalloc() against the DRM device, while the HPD interrupt is registered with devm_request_threaded_irq() against the component's platform device, with hdmi as the cookie and IRQF_SHARED set. The bind error paths that follow the IRQ registration predate this patch: encoder init, dw_hdmi_qp_bind() and drm_bridge_connector_init() can all return with the handler still registered. This patch adds one more such return, which can only trigger if the property allocation fails under memory pressure. So the issue is pre-existing, correctly flagged as such, and this change does not alter the exposure in any practical way. The clean fix looks orthogonal to this patch: register the IRQ with plain request_threaded_irq() and tie its release to the DRM device with drmm_add_action_or_reset(), so the handler cannot outlive the structure it dereferences. Happy to send that as a separate follow-up if the maintainers think it is worth doing. Thanks, Igor