From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDB0387375 for ; Thu, 6 Aug 2026 05:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993785; cv=none; b=irA9QU0FKVhO1JYwzzSuto4qrw2ojb8F5oZw24NuRYu61A54SnpMHQF+R9t5Tx4NGwft43JwcJRsHhvwAlQM1QD2Mhc6dQ0ta3LSixU0o7Qim/3+SCrKaDSfURsmxFdx9oak5GhYQheQJcdkHp+UzE4m29P/0LvG9yJcIoIHfIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785993785; c=relaxed/simple; bh=AdAcsu+F2nHo0B9JO6GhlAQMeLvpoicLvleufnIkTJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNBW8OeuYGnurssV1dtxmtVQTCgD72Mig0spQfo+vKix7Va1uSOvNtJ/rIuXu2Q0fFbGrEWrvrblWQn/8/QyiCG/01dUFxFReQ/p87qbLWA27ITPu/CiLt2SpTo6Nn5emHpjVgMRpKGYi4IsyYYEHHoxFyIUC+Q8wjHX+Fv6aj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AqjvNoS3; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AqjvNoS3" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84e0688b7e8so1717863b3a.1 for ; Wed, 05 Aug 2026 22:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785993783; x=1786598583; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GBK+k3DpjSm3fu5kk5NiqqkKTtgyJPYe4ia8RdreH3g=; b=AqjvNoS3w090ki1APhxW6BBC+09w3LIs7CQCwyOWMo3Euy0AVsh0y7LK+/zoRwC5ZA PQrLTRS4TwQh+1u7iukp3Xdqo8wZMbTNyZJ/YDATxUMSlLJSOWiY4/to+BUPb5gh5V4R zcVLyzMs2ZoKSeL5H3H4FlDE27304tXWy/j9AY/cGDmvaNzVwhrLJfMcam/OsCsz9PB3 9X4OlNbGieF/rNaEtlJbK67IOSwVsP4duBTRWt2HubB7wfVDNE7QJq3HkEbU2rJmUlVn 9LGvmPF0Puiu7XE1kJrlhCV+2XXsfF0FoBZTxnvGbA7Ui7syLNTHO4qEPx99TV6EmmlX Hd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785993783; x=1786598583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GBK+k3DpjSm3fu5kk5NiqqkKTtgyJPYe4ia8RdreH3g=; b=pTkJUtRUjb26Q9sui6cZ6n3JWqswpWnd5IIF7AiBvxEFhYxW/fiNo8KA+wRumY7/6c DHrz20qMwfCSikjiVifjaoiyz1WIaN5hFvqcp0Y710ctKVn10xM+P53ZLr1JwLkK6hVf YxEb4NFatVHWeThzFNWhWMSdSTp1Yk9slgtXhDUAQyqKDyOIAhR0Dw4QH7I+6NhcXYvG 6NPLsWxUR+TQNy1hBhYAZER93rM6aPRztMeeJTrOVZ6+TmZR3LfoeB6lQUj4IUv3Dhj7 Awf5IM1zXouD1Ur8NonT6jMlji0SLV8hE9Y9VVOdLw8pq0Ty7SaB6eLwWyBkdG3VyXLo fyQw== X-Gm-Message-State: AOJu0YzfCKja0e7Da6OtkkYY8rroQfqfE0EyiVxSJhivVEDMoiZqbMwE lAt+CWqXF7lBqU2lh7CE/iuwEQHIXN551k2bniDrGUwp6kKf1N80+0Hs X-Gm-Gg: AR+sD10TZk9IyLZPxWO77NmOuzoWaSxKGgACJEQu3NM68hnD7LfNkLkDPpn1ErIbMuV s8jPQp7Tl2lf7YCpxCOz6gs7/IYpiIaRbP615da2WeCRRX3PkXGQYy8DGvx4tkbVJWqXsypB46G KryjAF/235KhwuRKLnl/faqCKuGZAiLUM6wT6WBgg4T/cEhsG6lAAxFnz3lSbpeQUzRs22MV/D7 9SkIbOoHehVn4gpuaDoXkE2X3G5BQO+/yg0Gl28wAyn38NjgJ23/VLA4g0o02sVRFrVF9Rgqfa2 GwESIVdl4c40dVRPl6IuvxzvE2A7LPZsdH/EelqAxEsF89U4N5uRD1WTUsf9nLZwcZL3+2t6RDH bL/FzeF8ORX96S60kO/9N2R2rn1FMLgAGoAgLOYamXYVMEDWh7UYDCpuOmdqV/Spza/HUx3QIy4 +2Hu2l4TkWmxd8M6o1CWc2cxNqp7t+rSw3GN/QieygJ4syl4ryRDhoxVHVWuGdeC9XSNH5tn/yj QXG0FiALs3egxoiq2dK47DMVyD1joM0jw9cifW2QQmWaWVVJYYp+P/fmt6KcuWn9zzcvOzXcaJF OQ8PVF8v7kpuAKYo X-Received: by 2002:a05:6a00:c81:b0:845:cdc1:a803 with SMTP id d2e1a72fcca58-84f2dfc4763mr13549981b3a.11.1785993783204; Wed, 05 Aug 2026 22:23:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f45bc9cffsm554279b3a.59.2026.08.05.22.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:23:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , Nicolas Frattaroli , linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 12/14] ASoC: rockchip: rockchip_sai: Return the original error code Date: Thu, 6 Aug 2026 12:21:34 +0700 Message-ID: <20260806052136.21034-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806052136.21034-1-phucduc.bui@gmail.com> References: <20260806052136.21034-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Return the original error code directly and drop the redundant error message since the called function already reports the failure. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_sai.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_sai.c b/sound/soc/rockchip/rockchip_sai.c index 522b4f4f6a7a..1fdec12a0d4e 100644 --- a/sound/soc/rockchip/rockchip_sai.c +++ b/sound/soc/rockchip/rockchip_sai.c @@ -1434,8 +1434,7 @@ static int rockchip_sai_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, rockchip_sai_isr, IRQF_SHARED, node->name, sai); if (ret) - return dev_err_probe(&pdev->dev, ret, - "Failed to request irq %d\n", irq); + return ret; } else { dev_dbg(&pdev->dev, "Asked for an IRQ but got %d\n", irq); } @@ -1458,7 +1457,7 @@ static int rockchip_sai_probe(struct platform_device *pdev) ret = rockchip_sai_parse_paths(sai, node); if (ret) - return dev_err_probe(&pdev->dev, ret, "Failed to parse paths\n"); + return ret; /* * From here on, all register accesses need to be wrapped in -- 2.43.0