The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tariq Toukan <tariqt@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Alex Vesker <valex@nvidia.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Gal Pressman <gal@nvidia.com>,
	Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	Kees Cook <kees@kernel.org>,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	Mark Bloch <mbloch@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Yevgeny Kliteynik <kliteyn@nvidia.com>
Subject: Re: [PATCH net RESEND] net/mlx5: Use unique names for software steering caches
Date: Thu, 6 Aug 2026 14:17:39 +0300	[thread overview]
Message-ID: <20260806111739.GF23431@unreal> (raw)
In-Reply-To: <20260804145756.331951b7@kernel.org>

On Tue, Aug 04, 2026 at 02:57:56PM -0700, Jakub Kicinski wrote:
> On Tue, 4 Aug 2026 11:04:55 +0300 Leon Romanovsky wrote:
> > On Mon, Aug 03, 2026 at 06:26:14PM -0700, Jakub Kicinski wrote:
> > > On Fri, 31 Jul 2026 00:02:00 +0300 Tariq Toukan wrote:  
> > > > Prefix each cache name with the device name to make it unique.  
> > > 
> > > Why do we need a per-device kmem_cache?
> > > Isn't the right fix to make this driver-level state?  
> > 
> > This kmem_cache is required only for software managed steering mode, which is
> > configured per device by mlx5_fs_mode_set(). In general, resources
> > should be allocated only when they are actually needed.
> 
> Of course you have to wrap the init in a lock and count users.
> Trivial stuff.

I don't see why we should abandon the simple, architecturally
correct approach of allocating and managing resources where they
belong in favor of a more complex global scheme involving locking
and reference counting.

Thanks

      reply	other threads:[~2026-08-06 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 21:02 [PATCH net RESEND] net/mlx5: Use unique names for software steering caches Tariq Toukan
2026-08-04  1:26 ` Jakub Kicinski
2026-08-04  8:04   ` Leon Romanovsky
2026-08-04 21:57     ` Jakub Kicinski
2026-08-06 11:17       ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806111739.GF23431@unreal \
    --to=leon@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=borntraeger@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=kees@kernel.org \
    --cc=kliteyn@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    --cc=valex@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox