The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, akhilrajeev@nvidia.com,
	mukesh.savaliya@oss.qualcomm.com, rafael@kernel.org,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [PATCH V4 05/14] i3c: Make dev->desc locking assumptions explicit
Date: Thu,  6 Aug 2026 16:18:48 +0300	[thread overview]
Message-ID: <20260806131857.119830-6-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260806131857.119830-1-adrian.hunter@intel.com>

i3c_device_get_info() takes the bus normal-use lock before accessing
dev->desc. Under that lock, the descriptor pointer is guaranteed to be
valid for the duration of the access.

Remove the unnecessary NULL check on dev->desc so the code more clearly
reflects the locking rules and expected descriptor lifetime.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
---


Changes in V4:

	Added Mukesh's Acked-by tag

Changes in V3:

	New patch


 drivers/i3c/device.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
index a3778282e84c..5e6df6de0283 100644
--- a/drivers/i3c/device.c
+++ b/drivers/i3c/device.c
@@ -101,8 +101,7 @@ void i3c_device_get_info(const struct i3c_device *dev,
 		return;
 
 	i3c_bus_normaluse_lock(dev->bus);
-	if (dev->desc)
-		*info = dev->desc->info;
+	*info = dev->desc->info;
 	i3c_bus_normaluse_unlock(dev->bus);
 }
 EXPORT_SYMBOL_GPL(i3c_device_get_info);
-- 
2.53.0


  parent reply	other threads:[~2026-08-06 13:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 13:18 [PATCH V4 00/14] i3c: Support IBI-based system wakeup Adrian Hunter
2026-08-06 13:18 ` [PATCH V4 01/14] i3c: master: Fix recursive locking during device registration Adrian Hunter
2026-08-06 18:24   ` Frank Li
2026-08-06 13:18 ` [PATCH V4 02/14] i3c: Fix unlocked dereference of dev->desc in i3c_device_get_supported_xfer_mode() Adrian Hunter
2026-08-06 18:26   ` Frank Li
2026-08-06 13:18 ` [PATCH V4 03/14] i3c: master: Do not treat master device as a duplicate target Adrian Hunter
2026-08-06 13:18 ` [PATCH V4 04/14] i3c: master: Fix use-after-free of master->this Adrian Hunter
2026-08-06 18:30   ` Frank Li
2026-08-06 13:18 ` Adrian Hunter [this message]
2026-08-06 18:31   ` [PATCH V4 05/14] i3c: Make dev->desc locking assumptions explicit Frank Li
2026-08-06 13:18 ` [PATCH V4 06/14] i3c: master: Fix potential UAF in i3c_device_uevent() Adrian Hunter
2026-08-06 18:33   ` Frank Li
2026-08-06 13:18 ` [PATCH V4 07/14] i3c: master: Fix potential UAF in i3c_device_match() Adrian Hunter
2026-08-06 13:18 ` [PATCH V4 08/14] i3c: master: Support IBI-based wakeup capability Adrian Hunter
2026-08-06 18:58   ` Mukesh Savaliya
2026-08-06 13:18 ` [PATCH V4 09/14] i3c: master: Report wakeup events for IBIs Adrian Hunter
2026-08-06 18:35   ` Frank Li
2026-08-06 13:18 ` [PATCH V4 10/14] i3c: master: Add helper to query bus wakeup requirements Adrian Hunter
2026-08-06 18:46   ` Frank Li
2026-08-06 19:03   ` Mukesh Savaliya
2026-08-06 13:18 ` [PATCH V4 11/14] i3c: master: Reject IBI requests from non-IBI-capable devices Adrian Hunter
2026-08-06 13:18 ` [PATCH V4 12/14] i3c: mipi-i3c-hci-pci: Propagate I3C wakeup requirements to PCI Adrian Hunter
2026-08-06 18:42   ` Frank Li
2026-08-06 13:18 ` [PATCH V4 13/14] i3c: mipi-i3c-hci: Factor out i3c_hci_sysdev() Adrian Hunter
2026-08-06 18:44   ` Frank Li
2026-08-06 19:07   ` Mukesh Savaliya
2026-08-06 13:18 ` [PATCH V4 14/14] i3c: mipi-i3c-hci: Advertise IBI wakeup capability Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806131857.119830-6-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=akhilrajeev@nvidia.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mukesh.savaliya@oss.qualcomm.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox