From: Simon Horman <horms@kernel.org>
To: Fan Wu <fanwu01@zju.edu.cn>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 2/2] fjes: cancel force_close_task in fjes_remove()
Date: Thu, 6 Aug 2026 15:19:20 +0100 [thread overview]
Message-ID: <20260806141920.GE51943@horms.kernel.org> (raw)
In-Reply-To: <20260805012337.416908-1-fanwu01@zju.edu.cn>
On Wed, Aug 05, 2026 at 01:23:37AM +0000, Fan Wu wrote:
> force_close_task runs on the system workqueue, which destroy_workqueue()
> does not drain, so it can run after free_netdev() and touch freed memory.
> Cancel it after destroying the workqueues, before free_netdev().
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-08-06 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 1:14 [PATCH net 1/2] fjes: unregister the netdev before destroying the workqueues Fan Wu
2026-08-05 1:23 ` [PATCH net 2/2] fjes: cancel force_close_task in fjes_remove() Fan Wu
2026-08-06 14:19 ` Simon Horman [this message]
2026-08-06 14:19 ` [PATCH net 1/2] fjes: unregister the netdev before destroying the workqueues Simon Horman
2026-08-06 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806141920.GE51943@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fanwu01@zju.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox