From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D0413264D5 for ; Thu, 6 Aug 2026 15:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031330; cv=none; b=FxIqpLhTY4IIcHa6molz6k1C26VwhuvjZDpH7oThucJ8nwYXQ/RyhyZruvBfNBGFkSl8BIwjIPoVa9E+zcwuVZkZyrvETjk3TBQ3wiuSkCTg/CNLqrihhHRvbhHTPKSl2ldJz0U4/B81affwns+W2XqbAlTbktmhY9/FG7UBT60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031330; c=relaxed/simple; bh=aWCXSSNsElpY4uyTCzUXvpAUTRz9Rz0DBcdaVkkaRg0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KHZcYNcIw9Rwra5RwiDv/s84lQeR7oRlXwSAvFT7CmBaDNCIBWZwf3zO3aYEitFbo/hZaI850fDRGZZ9XcmNBnLQl24OfI+BJIoVFAwBfemADtAGPhkEBX8zVnnGbU3gcTBXeBoWQTurIJ2buE52Wuv0n9IN255qtZw5zbCJhGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=ZINI7sCS; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ZINI7sCS" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-930c0f9c1b1so149142285a.1 for ; Thu, 06 Aug 2026 08:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786031327; x=1786636127; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QwVSV5EsLBZnwEGlh4H7pVKLw7Dudnf8oqtelaeaz3g=; b=ZINI7sCSO/UQpZ6jr4GukWzK8Vyj9UkDIRkCC2IKiDJXVsSBPnecu7hazazekK3UxF L5QTW8dbj15HLiyOZfxL+YxMO7+YQXCKvQNtvd/fhFgtvtnRsXFrEgygep6mXkYWBMQx d71AUjHxPROxu4T9sAF4GkatDmqFETPKughUEpOr74+vP3hZSxUMjST2+NiSOZaf7WAh bUNDrSJ17raQv/wvbD/SWKJxDm03stS8yK3Y3R0cTJtjOo69YMh8LZzocqUAQjZideo+ u8N9rr+tbxLXfXp/oGqijCsarQgQNBTWldgJT+rDZ1R40VlxJQHgJkfkIgxu8R//wTZX D53A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786031327; x=1786636127; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QwVSV5EsLBZnwEGlh4H7pVKLw7Dudnf8oqtelaeaz3g=; b=OM961nrDTwxmaNtdZjckoA3EFrrawvjPmNFP5iA3kr0gDK0+bZQzdItA+xW79TMzmm YLnMNbQqeVwucaCbYiyRzkzZ7tAcQ5VuKeCcen4XBk8friX4UtoxHab9wRMa/028ZAJk wtWhPSn17kNCCMZwlyxNuqImyeLJjKiWaOlEn8SuJgn0xiHSnqWCwgbk5BEwlA/P9Hov yDwLAX/qNN17EbYri6n3++BDXQKILT/L743OK/LYheJZbilz3cL7qx05VapS5QUmxQOL xxuQsbd+ycFZAjpbR2RWOanlUd7l4La9r01SWlyKdeqH+KhdJWjdx8NXLd7c8UbdU9Tk ftNA== X-Forwarded-Encrypted: i=1; AHgh+RrMXNoQwSilceQ1cozsNO2o5QdAlfDPcYwgpbXOJC/ywW2NI+fM2APU4BrKWBgPXULKTKb9CSiTx8dwseI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxik5HvTC2xTBGecrZFuP325iYQLbYTIt5Kcy1c6ae8QibvNXpr jOdelNZ+btlqagQMPN/JGCu99/nk4UlOlqcIvwP0v4BKu/UziGCU9zD3GWM7q2Qx53U= X-Gm-Gg: AR+sD11pGuB7CVnc1VbNHpRLWL81W0cgwDz39E/RnoeTRzC5ymQdnNdSaqaSSLiFvtj WrKSGSa7SGdtZHB7YjV8te+i4DFWlyqdrNpwRmoO1xjs5Yy+I5SQ4ZsXi5PPhhN2dkbt3d0Byxi wFjVPP+Ipv85FTY4T/J3S9lzpaBazx+1bD/z1MCygHN34y20+Y5+X8nRh4xayxxD4EG1eMqLlPO /HnZUI/SGuk51186tqdEuWC7t3ZZJYvFb/RX4M3gWeDKfCpKi7AGHMusebOqLbZ1kDFTg9DJ2U6 lrQfgnccKnecvNd2RaLgNfkq9qJAi3CkrgR3nOqXwX3ZtgZ/WYFhG06XvUpw45CIxzF0RYMGJm8 L7J2Vsp4AcDrEbZ1Kx0nYZ9CeT2IIt8wN4YOPpf8xZ1EXFObRQ2SuwxvdKKNlWue0Xm9vwAoLAI qheS21+QQ9c1MfHmzGA4h5Cih9u+fDKL8rORIDjQ== X-Received: by 2002:a05:620a:4387:b0:92e:e299:dfdc with SMTP id af79cd13be357-93649181774mr1627443785a.21.1786031326741; Thu, 06 Aug 2026 08:48:46 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9364a5654d4sm424036985a.36.2026.08.06.08.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 08:48:45 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1ws0Kr-00000000ZDn-0FIt; Thu, 06 Aug 2026 12:48:45 -0300 Date: Thu, 6 Aug 2026 12:48:45 -0300 From: Jason Gunthorpe To: "Liam R. Howlett" Cc: "Vlastimil Babka (SUSE)" , syzbot , akpm@linux-foundation.org, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, pfalcato@suse.de, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] WARNING in mas_nomem Message-ID: <20260806154845.GF28508@ziepe.ca> References: <6a6c4f18.b1a781d0.210f9.001f.GAE@google.com> <6yf7k4fmg4tkbmli6t4qzrk2eiyuuynoc2oimbgaebught2yh5@dspb7xile3kj> <20260805004619.GA28508@ziepe.ca> <5cf3542f-fca7-44d0-8a17-8aa316b1fb12@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 10:29:27AM -0400, Liam R. Howlett wrote: > @@ -5609,8 +5612,7 @@ void *mas_store(struct ma_state *mas, void *entry) > goto store; > > mas_alloc_nodes(mas, GFP_NOWAIT); > - if (mas_is_err(mas)) > - return NULL; > + mas_nomem(mas, GFP_KERNEL | __GFP_NOFAIL); It still feels really weird to ignore the return code from mas_nomem.. void mas_nomem_nofail() ? and maybe it can have a WARN_ON Jason