From: Ning Ding <dingning04@gmail.com>
To: bpf@vger.kernel.org
Cc: memxor@gmail.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ning Ding <dingning04@gmail.com>
Subject: [PATCH bpf-next 2/2] selftests/bpf: Test RCU iterator state pruning
Date: Thu, 6 Aug 2026 17:43:20 -0700 [thread overview]
Message-ID: <20260807004320.134069-3-dingning04@gmail.com> (raw)
In-Reply-To: <20260807004320.134069-1-dingning04@gmail.com>
Add a path where RCU protection reaches zero and then starts again.
The iterator is untrusted after this gap and must be rejected.
Signed-off-by: Ning Ding <dingning04@gmail.com>
---
.../selftests/bpf/progs/iters_task_failure.c | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs/iters_task_failure.c b/tools/testing/selftests/bpf/progs/iters_task_failure.c
index fe3663dedbe14..bac394ae77f44 100644
--- a/tools/testing/selftests/bpf/progs/iters_task_failure.c
+++ b/tools/testing/selftests/bpf/progs/iters_task_failure.c
@@ -61,6 +61,33 @@ int BPF_PROG(iter_tasks_lock_and_unlock)
return 0;
}
+SEC("?fentry.s/" SYS_PREFIX "sys_getpgid")
+__failure __msg("expected an RCU CS when using bpf_iter_task_next")
+__flag(BPF_F_TEST_STATE_FREQ)
+int BPF_PROG(iter_tasks_rcu_state_pruning)
+{
+ struct bpf_iter_task it;
+
+ bpf_rcu_read_lock();
+ bpf_iter_task_new(&it, NULL, BPF_TASK_ITER_ALL_PROCS);
+
+ if (likely(bpf_get_prandom_u32())) {
+ /* Keep the outer RCU lock active. */
+ bpf_rcu_read_lock();
+ bpf_rcu_read_unlock();
+ } else {
+ /* Create an unprotected gap. */
+ bpf_rcu_read_unlock();
+ bpf_rcu_read_lock();
+ }
+
+ bpf_iter_task_next(&it);
+ bpf_iter_task_destroy(&it);
+ bpf_rcu_read_unlock();
+
+ return 0;
+}
+
SEC("?fentry.s/" SYS_PREFIX "sys_getpgid")
__failure __msg("expected an RCU CS when using bpf_iter_css_next")
int BPF_PROG(iter_css_lock_and_unlock)
--
2.43.0
prev parent reply other threads:[~2026-08-07 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 0:43 [PATCH bpf-next 0/2] bpf: Compare iterator types during state pruning Ning Ding
2026-08-07 0:43 ` [PATCH bpf-next 1/2] " Ning Ding
2026-08-07 0:43 ` Ning Ding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807004320.134069-3-dingning04@gmail.com \
--to=dingning04@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox