From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECD423AAF59 for ; Fri, 7 Aug 2026 03:52:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786074762; cv=none; b=lR6kQGU135XUK2u/ZNHDtL9v/23vDV6mpTPYj6+ojQMlHw4RQ9WaRWqHW0Abk841wDfStFKvF5q0tvU/t7W/OFWAIJrd28LEy29duKMcSvM4n6spy8/ICZ76bjIN8ALMKdTVhfm92CAsRFBgDTIiVOuzEUAlfB5a7G6yE+vZMLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786074762; c=relaxed/simple; bh=Mf9VzjKnGumLQ0UESxtM5HUID11ySTvu2WV0vwKzJyk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=rvzx0MNXMjrtYuR2rw6cOafwi8A4sn/151jzKK8oQLbvDtCTo4DeLXaAW0Om+pQU0BCaMTYeRtbE3j0gWWP0+iCJ53tlUEAifha/dzg3nWr3oz+rq3/TFHDP8UnO2tQhpukfvEFzPRZ7E4so14xRLjINr2jvdWl1MWq9i6jwYQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vw8Vsb7L; arc=none smtp.client-ip=209.85.216.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vw8Vsb7L" Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e1118e4abso4321473a91.0 for ; Thu, 06 Aug 2026 20:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786074760; x=1786679560; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v74fkH+T9qp22ctkQvaUkuJE0FnZiEKV1z5gp8lIp44=; b=vw8Vsb7LeIIl5lnz4VrIP8bsEVJKbOzTMp+mH2171gftpu2dhBYIC7ITc0BlEL6ppq GRmkurSqVln08HQqgF65d9gtlv2BW3bf7bwfXdLik1IrJCNOBR/5ZE3mQjP0LgGlMnnt xQ461de28FfS4KAIpIg3T9KcU8IYAEdiBYScfchG6H8reb8HQOed2Y34UMXyRwrqEKKy PFP1aYE26KgH8HqzMrrQbhwitn89ahEAKo6chnJaFnwweMftGrGFZz5kAXEs/yCNFBgH KHzZVQiEP0jLPpPX0LRLoIDTGdze4qujsVdMafqsug8ghN5o/++L4pmgT20bIA4o1QoA Zj3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786074760; x=1786679560; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v74fkH+T9qp22ctkQvaUkuJE0FnZiEKV1z5gp8lIp44=; b=InPk+UYi2orBkoEHI7yOKX8UmO+piicF6hnoL9P7I8Vo+ZeTqTfd0Tcfs6dQqhB6hu x3EAYNvvNIILRy/bOK034ZdnyxqCJ7DSfreRxEeEw58kU76isSM0VpffzszaEkpG854T bLYfdtqu/JyRPDK97uAtSxfBPQ82U10448xKzPaEDojbwJSxiOR4LHV4i79IOg9ffokO 6wpZfkZ4ZFPz6NE8XlzHgUmDdXrCVVW2Lj4t7eTz0BBlG42NhiOgV55lrO9T+eQnCZZg saaZ80/tF85CB5LoX2Yjb/LUDcrcuaiJgLPd9miSLfJTWnCMztQ664fdps1YGWtPEPw+ mYgg== X-Gm-Message-State: AOJu0Yy6c6obk9HHED3WQOmZwRW3XHzL8dgth+YCICXaT7D5tvr/r0HZ 5fYmH+25zCb1Uxn90N3hX+0XYMNvYHF/YIUfZLb6uRW/2AxcRl2syDFM64gtAwe0q/ek+tpagpx wxJzXEvI5Hb8D7fU8DralcRzFK7aHV0tu7LJQ6o4R+xYXedimcU4kVTbvc7LKs50OlGk7ovHxdH JCyy+Zl2wCK0D9QRaVxOASEp1x3+XESnrwKZZMDhyscFv9feXx X-Received: from pjbhk8.prod.google.com ([2002:a17:90b:2248:b0:381:27d7:fc1]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:57c3:b0:38e:bfe:81e9 with SMTP id 98e67ed59e1d1-3903c5589e0mr21693806a91.1.1786074760059; Thu, 06 Aug 2026 20:52:40 -0700 (PDT) Date: Fri, 7 Aug 2026 03:52:12 +0000 In-Reply-To: <20260807035232.1881495-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260807035232.1881495-1-jstultz@google.com> X-Mailer: git-send-email 2.55.0.654.g21b8a5bc05-goog Message-ID: <20260807035232.1881495-7-jstultz@google.com> Subject: [RESEND][PATCH v31 6/9] sched: Break out core of attach_tasks() helper into sched.h From: John Stultz To: LKML Cc: John Stultz , K Prateek Nayak , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , Andrea Righi , kuyo chang , hupu , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Pull the core of attach_tasks() out into sched.h so it can be used more generically. Suggested-by: K Prateek Nayak Signed-off-by: John Stultz --- Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: K Prateek Nayak Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: Andrea Righi Cc: kuyo chang Cc: hupu Cc: kernel-team@android.com --- kernel/sched/fair.c | 16 +--------------- kernel/sched/sched.h | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d78467ec6ee13..6d2fa0cd77779 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11035,21 +11035,7 @@ static int detach_tasks(struct lb_env *env) */ static void attach_tasks(struct lb_env *env) { - struct list_head *tasks = &env->tasks; - struct task_struct *p; - struct rq_flags rf; - - rq_lock(env->dst_rq, &rf); - update_rq_clock(env->dst_rq); - - while (!list_empty(tasks)) { - p = list_first_entry(tasks, struct task_struct, se.group_node); - list_del_init(&p->se.group_node); - - attach_task(env->dst_rq, p); - } - - rq_unlock(env->dst_rq, &rf); + __attach_tasks(env->dst_rq, &env->tasks); } #ifdef CONFIG_NO_HZ_COMMON diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 56acf502ba260..56d9c09c485e6 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3100,6 +3100,25 @@ static inline void attach_one_task(struct rq *rq, struct task_struct *p) attach_task(rq, p); } +/* + * __attach_tasks() - attaches a list of tasks (using se.group_node) to + * the new rq + */ +static inline void __attach_tasks(struct rq *rq, struct list_head *tasks) +{ + guard(rq_lock)(rq); + update_rq_clock(rq); + + while (!list_empty(tasks)) { + struct task_struct *p; + + p = list_first_entry(tasks, struct task_struct, se.group_node); + list_del_init(&p->se.group_node); + + attach_task(rq, p); + } +} + #ifdef CONFIG_PREEMPT_RT # define SCHED_NR_MIGRATE_BREAK 8 #else -- 2.55.0.654.g21b8a5bc05-goog