From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8705F46F487 for ; Fri, 7 Aug 2026 10:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786098593; cv=none; b=s4tr1RPs3vJGcQavUFIIc/h8vY2nCw/xHEPxhQ7JiSTDEA5UFYPGezSkG92YkWKA4vg/nIrP4Rz5jxyLgSv8NHS5uRrLcf7qgy+becdiMT23nCUV6NxrGknSK3Oweeiwc7gYog3dhTNjBgkQGTkgaexGHkuz4vEmLT4YCT/Qr/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786098593; c=relaxed/simple; bh=WWAAQdVCBeXAfxIC2KLs+oriyhRks9JZ8iBNmRWlKIY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lfakkkRVJ/qMePLXN2nZ2ckHD9PGM9Q14u/vDi25G/pH9AT8HkylTO0y1ZZrpzhzuwr85JKCN2K5+fM8jQULTMTYz2JoonpjHYirAjnlAZMP4Nzq21tqVOkkg3dNUhrB+HLAgzKJpxHZNxbDWYGwlICwcx97u7vUA2vBPQ2EiYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=azaWnCjg; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="azaWnCjg" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38759bcd877so3393408a91.2 for ; Fri, 07 Aug 2026 03:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786098592; x=1786703392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HZTcrQzGXuunNIwct3+GtblbyDkGvD9ZQvC5QSvDxeM=; b=azaWnCjgG887j/YkT0g3cR43WfIGzJbl95dM65UShK6e3zkZMSubJHJaK8UOL2ABPn /r59IQn+KlBFDwfm4VFnjmFjrvUN7Qs6b/pAGqRp8sWu7gVSumQvM9p5TZR0VLDOSB/S xkcJzRPP1KJHDflD3h68jG1podk5rE2/swT8GyQE5iMLH94jiPfN0KPH+mpaeTk/wZdR pRtmkHOGuSFgyoTCi2Y2ao5Cc16XxaZHHMdvUHqgI9pljSRsn5Lcy+ijKoSMY7ZvnTaD wxo7PbLnJmg4tsBcuCXYWByOmAvz6K5vJvyG0+fVWslaaEJFF3BepB/Yd6DPK8UWlhWR scXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786098592; x=1786703392; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HZTcrQzGXuunNIwct3+GtblbyDkGvD9ZQvC5QSvDxeM=; b=BkZfFcxwaCF5j1kaBCGSJjcbQZxtNW33sjgHRGEVX4XNNY4Cs3oDrXfXPsG2ArLgAS dBx3mksh9vpskXpWSI1TkTenmOyHVXGj1v07wuDDR8kRhrdJcICzbXkQymqpt5aeOkIP IeNbvaOnSSX5nKko7nxQbi6Iv3xxr2Edwpf+Jg4V9fAlpRPYCt3Ng1TJ35Hjb52RkGE0 FowCRXvUlpbznRdcegBSlvJbZcs4zwTjyaxubqsVLOWxV6aqWrsuDaSZAegWPttWzHEB cF/X2mM6b94a7esGdhSuZnuJwFOPCYbuPv694HcIRaWFHQsDDTLGc8Lc70q3eYrJgL9F FP7w== X-Forwarded-Encrypted: i=1; AHgh+RoPkg8B+C8rDR7UFCHgpzyaxob4qJOCFuDZyrSXOUyqaITtTV9ye5cObfPJ93g2BIZRrOAT6Fb5Uhbml+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2GJFyhx04n1g86BQ0wfb/cTNUatWfXAxKrkIYuIlV0P7ZLnr2 UVKZ2NNspDwySkVb1lXa/hColC9pWVJVyCuL46JSWbG6F1eI1xHYxwxj X-Gm-Gg: AR+sD12SiL76xaltTyEs3975Y4HXkVPxAWoQT43xqEeDipEroshHFMTSBDP2EaJWAGP /AISvns/ygvyEE/y4hyLsDQMaT0m/Z8JSzUwntaKEfvKkZ25AAwQs0/jQzXZNL76mX1bFZyusDG ZD3wq2ZvkYVVC5gEYsd4Wy9+t5E8sNWS2x1b9taGZ24z+6dq9bEA6ZsD54sQdB+H/fLNs9elxPO seT1fCNamaP8zzzzNarq+SxXK8IMj6s8Nqm2ygKy8KYjlcMn5D2cznaasURFTtCjI4ulbHJuPtJ iSwzlyyJMwsy7v9SbBzQdRo2AqmMs2j0UVcCJ7doq1ieZrzEBCP7w22Fq/8gkDQ9RqWusOwypBw LubU1eFsoCgem8+uuROYt15GNeAVFKsD04+ljJHkAtV0/M8dx3elpkaXshv6Of5Wlp7JTk/jFJK f2FWbBRNkX0KNX1I70bmq1SA5uGJll0Sxroo9udONWiYjaKhl6DPyhMC4zYHGFX+tMDptQTar17 vMMAm45xyKGqh6OBszycDUhrg40cL9nPQPbgqsOYpwD/NUB1ZSpl+Pemk0EcK1E2LEH5Fpc1S9h TDbJ X-Received: by 2002:a17:90b:1d10:b0:390:b41a:b92f with SMTP id 98e67ed59e1d1-390b41acf77mr3051923a91.18.1786098591764; Fri, 07 Aug 2026 03:29:51 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-390b1389e1fsm1133614a91.0.2026.08.07.03.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 03:29:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 1/2] spi: mtk-nor: Propagate errors from optional IRQ lookup Date: Fri, 7 Aug 2026 17:29:30 +0700 Message-ID: <20260807102932.45785-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no IRQ is available, while other errors should be propagated. Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing probe without the IRQ. Signed-off-by: bui duc phuc --- drivers/spi/spi-mtk-nor.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c index 74f34537b02c..6b9a5d728549 100644 --- a/drivers/spi/spi-mtk-nor.c +++ b/drivers/spi/spi-mtk-nor.c @@ -895,6 +895,10 @@ static int mtk_nor_probe(struct platform_device *pdev) irq = platform_get_irq_optional(pdev, 0); if (irq < 0) { + if (irq != -ENXIO) { + ret = irq; + goto err_disable_clk; + } dev_warn(sp->dev, "IRQ not available."); } else { ret = devm_request_irq(sp->dev, irq, mtk_nor_irq_handler, 0, @@ -928,6 +932,7 @@ static int mtk_nor_probe(struct platform_device *pdev) pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); +err_disable_clk: mtk_nor_disable_clk(sp); return ret; -- 2.43.0