From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC84947045C for ; Fri, 7 Aug 2026 10:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786098600; cv=none; b=gnh4dBO4XUfn/KaTa6H931c2BrvNHMQ07Qg30SfBgOXs2YzNkCxO+cqedZ1hVhNCD2fas8SQ6kzFrcjJo65zhMx+b17LPwH1TGTifkm1a5Pl6RUIYZzXuYgcwKdFiRFAWKUUUUtGgqquMdFh2mrfYkv2vA+gSYrvO4ROEDVgNjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786098600; c=relaxed/simple; bh=njcYR6m1kVS2NgkNl2yY8aEZfR25fem6Vj0aYE8NnBg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SnSiChtnNYT/uhJxfHtacwp3Vovdn0IDs18RTtjMLWcBplEVss8lv65ERJ5ogunbP8QLPr+9kw9vVHvUAExsfiX5PcDbp+HmRop7Fq7lV6uWo6A0p9ahzViZn3i5zeCfSAf1Y8f8HwgdXdIpgWWTG6znDH6O10p0c4vJqF0wmIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iyrV+Rti; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iyrV+Rti" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e88b60121so2666629a91.3 for ; Fri, 07 Aug 2026 03:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786098596; x=1786703396; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4E+mVEpkDh0k8bNZJNbHh0uHQtIkBEm4hCBHMggYxlM=; b=iyrV+RtiJPMOfa8R1jFISLHNpMEE4ePksPm7bgra16xIdePdMz2jyRTeAB5Z+wKcbG NxJ7Q+01Onr6cDlfSjnTvk2pXedB8o3S80yXsT0q+fRx/tkq3lpQhx839zlSMhtqcBUu 0Vu7cuLGiYUWOoOPndRC7EcZiB/mxQPl0ljQ69FnsvPaJpp0g1FWTjyY4Uwh+2bLWijY Lny4fyn9M8n+e5wqbDxSch0NniSe0UnFs+kuV8I7HI0JVx3ydFalFeh3SYlaXXIK0kX4 6p9csVi1ZQxpmOGGjyk1yITDnptTDNTCfTZSI81Svz+Wn0Rqhg41hGTTFol7rNKiZDv9 aWCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786098596; x=1786703396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4E+mVEpkDh0k8bNZJNbHh0uHQtIkBEm4hCBHMggYxlM=; b=Xy/kTFO/1yjt0V9mW97W+OpFusCmBs7ALwiyJ/po52jt4vHSGrHJtDpljecYczvPTf 7JKiUzBkv0vT1lbyncTEzmGh1sufsPKbhJynhjWmG/5DlETmDoWbjBEIDP7CBQX4SnZV ypf+coZtaTSgH8UhDhPJkOziPVXiG1ZlxrW8KsAwhSqnisKS73tjzehJTrlr5tNgGukp rjbFZsdMxLSVvXwUN97jNPsS9jHr90utp9RiaEPe62ppiErsRaZ+mtExKRXKisNDrMjQ uPGLmV8Wen8oScaa9Pulerr2DMoR5QifOGsVVgkXasdff++iiSHYivq//cSjmVN1s7mD V6BQ== X-Forwarded-Encrypted: i=1; AHgh+RqU9dupe2age61OFuuDT1q1pjttiepd4/oXXrBKRO84vhwpNk6b904QIObd4bAtPIfJvCIftEMDisRvgFU=@vger.kernel.org X-Gm-Message-State: AOJu0YxQRw6pav1LMJ5OmgSnFrB8ZaBUZwf+OPorPVI+99VhN/aLFEsU smjZB/sfc0nHbCAYDntPa/ybbBGxstVZ3fcoSZHO4vU52Lo8j7Po/xjp X-Gm-Gg: AR+sD131w5TOX50iMYPwjS2R1s6Fskh0WaMC5Go0lwmW8zj5cgSSZaJFnGpKOU85Oo/ bkXjc/NbQyfH7kH4DVqDuWnlByksZv9HJAesjcuTdWE4HPtPKnJ8Y0LO6GQA++c73shFo36GG52 JLZBiUEa42/RpzVWEDc9QlyqjvhtgHuow9trJfLyt9X+g8jIh6tA8d2+z/+0dWIEv/yiRf0RJcm wDoAiANk8tnYWPDbDqmdzEqVCnWk1fri3sSBBZmL9yDxwzHZclU0jXsIyL6jWJKDkoVUdlukJiR yGdXe4bwMeGY+eCmaF/N15fSR8gu971870Wqo2UAltwC2rvc70kGckXU7XPEmjsaUwpKiawvk7a mizhV/6E87/E4iRJVPkJW/zkni/1/kwKguJWin5G47ZDic1Os9f2gBq/8r4xJexAk6luEvGFhrJ JNENqfc/uWxYBuR2vC26ge0CGawYIqTq0cb97i7jozFohB+ek98dA5SER4CJ4RcrEwWeQJdv9LU HXKKa+2/zTfBEJsRyDa3vyFEHvqwngucg1TrXnqh4foNlWsSW2Zx8JGqjKj8EtL2XRrjZNXXqHi xNJN X-Received: by 2002:a17:90b:57c3:b0:38e:bfe:81e9 with SMTP id 98e67ed59e1d1-3903c5589e0mr24025142a91.1.1786098596171; Fri, 07 Aug 2026 03:29:56 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-390b1389e1fsm1133614a91.0.2026.08.07.03.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 03:29:55 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH 2/2] spi: mtk-nor: Propagate errors from IRQ request Date: Fri, 7 Aug 2026 17:29:31 +0700 Message-ID: <20260807102932.45785-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260807102932.45785-1-phucduc.bui@gmail.com> References: <20260807102932.45785-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Treat a failure from devm_request_irq() as a probe error instead of continuing without an IRQ after only reporting a warning. Return the error through the existing error path to ensure the driver does not continue with an unsuccessfully requested IRQ. Signed-off-by: bui duc phuc --- drivers/spi/spi-mtk-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c index 6b9a5d728549..c1e15246120f 100644 --- a/drivers/spi/spi-mtk-nor.c +++ b/drivers/spi/spi-mtk-nor.c @@ -905,6 +905,7 @@ static int mtk_nor_probe(struct platform_device *pdev) pdev->name, sp); if (ret < 0) { dev_warn(sp->dev, "failed to request IRQ."); + goto err_disable_clk; } else { init_completion(&sp->op_done); sp->has_irq = true; -- 2.43.0