The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: Usama Arif <usama.arif@linux.dev>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	brauner@kernel.org, hannes@cmpxchg.org, shakeel.butt@linux.dev,
	jlayton@kernel.org, boris@bur.io, riel@surriel.com,
	kernel-team@meta.com
Subject: Re: [PATCH] squashfs: avoid thundering-herd cache wakeups
Date: Fri, 7 Aug 2026 11:58:44 -0700	[thread overview]
Message-ID: <20260807115844.d4eca51ea2b6ddfdcd7dc25c@linux-foundation.org> (raw)
In-Reply-To: <7d92d30a-c92e-451b-907e-74c91562d4ae@squashfs.org.uk>

On Fri, 7 Aug 2026 17:01:30 +0100 Phillip Lougher <phillip@squashfs.org.uk> wrote:

> 
> 
> Hi Usama,
> 
> Sashiko (the new patch reviewing AI) failed to apply and review your patch.
> 
> See https://sashiko.dev/#/patchset/20260724190556.1950693-1-usama.arif%40linux.dev
> 
> I have been dealing with this issue all week because Sashiko also rejected my
> patch sent this week.
> 
> https://sashiko.dev/#/patchset/20260805175900.600140-1-phillip%40squashfs.org.uk
> 
> After quite a bit of investigation, it appears the problem is Sashiko is applying
> the patches against the squashfs-next-git URL listed in the MAINTAINERS file.
> 
> Unfortunately that squashfs-next.git tree is unused and twelve years out of date
> (last updated 2014).
> 
> See
> 
> https://lore.kernel.org/all/267938f6-8212-4ddc-9055-452f9d166010@squashfs.org.uk/
> 
> and
> 
> https://lore.kernel.org/all/anUi3bkwfM8teo_R@debarbos-thinkpadt14gen5.rmtusma.csb/
> 
> 
> But as it stands your patch and mine are going nowhere because Andrew won't
> pull any patch that has not passed Sashiko.
> 
> See
> 
> https://lwn.net/Articles/1064830/

Geeze, that's very overstated.

If Sashiko can't review a thing then that's annoying because sometimes
it finds bugs.  If it does review a thing and claims to find
significant issues then I want to see the developer or maintainer
explain why things are OK.

If you the maintainer want the patchset merged in this situation then I
have no problem with that.

> 
> I'm going to resend my patch with a base-commit: tag to see if it makes
> a difference to Sashiko.

That would be interesting.

  parent reply	other threads:[~2026-08-07 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 19:05 [PATCH] squashfs: avoid thundering-herd cache wakeups Usama Arif
2026-08-03 10:16 ` Usama Arif
2026-08-03 11:39   ` David Laight
2026-08-03 13:05     ` Usama Arif
2026-08-03 14:43   ` Phillip Lougher
2026-08-03 16:35     ` Usama Arif
2026-08-07 16:01 ` Phillip Lougher
2026-08-07 18:43   ` Usama Arif
2026-08-07 18:58   ` Andrew Morton [this message]
2026-08-07 20:11     ` Usama Arif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807115844.d4eca51ea2b6ddfdcd7dc25c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=boris@bur.io \
    --cc=brauner@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jlayton@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@squashfs.org.uk \
    --cc=riel@surriel.com \
    --cc=shakeel.butt@linux.dev \
    --cc=usama.arif@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox