From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0F43DD86A for ; Fri, 7 Aug 2026 10:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786099067; cv=none; b=JDxVwsGXIHlA71fGnkXltUGJNSvBZaRSNYLphQlTqHZuFxcquX5C/szIwQtBDZKoAMvtpPH7dWZmWLLisZK7+KTSbaYnMvNG+njbFwHxVEklihDW5g00uww3q7abp//9zx/JBh9bnGSu7RKwcKu0q/M9ZGlIdjwwSc/IKJi56wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786099067; c=relaxed/simple; bh=0osyU0Eei1ghBAIeDh53nND29cJLCbKBrbgTAnuTeZs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JsR9aV6s/PN0Q0GegKEsijLMfsBjJoRTnstraCNexccA7cipJFGUHPT5/WGtkionxcZQVy7tIGLvfUENV0k43D9w4tsuP5Ub1V4xjw0uHpA8E4z9SR6TgESX5jf89wSTJtZwx6YRVsF8k6XdUCS5wtMQDp34S4u2I4Blt4skC1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dscQSS4t; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dscQSS4t" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954afac04bso35952315e9.0 for ; Fri, 07 Aug 2026 03:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786099064; x=1786703864; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ReqVE0zF5sYuPuVqJdocfOpxaTR0IUKRNwoPkTUY/3g=; b=dscQSS4tN3YjZ2V8x0t7ge5iVxsTO1/QUY+dCTqK1jz5364hJ86gzz9Jn8LiL6KTPd /AEHrpej+crBblA5cBF4aiv6dTu17AD7VC50isg8rB7hpsMZvVHR+J+SxFh5E808vz1o /DRrTpFgRHF1RBNlQQ+KIxMVqu9HMqDXniR3ewIX5Vqg79iLF27lzZbXZ4CCn8OqxqMQ R9YVCI8C07oNzOoxLLspHWcqsLPiDTX21NwepbrtJCrJonfUAJScPh/fgVZT1i9TaiAr niweGuvzBk+YdhjChC/3cKSWsFjnq8moTR6ANYWgVuHIEy5iE2sVJpPm+sX7wXOHR1E3 DX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786099064; x=1786703864; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ReqVE0zF5sYuPuVqJdocfOpxaTR0IUKRNwoPkTUY/3g=; b=UxOzdb9BJtvYTQHvxSvemgDcoqzK9kRwooERRLPvG3/RboLefXnmfQ0UJ5SyJ3z1Qm pHrffS0F+x/DguI4jzLFhjXzrEy/xmiPbYkpnX6Mcac9b/e6j0C90JDHOIXQiPXonZ8s HfMQ3lApx/oRN8bitKasLKD1t2bo40sMM5nKB7MI/XKwk3JSoRbMC/x7R6UDjYitzaGu a/2NPZRx7MmQJx7RFuyBay0zhnKb9yDaKqYwMpjK/jDMfJmgLGc8TxjoMyTyi79GfzU9 JfKr70+3Khs+Jr4t+FiRbFiYa1jtioMBOnjWnbHURwnVAmulwxibz4wIhkTKAzJ4oWmw xOjg== X-Forwarded-Encrypted: i=1; AHgh+RoSGG2h37RWy0e5GAgqPD8lVqvq5RHRoQo762DCOf4aZbCgo7Em86IJj8NxHgN2vwkGBUa4agk8UKzBZOE=@vger.kernel.org X-Gm-Message-State: AOJu0YygDVmQUhKno7rMApHcBwoNowB08YsxG4KqrzwPNdBjHQUysrcG 31dsBigdtPCNADur+syBDu8thYTuIoMbrXvVlU9eX+7mDOmL+Dehgdbi X-Gm-Gg: AR+sD117T6lxiEgSMTiWWyc3EHRR2cE1ys6g3mq1zGGT6DijzbQQZPfhIk1lcDeKroN TphoJNWwMH+jryIj/JAu5VdVT/TNZbmZvn4KxTJ1R77J0Q2RhEgsLCtlYFvpFJ9reERVGDDNX2E UC7ZsLhtzcu5OCVLhSQOC+Y8MqBWYCxanAEKzEueR6GqgHX7nOZTroc2s1xFqQc6KqpPRHtFDLR l/RcDivbQ8l8TatP17w0Bq2fiORw4HG9daihyqg/K0Ya3hrj3v7JdP7Cl5719evMDatT5jFM0VG E/Z1AbQRJrdEEzj8w9NHS/WfTBChTFJXZxOqqfY85K9SYScsICA8d22r0tR31Hx0I6jfnL0CMDt pIf0W51+pLtOwPv4yNdKK/oGli9DlJ3kUqv4XkBulLup6fyS45zDf0HWdAR+6uo03P+MPB4pVC3 Jo2T6Cmu2SH0Hl+zSjWTKFLCmGBntd+JbHX35tQBmUZneFVGP8+/TguNAYaXNlwir8bkHvP63DA FQxk2QmPIDmzVLXWgQYjUQY9Y0pAU/HF8gD3CzlBRT+2pfNPKWdvDf6hmr30ATZumSI9yQFiLV7 tMfftTuze7E4+n2/yTaebOrURV3ZXbnd9BH1N9IhvGfQuDMjBzhdGkZyUOOctpJLdQeg+YLy9UQ Hv5scRMuxYRID4swKhFM2dP4xnJeUdi58EXf4WeDWib/AseBN0wYefJD3JemJZNFkce32vj0= X-Received: by 2002:a05:600c:1f86:b0:499:52ab:a50c with SMTP id 5b1f17b1804b1-49952aba5b3mr174593855e9.1.1786099063373; Fri, 07 Aug 2026 03:37:43 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995421934asm143535625e9.5.2026.08.07.03.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 03:37:43 -0700 (PDT) Date: Fri, 7 Aug 2026 12:37:42 +0200 From: Joshua Crofts To: Antoniu Miclaus Cc: Nuno =?ISO-8859-1?Q?S=E1?= , Michael Hennerich , Jonathan Cameron , David Lechner , , , Subject: Re: [PATCH 1/3] iio: adc: ade9000: request interrupts after powering the device Message-ID: <20260807123742.00006d8e@gmail.com> In-Reply-To: <20260807085643.5502-2-antoniu.miclaus@analog.com> References: <20260807085643.5502-1-antoniu.miclaus@analog.com> <20260807085643.5502-2-antoniu.miclaus@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 7 Aug 2026 11:56:41 +0300 Antoniu Miclaus wrote: > The IRQ handlers do SPI register accesses, but the interrupts were > requested before the vdd regulator was enabled. An interrupt arriving > while the chip is unpowered runs a handler against a dead chip, causing > SPI errors or garbage reads. > > Request the interrupts after enabling the regulator. This keeps irq1 > registered before ade9000_reset(), which waits on it, and lets devm free > the interrupts before the regulator is disabled. > > Fixes: 81de7b4619fc ("iio: adc: add ade9000 support") > Signed-off-by: Antoniu Miclaus > --- LGTM. Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts