From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC9747A87B for ; Fri, 7 Aug 2026 13:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786107903; cv=none; b=Y238C/JRQ3grL2qEQPWs9bBIjSVHaklKZETUtPaIb3L1GaK9iAg2STbzd+A/KozU1cCyVrlmP0aa5J5LYb+Eh39IGbGygwBRoko4k0DxD5Q/IQik6rrdg/6447wFwiarCOmJZWBvmmErXjAG3txjardaKd5EkNi7ztD1g6iFYK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786107903; c=relaxed/simple; bh=bK4iOFcZcF53f18rKhMIm1JIF5CClimXFXC6aWjBKYM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FXN3P4xcI5gibIuCiSKz0gaYb2nVe3THpyMTXXqd1oAovDNKhpxwsy17Wgbheioo17K4PGeVAmdUDvY9iLRif0KPhdia5eQglVeJJiRWYdbeEXDG8Ho/03VTjay+XLyZTVI7x3IjwabPMJ/PzV4xSrPrNWjp/ny24knJC9jX0iY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+nAZbxb; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+nAZbxb" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47fe89fb333so2071956f8f.3 for ; Fri, 07 Aug 2026 06:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786107897; x=1786712697; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xlJrxjql3aaRTEFrOM8XlIdZQrfl76PpNhcigTUBoHY=; b=m+nAZbxbvurn54axd1QtUKelUKUOJAuOAHGBDCZyExVbv4bHD9EdgR11UdwSKJM4Y7 ely0YcS2o5Iot2Wk1USA2f2AAMnbEBKyGTDdt9W65TufRMD20JmKWk5mj7xv8tGItu1w ezLrIrXN3exLqU780w8KoCGWRfwdsUdI5M2Ls8RNcfpgXqBAI5voC8DJ7lHd6pbUuX8W jiVIaTNw1YsaQ1brayC6C0PPTj9CpQ4JdqtQHXGIrkUZ8ieTZ5IIveNyAkuqc7df3UzT s6I3Y1zdFCzmKvSbC53Or5DbtI0ZnJ9I671KWiC/73SniOXa0HkLPaH3xKP2UYh5rQ3C rMfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786107897; x=1786712697; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xlJrxjql3aaRTEFrOM8XlIdZQrfl76PpNhcigTUBoHY=; b=snF/ZLRMbkG3adJmc9EYkU1ISq2tst17/mHkyPZ5jYTpxv8N3rahlGrAyS5tNEB6Hw gGJVM7KJRzVyncgT/fxdFv8HOFMv/f0renbh9+z7hrFuClkk1sPt9hLLkYTEq7MMC5AQ IdfTZyBB7uUw5j0d9mhNQtl8YkuVxEusiU+PVPkcV+BkemSgTfrBGeIbsW1Qb6bFdMv0 jEvgGgV0dLlwI7keuESxll+D4LjGkDTGAdP9k/na/45sugsVUIQTzH/1yo+JqgaUbnNj /f+Mwg5vO76LIWfwvExiLCdWjI6T9QFpT3F7LWipvH8tPf5nZ47vpa4ytrihjrGHbx2G w1jQ== X-Forwarded-Encrypted: i=1; AHgh+RrKshSQPmg3k1m1/YIAoKfbRrjgh7U6UcJKb47h8fCZ47+RM1QM5lPTK1ZehlfSp0mzIzMSZRO+y2vLGrI=@vger.kernel.org X-Gm-Message-State: AOJu0YyUxJZfDPPyNyJOwYllJot+rDPlzmWCgWZfzkX7bXmGR7/sQxy+ qpTpbHFJI4UlOCWxPGCxzZwY6dQ4IcUEC5/b1iq4boCrXpZVD+4OTboO X-Gm-Gg: AR+sD13pUpT7F9VsX+EHW8Xyobe5G9BE9e2gCGadbevt804sJam2jlMSTNlsGUYhLrc cBCSijfxxjohyRhnV7KP5xpXAkx7wkhvTuJlWlQ3CZX26FEUcxmgCk0oV5nyYS/08yeVmAGDgjW G1EqyWm6v3FrOqeb0LainiV1S7HTBW3ihP9GwJLfAl90PcQx1n36T3ratCq5/nFUBdnTLXEOEnq tpw/xB+c/MtFa/49FOkAhUp1PCoshyXE8M1T/45RcPr3bc9Ya4WJDY0ETsrnSDExcmlkfK8f463 Kt229tYAEV3itKOd0k3+RiTcBjUyC+uXDdPJxQrTxeh9xASvioJlBKbcsfUc4WHVLa1jP7HMHVN ZOpzkmle8Jl9ib3e12onuaeaRvyCiFcMnw73wSY9sWoSPzZuqnFq8SGXZ3ft4OG8SKaE3IzHyhW fmFnUGJKtgf+xgCfHsvN7oA0VeCPUjRvSh2L/MlSM3TOnIU+JQ0lYbm56zcjtnExETXLRDxNTwn VbyXsI0B6nSo54I07vEtL677w== X-Received: by 2002:a5d:59c4:0:b0:47f:4919:d5b2 with SMTP id ffacd0b85a97d-47fec4e887dmr34364488f8f.1.1786107896575; Fri, 07 Aug 2026 06:04:56 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002145589sm6261890f8f.1.2026.08.07.06.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 06:04:56 -0700 (PDT) Date: Fri, 7 Aug 2026 14:04:54 +0100 From: David Laight To: Takashi Iwai Cc: Mahad Ibrahim , Takashi Iwai , Jaroslav Kysela , Kees Cook , Andy Shevchenko , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] ALSA: remove remaining strlcat() users under sound/ Message-ID: <20260807140454.1014cf33@pumpkin> In-Reply-To: <87jyq2azz4.wl-tiwai@suse.de> References: <20260807114139.1661-1-mahad.ibrahim.dev@gmail.com> <87jyq2azz4.wl-tiwai@suse.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 07 Aug 2026 14:15:27 +0200 Takashi Iwai wrote: > On Fri, 07 Aug 2026 13:41:32 +0200, > Mahad Ibrahim wrote: > > > > strlcat() is deprecated and slated for removal once its remaining > > users are converted. This series converts the sound/ users outside > > of ASoC. > > > > Each site is converted to an explicit offset plus a bounded copy: > > strscpy() where the appended text has no format specifiers, and > > scnprintf() where it does or where the resulting length is needed. > > > > After this series the only remaining strlcat() user under sound/ is > > sound/soc/codecs/wm_adsp_fw_find_test.c, which goes via ASoC. > > > > Build-tested with allmodconfig and boot-tested on x86_64. > > > > The generated strings were checked against the pre-patch code in a > > userspace harness for empty, whitespace-padded, exact-fit and > > oversized inputs, and came out identical. No audio hardware was > > available here, so the drivers themselves have not been exercised at > > runtime. > > > > Mahad Ibrahim (7): > > ALSA: ump: replace strlcat() with strscpy() > > ALSA: ac97: replace strlcat() with scnprintf() > > ALSA: cmipci: replace strlcat() with strscpy() > > ALSA: caiaq: replace strlcat() with strscpy() > > ALSA: usb-audio: replace strlcat() with append_ctl_name() > > ALSA: hiface: replace strlcat() with scnprintf() > > ALSA: usb-audio: replace strlcat() in longname construction > > Honestly speaking, I'm against those conversions. > Why do we have to open-code at each place with strlen()+strscpy()? > It's just harder to read than strlcat(), even more error-prone. > > If an alternative is something like this, we really should reconsider. Agreed. Changing the code to not need strcat() is one thing, repeatedly implementing a different version is silly. Even using seq_buf isn't always ideal. David > > > thanks, > > Takashi >