From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43211381C4 for ; Fri, 7 Aug 2026 17:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786124989; cv=none; b=fvHH9QUp+pqw03HeBLSFheF25Yqydo1ebYqyVu2jC9REe7HAn87YS9uOOcNvnpc6tn1iDkhbbhVXt/2G39eNFZuRz7nTpvpR89QaoXOLUDHEFrWZnG57twJzgdMM6DpV3STLfUO0YANKBYmbUeDmotpM8dAOJ72+yMzA0GSNsiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786124989; c=relaxed/simple; bh=G5FBgj16nZysOiQjcK1g/WyazSPfmm37GtIqCKUfMfA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D0dHWaml3RlhpsnmRH/NSpwwJIsB8ufkm12OdRMjMjvsEg4lR/195ZPr7VuDjnPRovPDouqmfxaNwpnBOc29gX/5EjuR1cElnssHl6csYIVc1UfjsL8HBU2SWOX75JWpa0RiTp9LuYYkAXGFagb/M7yYnDN8oRwzkA8KbKW6FfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=k6PtEbrm; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="k6PtEbrm" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-92e50979c71so366086085a.3 for ; Fri, 07 Aug 2026 10:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786124987; x=1786729787; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2Tql1JgJaquc9mfRiFvaWAIFcB/Q6f+0xzjfO2Ezyik=; b=k6PtEbrm6W2KP8nwN6sdutGje426z669Mv7o7TNfy9inVlMBIdOsUVAodFmwQsHUgx 49qETeIlPkHCwzwkUXLxVG9i4ewt3Nm3NcZ5UVQ6C+lDkQ6j64Pez1b9oRZ2Xo0PIgDL r+CglEIjeGOixBA7VKpV657YmFPs+9AyXngj0pdyTHS4aqnYPMLLKCZQfFWKw30SaLHj 2O1GhRV5QsjF63jKuETMDnafO+LF+q8JD5anwVyee8kiv8kd1FFCPOIl+6+RUkJ2AgON 1uKSm6Ce1bWBC+GY3uaOsDjNbyIr2JeOkLtU52Zk0gsYYbftTjOlf3Zx/n8a6i/gIfBV pVfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786124987; x=1786729787; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2Tql1JgJaquc9mfRiFvaWAIFcB/Q6f+0xzjfO2Ezyik=; b=EGPU1vC/mif4oM59jQUQUAEuRlbH07ivdLLZDtlD0ACEVCxhb1BXPyaxBPEVlr3hnc 7qBmSnYftoPtf+q0dhHL92QGX8gsm0fVAS+3Nv6/RzNjz60Exg+/9FB3Xu5dNI4LiRC+ RcqLuXdZNIR3wPZ9cQhipSRi3I5I7ZEClfNjzgwVEL7YtxBI5Q1eHdFAlB1Rc7Iyz8SW w/zi2acb9S5X5NB3WqZJJkc9I4Z8EcqezElDgMG5oWLL+QKcXi0DojQWoEk+0L3JSVNB IJtvDFJZbaab7JAXEwA/Alqf1he1kExc+JieE0q7jncVsjHUxMN72A3MQJCh8MVwe+sH PN0A== X-Forwarded-Encrypted: i=1; AHgh+Rr1lhLbNb3JWMzIMfsQ6jVsJeG3Vm+o0Qdx0t852n+geQmbVOB6wD2DYLliU6B+u7OQO0t3rctc/v4ji+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyV+LoQT8oyqWjuU70ZeKHCT5j7LzL+z+LGMU3Gy9hdGKm9Afeh 3lek8//03Vzeqxk32kfBorB+3tS0hUrAyG0VQoIquqeaABp2JOGStHVIPWlUX6OZ3vY= X-Gm-Gg: AR+sD12I9t3HgVAYQlqaWvQamkdZmcd6V8UbzyR7LOVDr5YaoKiwhqrTZPuRcfLGJrN 3xAEX2A/PgbhWK209GI7RMrTkJS/csynSHjgpF2lx7yhXdqDFt3HiAlBteLcSfJgy2PLAnG53H3 SYc1piwHEkjgp0hEv4dEH3roQE/wRcdbtgPA0HhsT5AEAspADJT7KifMhZDFivvSfcJrsA+nD27 WOv1IG2B/jQfI8SshtwsBbPMhaJCcLccmS78dW3LCb3s5M1JGn6+yuMi+a3GXM+mml1yvjgHfGa 6m+EgQPCZjKJSVbZumOsaC9W6TAKFVvqMMnF80cDs2Q40Wx1pWKPt5gcAyZSMBix85Ir8EinkqV qBOdS0VGCVkgQ8BGcwc7xCld19gFwL6ln6x9rUnYLbzs6alVVoLkjgFv20KiAv56pL6PZwRJp9R bDZWFbsxU5YaC57yTcU2Y/1+RZ/CHWXb2R7TbcJQ== X-Received: by 2002:a05:620a:1987:b0:923:8612:f15 with SMTP id af79cd13be357-936490b3f5amr2240192285a.18.1786124987127; Fri, 07 Aug 2026 10:49:47 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366dc51b43sm202043585a.0.2026.08.07.10.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 10:49:46 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wsOhV-00000001Asf-3w09; Fri, 07 Aug 2026 14:49:45 -0300 Date: Fri, 7 Aug 2026 14:49:45 -0300 From: Jason Gunthorpe To: Pavan Chebbi Cc: michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, jic23@kernel.org, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v6 fwctl 0/2] fwctl/bnxt: DMA buffer support for HWRM commands Message-ID: <20260807174945.GG200537@ziepe.ca> References: <20260807125846.45570-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807125846.45570-1-pavan.chebbi@broadcom.com> On Fri, Aug 07, 2026 at 06:28:44PM +0530, Pavan Chebbi wrote: > Several HWRM (HardWare Resource Manager) commands used for diagnostics, > firmware management, and NVM access carry one or more DMA address fields > in their input structures. Until now these commands could not be issued > through the fwctl interface because the driver had no mechanism to safely > broker the host-side DMA buffers on userspace's behalf. > > This series adds that mechanism in three steps. > > In patch #1, the fwctl core UAPI adds a new driver_data field in struct > fwctl_rpc. Drivers that need a driver_data payload receive the value and > are free to interpret it. Drivers that do not define one will reject any > non-zero value with -EOPNOTSUPP. Existing mlx5 and pds fwctl drivers are > updated accordingly. > > In patch #2, the bnxt HSI header is updated to add the missing struct > definitions for the HWRM commands that the bnxt fwctl driver will support. > > In patch #3, the bnxt fwctl driver consumes driver_data as a pointer to > a new bnxt UAPI struct fwctl_bnxt_driver_data, which describes indirect > DMA buffers. > Pavan Chebbi (2): > bnxt_en: Update bnxt firmware spec > fwctl/bnxt: add DMA buffer support for HWRM commands > > drivers/fwctl/bnxt/main.c | 396 +++++++++++++++++++++++++- > include/linux/bnxt/hsi.h | 585 ++++++++++++++++++++++++++++++++++++++ > include/uapi/fwctl/bnxt.h | 4 + > 3 files changed, 980 insertions(+), 5 deletions(-) Applied to for-next thanks Jason