From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CDE039B94F for ; Fri, 7 Aug 2026 19:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; cv=none; b=JFSDpYXb2rdT5T4bK71+5o3LStY9rgt05ewD73/7N5K2NTOMd49i8LUo24DiZrdIlkmzU+EjYEaSrXS8iMZHs+OTgHNxhl+alqlRdMNJKnrPflzInmE6Qpva55oK3TSaQnhMvc/rtSpy1KJll++16ZaW5KCPmp68dua269zgQo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786131668; c=relaxed/simple; bh=6MU93lD7oPCvVgWA1NeStXtYPktufCBo3mj6HDbyAGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=emeVyerz5mopM7DjqJCX1Bqf8bJJu48w7R2PdEaO5Ezw6PRXT/ftTTt3n2ycQdw0gMceMjlWZv0UhrUpMpMM3kDRU3MCpcEYMScw+faqD45q7G6exi/GzTk7+JqSGaTQXFQyUQQDaVtQ+oJUW+PBj9QZyPauQDfDYZ71/ns0dDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=wUNpIoqs; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="wUNpIoqs" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-92ed19f4d60so158646785a.0 for ; Fri, 07 Aug 2026 12:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786131665; x=1786736465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y08cvUPAERT8DtacgubgZYXObs4Ve5NXsThRcrzdsK4=; b=wUNpIoqsqglIHJWespfQvDI+wIzIueSma7+g7/CuYQcYlcbJCgQgH/upekBdu2pR5Z yT5FShjL2dbUziGTtDPjB9rC5JEGyiBDAhZrAfsb6Yi+vZUktlynnW3wcXJlRRKkITmQ Fv4x5AvdvFd9bq2ChPlU0ct0st17xUyNmdd/gkYIQdiAAONKlTL+PAHGr53Rvg6h5AwE fniFjAvZ4V/M39C/QfRXNy0S3FoLN9ZzdiTaJDfMcykm2uakjqREYAGnF/NtGseExAVu HImC/D13CuRTGRDC1w4ISttWy9kJ1s9GL8/98TH05tBbXeyRFKrM/ie1Fuj87P/nVSyS 70HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786131665; x=1786736465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=y08cvUPAERT8DtacgubgZYXObs4Ve5NXsThRcrzdsK4=; b=e5T7rERRP5JZfrS4Rkf/ICCsKCB/2u/Dra0YtpoPKDAS3IMycPgV1NC2JIUj/vNghB q5jH2P4fZYQkuOPNJrS8l8Qxm5BW8eoBaPDHMWoIwcfOYUFZa53L7IJ72cGChFtLR6Zy kWHXQpSJjShz1BBbDRf0wwVBunKkcsyXGA1SVeFrKnZv6GVF7fT2uXfLWJOclhB4Q1pY NtAzEyOivZ3q/NCO/Excb+mLupC1FnZBjPHz/+gNjM+sVUZMfmqIyj6x8J37xJs43XVY PMONAedB1jDmjBKyb17SfyA9wmgDKQ8batbpyyhe5mkHbcQAE1yYLkKh3DJe7BoZXeNK Z07Q== X-Forwarded-Encrypted: i=1; AHgh+RoaNOLVbVVjhf7WW/5213ieEePFIZjd/028dPrMB0fmlUMlW6gBM7dPzJzwk8Ckc3uiOiKYVVqk6BEm/S0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPA0ou4nZFu0fpOAci3IcdXsOFVMdF3irOrv3ONrL+oVCauEAN I56pfR/nuFN0ip/wGB3RvWtaXrNDRrCRwcHYy7RcXTxl8HY4ppx5wW66yQDTXBePxFA= X-Gm-Gg: AR+sD10IwfbrlhEleV6/qvIPaOgiQskJ0zYA6Ca35plGfw3OnkUJbvNeXZVLBPuheAb F0ClzI60w64WLm0KlydBihGSZzEGio9fxackCS8O3wgw7Du2s6wlj9OtkhxKARIENgl5jITe83x vHLVSYLHJGDkm6rx+femRQM6eienw/EJfzCbmX65HR+cG7fbik/l848R5UV2OI9Gc54jiWW6ryP 27PK45KG8rPEZdJ5vZmFYtPYiBx4kX5tVtDNewTInqo6HIlkqz6zwWlLee/4WC/wrzH+sQdm0Z1 VxUpkfK+wA6LJw7B6d2FihsFjIqGFOc1/DjcdBNcHi+F6Su7pLobi43p5C3HLZEN7KdvpW6Sp3l +a9SCKJaagrsQtASsCcXAW6e66QCZPMOo3JxmjbrY5jHYjzA24Tv3R1zLgSbACcD74B3BjgyqfC /7rSFcrHj7zQUNIXIcc5RclYw9wp6O86kbiiotWiQQoqZn7ya+ifx4ySxDBOWJvtJy X-Received: by 2002:a05:620a:400f:b0:918:7e9e:de74 with SMTP id af79cd13be357-9367b699973mr103767585a.17.1786131665023; Fri, 07 Aug 2026 12:41:05 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9366e03aeadsm219786585a.3.2026.08.07.12.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:41:04 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina Subject: [PATCH 1/4] PCI: of: drop the reg_num argument to of_pci_set_address() Date: Fri, 7 Aug 2026 14:40:55 -0500 Message-ID: <20260807194100.455599-2-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807194100.455599-1-elder@riscstar.com> References: <20260807194100.455599-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The reg_num argument passed to of_pci_set_address() is always zero, so get rid of it. Reviewed-by: Herve Codina Signed-off-by: Alex Elder --- drivers/pci/of_property.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c index 75a358f73e694..505226b876c56 100644 --- a/drivers/pci/of_property.c +++ b/drivers/pci/of_property.c @@ -52,7 +52,7 @@ enum of_pci_prop_compatible { }; static void of_pci_set_address(struct pci_dev *pdev, u32 *prop, u64 addr, - u32 reg_num, u32 flags, bool reloc) + u32 flags, bool reloc) { if (pdev) { prop[0] = FIELD_PREP(OF_PCI_ADDR_FIELD_BUS, pdev->bus->number) | @@ -61,7 +61,7 @@ static void of_pci_set_address(struct pci_dev *pdev, u32 *prop, u64 addr, } else prop[0] = 0; - prop[0] |= flags | reg_num; + prop[0] |= flags; if (!reloc) { prop[0] |= OF_PCI_ADDR_FIELD_NONRELOC; prop[1] = upper_32_bits(addr); @@ -131,7 +131,7 @@ static int of_pci_prop_ranges(struct pci_dev *pdev, struct of_changeset *ocs, continue; val64 = pci_bus_address(pdev, &res[j] - pdev->resource); - of_pci_set_address(pdev, rp[i].parent_addr, val64, 0, flags, + of_pci_set_address(pdev, rp[i].parent_addr, val64, flags, false); if (pci_is_bridge(pdev)) { memcpy(rp[i].child_addr, rp[i].parent_addr, @@ -164,7 +164,7 @@ static int of_pci_prop_reg(struct pci_dev *pdev, struct of_changeset *ocs, struct of_pci_addr_pair reg = { 0 }; /* configuration space */ - of_pci_set_address(pdev, reg.phys_addr, 0, 0, 0, true); + of_pci_set_address(pdev, reg.phys_addr, 0, 0, true); return of_changeset_add_prop_u32_array(ocs, np, "reg", (u32 *)®, sizeof(reg) / sizeof(u32)); @@ -458,7 +458,7 @@ static int of_pci_host_bridge_prop_ranges(struct pci_host_bridge *bridge, /* PCI bus address */ val64 = res->start; of_pci_set_address(NULL, &ranges[ranges_sz], - val64 - window->offset, 0, flags, false); + val64 - window->offset, flags, false); ranges_sz += OF_PCI_ADDRESS_CELLS; /* Host bus address */ -- 2.53.0