From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F52B32C92A for ; Fri, 7 Aug 2026 19:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786132185; cv=none; b=TqqkjDgSz07zVHsfTB8Pq8uM69nOKvmPJWe37oPogSazGLMJgWD2u1Uq9xSJUJUi9qa+GqzIXm6ph3FinFtHSuMYSsMHPwFkStj2wRy9eCt+1FQtwGz7IrGJY18Z9JYMUISBn1vI+aYBBIV0lnRRj4VkpjFp1TAx2DjDhwT/3BY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786132185; c=relaxed/simple; bh=cDE7rA8aqN5e7rQ7XoHZoyTnsUGAF4oK9A5CKhOIVkE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dTK1uwgRkE7YyR1bu45DsyEL8vFpSgVFDlt64KXO54Q862w05FGfqfHFRLjy0QJgTEguFTZCAgfIDWsltRISb+P0k3/KRKS/6T1ECr2XYPDYAuAk5GuKMa/guwT7ZFXcUd6JyncEc4AIlEH1ZuH9bnHatFglWeQuFf3rHMC1lN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dOqnr1Oj; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dOqnr1Oj" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cad8076b01so46084025ad.2 for ; Fri, 07 Aug 2026 12:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786132184; x=1786736984; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Pjt4VBNA9RhvwHOG/dB1GY/jBYqoDr2m2fvZn74cx+Y=; b=dOqnr1Oj5pkhzSzIY4CJlicnS54FZQYGA7yXX40fSdGtXIieNcX1CTg6NLP+s2Mqcn U8ZuSf1OTy7FZ/93AijVG8V9wtaDH9dTQ4QRkvh+aQfBURRQmsavp7aps+3AYWwKyhX2 6mScQnFn0bWs/FW/ZjaA8TEVt4Vbmb3ZuCtGgUo/xtjH0t3FvxuHpp6Gty/Jg52JZx9z qktbcRrzueFYKiT/QtDtkMgewVtZ7Me0RCUqmk5HGqX+ZDfajkL+ixkxyerSNIOfdLvc /bQxcsz3LZLIXkfZ76y4U+hWOtdDZ04MoDRD729IVfk7yAtfsOYBDAkow2J9rEfxCxX9 QIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786132184; x=1786736984; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pjt4VBNA9RhvwHOG/dB1GY/jBYqoDr2m2fvZn74cx+Y=; b=EGII0RwbV3H5WQbaHmB5qinoFbxfLUSrHZ+JHxmSKTaKeJquKJFnpi4Vbg3ZnY9oND rcviGp1sDaAOW6OEMVVt0sECt1Xzy8m/CJ7nZdWS7xAhWzDOZ5TTX0+0YMe9TTAsEHeJ 2e+aotZF97QJ8SjTBFjz+KeG6U09csL+7vlBQbf3epzI+isbo4DWtbFfXQoaqqICH21C sgXEePbyBp+pziv8uFYhkteEJ2xMMt5gAqriiIcs6lWRgsrUZOem5GFwxKHu6Vj2JJNm 6FZfpQrjd5YWzdbD9pqG2APJc5bcXbSb28mlXNKmZ69UEKcSvvrZqsBJ1k2rc58jqkbI JS9g== X-Forwarded-Encrypted: i=1; AHgh+Rr8YX+JdorOONYSBnL7461Gl41L1CAslpxJ9RUp8Zu0Wj9fzpXTBE+Yr5HGDHuqFe0G7cvhvB4QWOY2OXc=@vger.kernel.org X-Gm-Message-State: AOJu0YyPvXKNczagS0w4i+iP/9fmDn77Q5pRlj5lzVcHBqwtmreggkCB oojDz+W5KmFuvSPJuVTVE+wO9zzetbvefIcf1IkF20F3pSsrThDT9Y3L X-Gm-Gg: AR+sD10vuoqnhtPNzHXwDjUnFUpGNrjrliU2XTjqHgckMb2s7Bq83ipXoHj/LPcZQD/ e+Bshsk2OcnAOjSpXOJ82j5l78dNRI6vSKZxbOPeBADRLNqmwbLsSl7Cm3IHoX23yo5YAa/DSG/ V5+NHI7Fp7QTDJa+wAniWAZB2OmHO4k4CbjDL+EQPxghwYpQXcPH+ubnuD/f3Yufi9eyIh6sA+S I1PT1GfgNjR4yUePZ8b9q1ma3qUu2nsowHXMxrHf8Mr5U8ThsOnze9MrUdsVWcrygnPouAHMGzU VCiDjNaRzJj0xOCW793A2h8/T6V5iYah58dcWINZ0RIwr0N/BwaF23R3DA1ql3C7Fgp0ueVFgSE eHkz56VwlF3J7giYO3qCXIU6QbFWrWUpsQS+1FjJolG8ngjSh76Z+WKEaWCkRi3qG25GqLtz8+y qFmm/CmMU/bujJW2V0wEE4S6VIvc2r16tsHfa2evhE6RQ2qt2oZbG68KtGzIBOUx0hYcz9yLxJk Q6T4JQPefZpVTFKviY3pdlUJpYGWbqLuaNwjrGEz2yFY5Gy3gQoVw== X-Received: by 2002:a05:6a21:6e0c:b0:3bf:c223:4640 with SMTP id adf61e73a8af0-3cb85f4e199mr32087435637.32.1786132183828; Fri, 07 Aug 2026 12:49:43 -0700 (PDT) Received: from ubuntu-openwrt.tail1b3f25.ts.net ([123.201.0.80]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14101b7b39bsm9527458c88.14.2026.08.07.12.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 12:49:43 -0700 (PDT) From: Sandeep Sondagar To: netdev@vger.kernel.org Cc: linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, Sandeep Sondagar Subject: [PATCH net] net: phylink: treat PSGMII as an inband capable interface Date: Sat, 8 Aug 2026 01:19:37 +0530 Message-ID: <20260807194937.785825-1-sandeepsondagar@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PSGMII (the Qualcomm 5-port SGMII) conveys the link negotiation result from the PHY back to the MAC through per-channel inband SGMII words, exactly like SGMII and QSGMII. However, PHY_INTERFACE_MODE_PSGMII is missing from phylink_get_inband_type(), so phylink reports INBAND_NONE for it and phylink_pcs_neg_mode() falls back to PHYLINK_PCS_NEG_NONE. The PCS is then programmed in force mode and its control-register speed bits (which default to 1000base) are used, so a slower copper link - e.g. 100base-T - is reported as 1Gbps and cannot pass traffic. Classify PSGMII alongside SGMII and QSGMII as INBAND_CISCO_SGMII so the PCS negotiates inband and the resolved link speed comes from the PHY inband word. Signed-off-by: Sandeep Sondagar --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 18d2ead97aa5..983a1a3cee37 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1040,6 +1040,7 @@ static enum inband_type phylink_get_inband_type(phy_interface_t interface) { switch (interface) { case PHY_INTERFACE_MODE_SGMII: + case PHY_INTERFACE_MODE_PSGMII: case PHY_INTERFACE_MODE_QSGMII: case PHY_INTERFACE_MODE_QUSGMII: case PHY_INTERFACE_MODE_USXGMII: -- 2.43.0