From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C524E36195B for ; Fri, 7 Aug 2026 20:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786135556; cv=none; b=i9GbEQ5KGqd0DCGSWP47Bamx202NUVAg9P7+OJcBv202l6zZQgHBrirBJ6pGTDwTL+DnehzT0VWPMY437ju7lTlHgbMLcF7ZuBU5409JDzaGIqE0r/yjQc7aQ0/QfcBhyaCMhMoS7Jj1AtGbIqMT2rlBr/XFU0f0O3j97gymtAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786135556; c=relaxed/simple; bh=dWQgP8bzaAIwTMVkx8IpTIFsIRYN6uYeqp8LsGt3ch4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uDoVksgwuvuEKJ5MzaDeMYZfPL+7RGnTHmEP8tqVj0PCuxejiZgIhwqV2m+xFDQbhafilMwwUP9+FLWyfa4NqwGOo1FSsN+OjsofPP/tRG9yyIlFjObFtf9ieZeUDxgKJBfqpu4gMX2h3H0u/olp+9nWynLuxnT+Czr0E6QdeL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lcvHFLIQ; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lcvHFLIQ" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8f1a8e914a9so30282036d6.1 for ; Fri, 07 Aug 2026 13:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786135553; x=1786740353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Q7/TzG19dQMDabhaRtUh/yPQ9FO/UIWoBDpgtREKn1g=; b=lcvHFLIQPSb2hrYpkdf8Jw0ELrS1HFi3KqcKIg4R6FH41PN3r8qXj59GLCnnDmdVdc 20prM8ZvYt4sfbsHFtKFI3t8tRn/PHcGwOW/U71ACwp9qf47C4cZzET5iklAgaxMAxZA 1u/F8hcp66TDbZbQaxZhAhsf0rkwSqYx6HaaheYxZXqqOSjT0qhXBoCeMMOCLom1fmxC RSwFQe15l8z4kJ9lTcAJCv9MrhBbA6pVhF8I+PwJfasQEmdCpRsjCJcgMdbScYcTP1qi DRJuLrPSPlnzw350KMBO5a12WoWLqPzrDv3EzcKAZkgvfIlYO3b3JbVMKPpifKiELwiv heVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786135553; x=1786740353; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Q7/TzG19dQMDabhaRtUh/yPQ9FO/UIWoBDpgtREKn1g=; b=aadRP0Pslsho5T63VwMN1yVRJObRQfHAHkNuGJRbU5yVG6dRbTT4wKFYhcDLtuJ16d jThAmrnnC6MrgTRfUzst8DsWChQgE3xHAKyShLVwMcGtbQp/nU52ebcRyuSspftVNorO VJhTBgFI73BH6eIK3syn7mLlyk9tG7MC9aIUa+csOWOy+ClIhMBsPPBzwCJ6uPHsbTi9 aruJtT9/ZKN3G7aFgfu4MJjDyOdl/8glDndna18cvEhv+uMJEUzDmS4hmTVY/DkhXGcf BAlj+RFPMLa+sFNvIRnLy9ZNcrx96Ew5J81Z8zX26AocSRpngI0ZJQzjQss1tFtGF9pn RP0w== X-Forwarded-Encrypted: i=1; AHgh+RqD3l8oloYaqabPREymnNQhX87dO2lRPi6NbtWhL1kHxKtDHLLsMxGg0+hSPFtBb/dHIoSWBj+J6IzqqTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyCjkDSX47aP9A8PQgqSSqmYPBTOE7oRcFYW3LDOQFGeh6ujv+e 8jIPJFjCV9wrPWMREJJctdAkB/bolpdNE5GKGl47kIxIE2bR5BIpjNcN X-Gm-Gg: AR+sD11EbH1csBcYxyukS7ncWNeYFRjXNkul55Kr7YoGNTMNOC8ZMJtWbfanWBr3YFv GNmcqyWA2qkHByEszFrIvjXc1WguMgY9jSmKMwBlWLB2YLOOPlayzEZ5LvE9A7+sygD1QITSPOm 6tH/n+6PRzvZW5NRkqj3lxngsq4cKyPNl1bNugFWx8Y4vKuGeJljlx8FDEzE7aCtmDR1uoy8t1O iNbQJ4IZwYjFNFtPG19YOI9pAkv2tH4538YKwzFpwKkl75ZSIlKQyZHSBME6hmsMI0rKBqaIAFb cw17oMLJQ+3jYW48Rob/vV+ExxKF+z5tVyfnSJzhogiJ7Ts90gQoidlOX5Eq1Xx2rg7ybK9Dgd1 ApzcrodyC1Egkj6bezK9uNRnTFO6ba2cYAYIMvr8dW1y5j/ST5G+GiFgHtn5wycXEkNx2Olntca fKt5j8JqVTa0o7RPhhwi6BEbrCTe0zNwHcOC7PhPG30svsuZ/H1nyI6LRxiQM2KcTF0C3D+IeAU +baO9JDmd8xg93D2xfTfRRR+3vUp1v+gRJVYkJ7b1wDqLsUWm9rhcLT/tlkFnO/P56YuJNTiQ== X-Received: by 2002:a05:6214:f2e:b0:8a0:d08c:a720 with SMTP id 6a1803df08f44-90a34675d70mr38903586d6.17.1786135553553; Fri, 07 Aug 2026 13:45:53 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908a918ecbesm16865366d6.9.2026.08.07.13.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 13:45:52 -0700 (PDT) From: Yuho Choi To: richard@nod.at Cc: chengzhihao1@huawei.com, miquel.raynal@bootlin.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] mtd: ubi: Release device reference on busy detach Date: Fri, 7 Aug 2026 16:45:50 -0400 Message-ID: <20260807204550.1016755-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ubi_detach_mtd_dev() obtains a device reference through ubi_get_device() before checking whether the UBI device is busy. The busy return path drops ubi->ref_count but leaves the device reference held, so the device object cannot be released after a later detach. Drop the device reference before returning -EBUSY. Fixes: 7e84c961b2eb ("mtd: ubi: introduce pre-removal notification for UBI volumes") Signed-off-by: Yuho Choi --- drivers/mtd/ubi/build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 674ad87809df..ee6ce4471b25 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1105,6 +1105,7 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway) ubi->ref_count -= 1; if (ubi->ref_count) { if (!anyway) { + put_device(&ubi->dev); spin_unlock(&ubi_devices_lock); return -EBUSY; } -- 2.43.0