Re: [PATCH RESEND 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller

[Rob Herring <robh@kernel.org>]

On Sat, Jul 25, 2026 at 12:51:12AM -0400, Cody Kang wrote:
> Both K3 instances are the same IP and share one compatible; which one
> behaves as eDP is decided by what its downstream port is wired to, not by
> which register window it sits in, so the binding does not distinguish them.
> 
> Signed-off-by: Cody Kang <codykang.hk@gmail.com>
> ---
>  .../display/spacemit/spacemit,k3-inno-dp.yaml      | 140 +++++++++++++++++++++
>  1 file changed, 140 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml
> new file mode 100644
> index 000000000000..865ea310daaf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml
> @@ -0,0 +1,140 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/spacemit/spacemit,k3-inno-dp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SpacemiT K3 Innosilicon DisplayPort / embedded DisplayPort Controller
> +
> +maintainers:
> +  - Cody Kang <codykang.hk@gmail.com>
> +
> +description:
> +  Innosilicon DisplayPort transmit controller integrated in the SpacemiT K3
> +  SoC. The K3 has two instances of the same block sharing one compatible;
> +  each acts as embedded or external DisplayPort depending on whether its
> +  output port drives a panel or a connector.
> +
> +properties:
> +  compatible:
> +    const: spacemit,k3-inno-dp
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description: Link and hot-plug events.
> +
> +  clocks:
> +    items:
> +      - description: Pixel clock for the controller.
> +      - description:
> +          Pixel clock generated by the DP PHY PLL; the pixel clock above is
> +          parented onto it in use.
> +
> +  clock-names:
> +    items:
> +      - const: pxclk
> +      - const: pll
> +
> +  resets:
> +    maxItems: 1
> +    description: Controller-wide reset signal.
> +
> +  phys:
> +    maxItems: 1
> +    description: Phandle to the K3 Innosilicon DP PHY.
> +
> +  phy-names:
> +    items:
> +      - const: dp
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Video input from the DPU.
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Output to the panel or to the DisplayPort connector.
> +
> +    required:
> +      - port@0

Shouldn't port@1 be required too?

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Rob