From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EBD2313527 for ; Sat, 8 Aug 2026 06:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786171040; cv=none; b=ogI16ldkUuzCJv+mSduFfPJiWnhoODuGEWnWXZpHYU7Ir5j6ViEZHATMy50xF93adJV4p+5TYFasOw3L5hAEGZnfds58jznzpc17Ht99R55zZ/peBIvR5CWi40odGvl/l3EYJH9Td22556Y6dCNodKkn/4MEmIM+FdSgCrTpCP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786171040; c=relaxed/simple; bh=3ebgjBAUsHDL5aSLBAEDQetZe1n1aC6xwo33fb9arHY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r7uNr7E37kCUoOlnNwwpNjr7CtjTLzFRaiEHu2T5t9p1rYgDHw1v/0YDal0S7D64RwHCQqfpQ3pz9h0yrHdAg9PGVOIa+WJyB71HkG8abAoMj7YPLC+1/5kK05+G4dCNccAiwa8gEzkvUbUtPRUR5KWFAoHDqjkKNecmksGrFpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O8Gy6oOG; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O8Gy6oOG" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so194818a91.0 for ; Fri, 07 Aug 2026 23:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786171039; x=1786775839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Q983uYDsq4Xe9yOLC9LdYCCWYqVj2QLw2dxzgl89ls8=; b=O8Gy6oOGgY1SHFJWgAB7Pgoup9HuUKPdg/W/0Nf00/+iBsnhKWxFobbEIcuXD5pppX HfNSbYBV8OzGXleqnXfQFExLCW9eeYhfQG0B2zd3mKasTIaP3zBL/4OqIUPCRpkvAPGF knUtgdMWUvE49IxtID8lKemm50dlSEOiPRqZ2b93vvrlIFO9DEdJ0MLi5sYciH2vStGN aRuvB4L/n6rN7USzWognpo9ey0Dt+IfOGOqwW6RK2xfLtD1MtIw4mQb9SISYtNPSbPDH CZtwf+qtjZCn/aszvd3RQoPIGyhACbJaUROBDjrb7q1JozfcvKZKiXToSv0GVaTlXJFs 2BWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786171039; x=1786775839; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Q983uYDsq4Xe9yOLC9LdYCCWYqVj2QLw2dxzgl89ls8=; b=fIU4s6MsuRWdqlzFe52/TkMlUHS0aXHG8f/E8oCGk85RjJI2B32do3O0dAt17teRxD TConmZ4CiCRBvv94zLjP5SOp9crAdYTp1UC8fnrkyayELHmjeO3v/fWhFKiGMqUO4gFL ZhYFxuy86b+ts005GdulYE5V1/g00i1ee/YjBJemtEMipsraFZZr50cdD3ORDIhCIKLi 1fcwPyVVmjSfXg1jfbWhIQkCrFuP29inmz6E66BoPqhdvKibKxdfOmTFY2uKIQMYjTzX h4Ui7rM00fXCni+06/tpaugIfbulEavdTJbJ72upzqE6t8ZRjY+2Z+0BL0A/9b1cUAPg sZWg== X-Forwarded-Encrypted: i=1; AHgh+RoPqqul4lUpMCTUr56AzYTZkKNkha6uyn+76GWBsr4VtHUf4BKSr5LRvOsiBeTX7ecjEoTcREiPzqN6RCA=@vger.kernel.org X-Gm-Message-State: AOJu0YzfPiTYravGDLqJDQr/i0l+opfJzcPTv13hTCLSEAqYilJKy0l2 IqCgTmJ2I2aZA2GO8i9EUhon13N4cLyN9ngeL7jPm37adE4zU4gu9RDB X-Gm-Gg: AR+sD113lynW3CMH/SJcVg0znxNkBooxrmdin6a11kCD2+OCoo1q+x+kDqnaPBCOPK+ udbwXXKTp9yXCnmQiXNV8bxe53omoXMsZq2o/Zdo3A7YUCWO+kum4eJt/BzQXkARW1hqq6OMZmH HAyu5KlIBIFxJZsV72Vw3fV1vzGVnYvVBN1VB7K+O4tZF91jqSnCHCy9EkT0uLJU444weCbT/Fh D+4Qew460/NnYRoc3SjdBLJBhJSzaqWG2GpF+FUkD7ibVfQYZP77GDzxS6NKyxInCCgjsVCWjuV ofTpZMTSr9iRjZa86Li9Xzb0SjH7m+/H7sGm7Q5YLocfc0RRNYp3SKNhbr3rlEiOq5ALsM4BK5d l9snKzxCNlAMLC1wxhW33t3Hfo/3ZL4hFwsWWpcrVmAAhR9YX52Z3P4bh5hg/5Rphn6jv915+2X DkqvPSJDaAIgdglM1Qc55+nANw7XhlqJK0EZQxeUD8djk= X-Received: by 2002:a17:90b:3b4a:b0:38f:23d6:b4ad with SMTP id 98e67ed59e1d1-3909d8172edmr13381640a91.8.1786171038869; Fri, 07 Aug 2026 23:37:18 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95c40sm5015659a91.8.2026.08.07.23.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 23:37:18 -0700 (PDT) From: Guangshuo Li To: Olivia Mackall , Herbert Xu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Guangshuo Li , Takashi Sakamoto , Bjorn Helgaas , Danilo Krummrich , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] hwrng: atmel: fix usage_count leak when autosuspend_delay is negative Date: Sat, 8 Aug 2026 14:34:58 +0800 Message-ID: <20260808063458.2609136-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit atmel_trng_probe() calls pm_runtime_use_autosuspend(), but neither the probe failure path nor atmel_trng_remove() calls the matching pm_runtime_dont_use_autosuspend() before disabling runtime PM. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. Add the missing pm_runtime_dont_use_autosuspend() calls to both the probe failure and remove paths before disabling runtime PM. This issue was found by manual code inspection. Fixes: c4f51eab6ce0 ("hwrng: atmel - add runtime pm support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/char/hw_random/atmel-rng.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c index 4ebbc44fecf0..6265d9a8d140 100644 --- a/drivers/char/hw_random/atmel-rng.c +++ b/drivers/char/hw_random/atmel-rng.c @@ -150,6 +150,7 @@ static int atmel_trng_probe(struct platform_device *pdev) ret = devm_hwrng_register(&pdev->dev, &trng->rng); if (ret) { + pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); #ifndef CONFIG_PM @@ -165,6 +166,7 @@ static void atmel_trng_remove(struct platform_device *pdev) struct atmel_trng *trng = platform_get_drvdata(pdev); atmel_trng_cleanup(trng); + pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); } -- 2.43.0