From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3F03A3E68 for ; Sat, 8 Aug 2026 08:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786176693; cv=none; b=dZV8Q93JTDoLH3J0SNKFwVzRLyJRKpwbI+gMCm0pxgpw4DqhKaJjxnYNDyiHtn7bRjQXLlmp99eNoVPBVzbmDgJh+nvN6TMesPBdNck49X/WqdkER1iIOuR21fY3yWCRBi5pXsxf0ojqVGU4t7iGsqBkITFVdDvfeX9uzfgPC/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786176693; c=relaxed/simple; bh=MGb5suHwKenoO8+Yoit0TZ1mClXS7TepI3s00xmuOag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PeK9WoT6JHYR1hy3FX4Ck5wxpR559zuG8u1GgE3kw6Tp1IvHgoSeNf+dK0rDPI5ugOIlEilcQoJXEy4LReiQA1LapiRCMrD8+3A52yVeM+shUQjzirutT5wkC/zym6u6E1UQ3jq62IYqX9QsRzgRSYYD67uUSbjGnlY4SU/001Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZITh+bIa; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZITh+bIa" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so245742a91.2 for ; Sat, 08 Aug 2026 01:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786176692; x=1786781492; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F9dVgwGHiDFCuZ0x2p4Z0K2PT+mB10F3qNo0u+NxB+U=; b=ZITh+bIajm7bYWL/DiNPGuZ6oWti+Aeoagi7E6GE4vCcaGjfD4jZ7xT1ET7vVGhcsq msHlaZ1nycChIHwiMUX3OCIDB/abgpAhcLgwX/cXxptfhsQ6tae5aWSuGRaaBqqfGy/i Y2i/48oCIko3JSzYpCZ2yGoA2XtwzPcMpouu7RFwpX+Z+UTjJPet2ioIIXsdCcQ5NTOl eMKM1ivHEcWZ57qSJzU1Ex5WOtJKS11rTOmDYaWFdMxD0KZXOIccmafIYGdiSo53Zaji A4LKpwS3R67akJ6EfQQHVMsrD5Snx0w8JPXYEAAA/QaQfV4UrcUtAzFGnknxcfztQ2a4 jwCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786176692; x=1786781492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F9dVgwGHiDFCuZ0x2p4Z0K2PT+mB10F3qNo0u+NxB+U=; b=aBl+Bj+LZviv98505V8uEGOjtwnHj6E1iHpOJGvJaurmlVW/HwTKEucTvCyOQu/tsC D+z5Od1zgvwb3+nouJ20HkC+DOlRPTwfM6yGmpMkAXfZ95R8H4JLfBf6UG1RfRst3xCr yPpdw7xAL9yzCCu87CEz9YTaqyzhxvUFmgGysaRKvUtPam1l+qmouOG5CshFVWo/4YC1 Bp1SO4To2i6p/AfOZPUBQYTZtgn+2Zw6G3XVHlYkDiFQOLV7UvwvD1hrRetU/TcOlp6V mEurdSAi7w70hHW4ld9VYeiNHEHufXGb1smd0FYsLC0SnOgEopEpulA9Xjk9VgV0EMPr tf1w== X-Forwarded-Encrypted: i=1; AHgh+Rqt9hEOvvL60kB78SNKTipu3WDFM2/wxYmDpyk1ISVT4IIaOjTBpubHX+0YKqnKInVPZvzA+3rtE526x5c=@vger.kernel.org X-Gm-Message-State: AOJu0YztNFEZMiHFNlL3ZNF8gdl2tcQU227tUoPx+bpomOEmIBjP5Ncj C4QZH2rd2B0PbFc5EHzT4omBl1ic+HE9RXMCZtchJzdo/05CUIWk3Rrr X-Gm-Gg: AR+sD10dlncdj1qiBvJkdEbQRRwvq9sVBGZlE9t9Ypd52oAMUtH0ErXKI4ceESmuph0 GBtlaxtd9GRfChvwFCyb744PXP2y+5gCFm/QN7new1EaSNH6SwWrNcrK1ZooLxXDPMpqYy6wU19 nWUDFcfiqcLXTxhAU8/fIikmyopp7FpJWcEaMlUKZoM+V+YN6FPO3qslNBbtBHpRwPNqLt8fUug uzLsdQCQGqtAdzibuoHR/jqjSEWKkG2WcjIb9RDpIwc6wRelI57u7DXxtOBUp7bI1xApBQIkZ/T npwCQuzWwilN6bip1ElcyJRJbptt4RiNT54fEsGWZft1eKYBEIU5reNiBO+eC0rxNDNnnSuun1D XNumevKOzo4r0T6dyhaFiWUaBLYzmd3aJBc830oD06f4UObzM8/MGaLtF6wYaGBteLEzTsEXR11 /Nq/QIKL2yMvYSUKqzwUufndtg3bjKXVPpqqjbgPm4HAnPWJ5JjxHcNfXgvYXiufMT2B/PSbsfM hcHQZAIKhr8 X-Received: by 2002:a17:90b:258f:b0:38e:c232:9d3f with SMTP id 98e67ed59e1d1-39282247ee9mr6250045a91.5.1786176692047; Sat, 08 Aug 2026 01:11:32 -0700 (PDT) Received: from 10-86-27-207.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141019b41d9sm13660310c88.5.2026.08.08.01.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 01:11:31 -0700 (PDT) From: Gokul K To: Sean Christopherson , Paolo Bonzini Cc: Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] KVM: selftests: Free the VM when NX hugepage disabling is denied Date: Sat, 8 Aug 2026 13:40:50 +0530 Message-ID: <20260808081050.408657-3-gokul02k@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260808081050.408657-1-gokul02k@gmail.com> References: <20260808081050.408657-1-gokul02k@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit run_test() returns as soon as it has confirmed that disabling NX huge pages fails with -EPERM, without freeing the VM created a few lines earlier. This is not an obscure path. nx_huge_pages_test.sh runs the test a second time without CAP_SYS_BOOT for any non-root user, and main() calls run_test() with disable_nx_huge_pages=true on its second invocation, so an ordinary run of the wrapper script always takes it. Free the VM before returning. Fixes: b774da3f2e57 ("KVM: selftests: Test disabling NX hugepages on a VM") Signed-off-by: Gokul K --- tools/testing/selftests/kvm/x86/nx_huge_pages_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/x86/nx_huge_pages_test.c b/tools/testing/selftests/kvm/x86/nx_huge_pages_test.c index 70950067b989..49b70c05daec 100644 --- a/tools/testing/selftests/kvm/x86/nx_huge_pages_test.c +++ b/tools/testing/selftests/kvm/x86/nx_huge_pages_test.c @@ -120,6 +120,7 @@ void run_test(int reclaim_period_ms, bool disable_nx_huge_pages, } else { TEST_ASSERT(r == -1 && errno == EPERM, "This process should not have permission to disable NX huge pages"); + kvm_vm_free(vm); return; } } -- 2.54.0