From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C10783BA25F for ; Sat, 8 Aug 2026 09:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179671; cv=none; b=uSC93BYNaIWljhz5Mj9s9X+838v+L/BKMH/npoNNtQJ2CeSkxa/c0Xfr5Sw69IIq6CYUMiExXYXKUL8q4ciJPx1pfSlALxUcZR/o9mIkX055X4/8atir3ZU3d/m5jHCxfKDwU7CWMrZRuZhgk4Wq8G56tqFgIu3BkbGJ3JizDaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179671; c=relaxed/simple; bh=EHfaoi/H5aVDlNxnEr2yGng8APrb8ROD3VYBvv0JVis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tth4y+Q9RT6wWmr653DfKl1ZRszTHzGdzMBiqVpHBXAi/yzYlkwsOEdSDyWwckGNnH0Gl0o3oEKDnYYbzn9qt8GpP3CpP+wbqVlZxJnWvjjBkFZq6K55P/MrAxo5DlVpUjPzW0UOXB9s9hJdzZo51PCq3uKSavDYDKdPnIPumpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=POfxsR+o; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="POfxsR+o" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84f38f3b36eso196541b3a.1 for ; Sat, 08 Aug 2026 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786179668; x=1786784468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y0kd4BZdCcR2jnnA1HcZjBK3ddxINoAkrrsu0qcIwIE=; b=POfxsR+ocwgVUhaYW72DlLRGNjGsxhYuTbpfZ36s/t1LCGv5DY/cIkS+fiGipnvn38 7xYG4ztHYi5/4K+cIVGpWOq7Hzqxxbqb+s8tINUhwK3cdBiM4FfhR9+0TNf2/BQ4sG/U xy/cwQqGzz+scH/RvTRNVxoJu06nCHB72e6DUXW1WwBTuNshUi4KxY1sgvfe2Rv9d5Te kycK3yNzYU5czCLY/brqkVEiSzC5okNatT4EzH8rTee+uHV0C7zxcmoDDJvgLcmeVjXp aOJdV+LcqivtfZ004TmZ/ENoEUldDoeuevck1ehW6hRA1xVVqOISAvIeC9CGFJXEjBjm pvNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786179668; x=1786784468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=y0kd4BZdCcR2jnnA1HcZjBK3ddxINoAkrrsu0qcIwIE=; b=rgDsRZ2HZEVzNQxwlrpXc2dxit7sp4hv8LNFM5DssQwqXEqYXIfrC58rqvhwoBq2KT JWmgYGPKMn97wS7LWaR62Wm4ssfHGD88WU0ApMZx0ZyAlp7lWrNwrQI2/fnqfsKSiJNy 3owDBFbKgwOvNruncVqUhfakNpG5S8GBrNBCdYrJxP0n9H3JPLreB4zCaHncw859Ahch HXCyXnnqIrhzCdJB00aDg+gqwkuuD1fXNQ+7KwYZEE4Q8x/M76/dyaMKI6BU+0jqnM2+ ljsL/GeY0Xus25aNoVtc7LoMxK//0tR/1VXev8gEfClcQbvao43BwoJi9zzbFj8sj+ae ajTw== X-Forwarded-Encrypted: i=1; AHgh+RqSsxCSkJ8WoQWtvMkU2/l0UC9hhAlFBKJxRi1FyiGxnyHUAY+rO8Mk21LL0pzq4Vtk2w1QI3eUpW1bWIY=@vger.kernel.org X-Gm-Message-State: AOJu0YyhAe2KzBbukNlRAfudNK89+88f/79h7hjFRUMyX9k0FeF3vKa1 M/5qK1+Un5omxVlk+Gb4sM1TJvpEAc+G7dpVwbVKKE1H6RTanVga+9DB X-Gm-Gg: AR+sD121R1Pm7cNdnzj8aS+FS+G8PL9209pNjRt2SoKPbtYYx8PC+MOfTqEoZJeXtOD Iu0jwpBgahQhw1YykJ+u7cUuAlV2EaKyjsd0uA53b8i2OklOaCsOxH/KLcF8laidzVaNamOAoRY NWW6u9PKXYu5l491qKL7aAC0+H7ClWm2/iBf3+vX5blA2stuEJIhkMUoxWdqbk9jyda3Gp2CK7U YWA8kZwVzrMRfc5vlrYsst2hX5dlsAU0pErhnqyl0ifotBNC/WGarkr93kRlzfFz2hj0yNkigkh C9NypOa2rPcSDuBcMlaCZnzgQebh0b56n8EaF9/giVV8qWDjV3q5YjluTehhUZeV7YamkafLF96 CPqpTqFPTOLhPy1JRqpCClCB5yHvg7rv9+A0eekQ+YXr9k88i1Ny5p+sv2zGyVM85ctsvenpatk FMTJy82UnvJJd+rs6jk24My4UUjDlsmExntu4OIh9nKZsw/tltVonrY3QZe0qkdcL7t0QQXoy7/ PMwwmZDgS3+PcLb0Fe8w1VkFDsBwi/fQuG19eTM1GZH85nzrmMc17fip9Lbkg== X-Received: by 2002:a05:6a00:8d1:b0:845:ba94:a56 with SMTP id d2e1a72fcca58-84f4fd9f82amr15992649b3a.5.1786179668348; Sat, 08 Aug 2026 02:01:08 -0700 (PDT) Received: from debian13.localdomain (bb219-75-96-14.singnet.com.sg. [219.75.96.14]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a51e9f0sm1973871b3a.28.2026.08.08.02.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:01:07 -0700 (PDT) From: Adi Nata To: lorenzo@kernel.org, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev, Adi Nata Subject: [PATCH 3/5] iio: humidity: hts221: Allow unknown whoami for DT fallback Date: Sat, 8 Aug 2026 17:00:24 +0800 Message-ID: <20260808090026.34187-4-adinata.softwareengineer@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260808090026.34187-1-adinata.softwareengineer@gmail.com> References: <20260808090026.34187-1-adinata.softwareengineer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The WHOAMI check currently returns -ENODEV when the chip ID is not 0xbc. That rejects Device Tree fallback compatibles. Keep failing if the WHOAMI register cannot be read. On an unexpected ID, log it and continue so OF fallback matching can work. Use dev_err_probe() for the read-failure path. Signed-off-by: Adi Nata --- drivers/iio/humidity/hts221_core.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index 76a391f421f5..da773d2edc80 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -139,16 +139,13 @@ static int hts221_check_whoami(struct hts221_hw *hw) int err, data; err = regmap_read(hw->regmap, HTS221_REG_WHOAMI_ADDR, &data); - if (err < 0) { - dev_err(hw->dev, "failed to read whoami register\n"); - return err; - } + if (err < 0) + return dev_err_probe(hw->dev, err, + "failed to read whoami register\n"); - if (data != HTS221_REG_WHOAMI_VAL) { - dev_err(hw->dev, "wrong whoami {%02x vs %02x}\n", - data, HTS221_REG_WHOAMI_VAL); - return -ENODEV; - } + if (data != HTS221_REG_WHOAMI_VAL) + dev_info(hw->dev, + "unexpected whoami 0x%02x, continuing\n", data); return 0; } -- 2.47.3