From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78386255F28 for ; Sat, 8 Aug 2026 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786180057; cv=none; b=TlkLFtrSkO/dM8QwBQKLjgPtuSvxearx0wWKMpbrI3pLlqNeZwuxXmdnuAiuz02HdeP/DoZWklnyd7a7lJzygwyFzzgHK+q9L10xlLs+a2VaEvulufdj8BIbb0Kd0ON61i8e+hLHtUd6koondlCOaMtbvIhX5qCTZoy70rLkpA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786180057; c=relaxed/simple; bh=Q4bH563s2NsL3ss7t9ppxk7jVRhvXmNexJ39EpHAIHA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Wy+ZpTlk6w2nNgntGMdzq3ErkdEoxK+byTVE4O7c2pTS1sY6v3PivrQe/7V51HbL4G+CBLIY5C6R9nWWn7HSwW1uOb14D3XdnU8ttpO/kwQvnyt9Pc+olsbdhijWj6295O53YquxxAUzUgHWh26NfG+Xhvhdhwv88+aZuxpqeOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qP4qR6pK; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qP4qR6pK" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c9e0b89e228so108078a12.1 for ; Sat, 08 Aug 2026 02:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786180056; x=1786784856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Jy9EgSqEwjL4mooBq511tfnbI/n0KZNIWc5TmVL3Am4=; b=qP4qR6pKz3/ghr0LcDglCBaCtRub95KV7nfJYdlLhnRMFKvmitjZjQhn3MhroEgkk2 lxdBuJlrrrfFPD885R0VKWnEDkWWX9AagahtBha9W/LQNHhLqtf+hA8Uz5DxB0Pwn/K0 r21N/n5fen6OoJ5u8Wbz2KMBBAHjnxkIhpN2qVZZwJEc0nKF9GJDBSzNvuuq19agS20h IWuIFwZS/Xbevy3LUloFcbVmEJpD5Jo2oS3Yq5FIVhwTtcalBRlRuHnPDb8vVe7e4EtY 1MgeXGfCfZllFj2dTv62R0A1oGrA8XC/j3SP51volTQBQGxM/YXbZz+dNsN1QRaXfjAM fnGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786180056; x=1786784856; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Jy9EgSqEwjL4mooBq511tfnbI/n0KZNIWc5TmVL3Am4=; b=noVVUT+uHoGyHKcomLzh6WOiYYDQAx4wu4QJxeJCXNV7kSPLUFRvzQX3Bv3Yzys6Ms Vz4AioDnfPrFgiWHNxQQEATVXUqZOgNiBM/UTBxAXH+iEGDpP8jpflt4qwMOSVUnNdv2 VcFqUU9xa7Tj0cPVi0sQtgLcLwanGRjrdZ+iD7Rb1FMU08xPSY/Le0dggeBs/gN76tUH inr6y9tNNHNkoYEY8u54CB6VnuDBcyEE9cn5hOpG46YCS+zCh5gzmpAyzHJLtV/mg3Fp Sbe00t+Pp0QxHyaIJnL+rkSdXasLiDV+T0jLRTcsAZHlKt23fYNtV29Y55ECy8qE9aik AzpA== X-Forwarded-Encrypted: i=1; AHgh+RpGkfpkVonCd07EGzqI1uwOoq9xyH1KhhJaYswQ6fGR79Q81QMjcKHXd9zxTrR9V0qZHRP6f4UXUi94Czc=@vger.kernel.org X-Gm-Message-State: AOJu0YzwfkZ19uoRHlmOIXvjK6NrTkZH7fXszjAbuPOUAs0Zrffc5tm4 sqMcmFJfbd2X1YvjlXe2J8+xO0Negyn9WCRjJGvDYINn+xTnY4hJJy5c X-Gm-Gg: AR+sD13emyDs3gqhCpgwX3/WmJpHiDJqbqQ5wPFvTq9zuFRZKo/H+9q6+U77Y7x4Laf 7K+zR+C4PJ6XvC2NXREEu9v0JB9ftKYxe7k4Y7XlmEpVCRr+k8n6RG3nKmg359TE63yIIeqUfID DLSD0SG/ukEF24VNq/UYA0gphH1OcylMzzZ1zkFeHHuI/5B8m0c7OO/7j4VSS84ETwmYjeeYTML DBBggYRtC61E/Xy3S+XoWrtSGlUEw6ZMvWNDRCjLHWiiN+uR1ffDI+D7Fdhymve9TlpLaZvZEzY rmgi244zy5QhaWQ0udy3iElBVxm9zzKhX0cqvhCuplWmEUep/UP1ifBdR1Ek3RMup7SZUN8MXBc bbGgv4jeesngEzL9LK1agQtBfQB6JXHFg0tNnYQY5Wn/hY3+WfLmbdNC3gUBnhfysqifej3hhAo 4c/GQIv9vkQPw3ajJrOSlbylCDNL0SXjK6whxtvDYJMccgzpPlhDNjyRwdyuzjDru9SbI4u1eH8 gXYQP9AzS2/EVvB X-Received: by 2002:a05:6a20:7f89:b0:3bf:a489:1483 with SMTP id adf61e73a8af0-3cbce9b63fcmr6630086637.33.1786180055689; Sat, 08 Aug 2026 02:07:35 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86fc7bsm17077223eec.1.2026.08.08.02.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:07:35 -0700 (PDT) From: Cong Nguyen To: Eugen Hristev Cc: Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: microchip-csi2dc: fix async notifier leak on probe error path Date: Sat, 8 Aug 2026 16:07:29 +0700 Message-Id: <20260808090729.2680734-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit csi2dc_of_parse() ends up calling csi2dc_prepare_notifier(), which registers the V4L2 async notifier with v4l2_async_nf_register(). The probe error label csi2dc_probe_cleanup_notifier is reached after csi2dc_of_parse() has already succeeded (e.g. when media entity init, csi2dc_power() or v4l2_async_register_subdev() fail), but it calls only v4l2_async_nf_cleanup() and never v4l2_async_nf_unregister(). The notifier therefore stays chained in the global notifier_list while the enclosing struct csi2dc_device is freed, leading to list corruption and a use-after-free when the list is next walked. Unregister the notifier before cleaning it up on the error path, matching the teardown already done in csi2dc_remove(). Fixes: 2de0b3c0f678 ("media: atmel: introduce microchip csi2dc driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- drivers/media/platform/microchip/microchip-csi2dc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/microchip/microchip-csi2dc.c b/drivers/media/platform/microchip/microchip-csi2dc.c index 70303a0b6919..59574258ab2b 100644 --- a/drivers/media/platform/microchip/microchip-csi2dc.c +++ b/drivers/media/platform/microchip/microchip-csi2dc.c @@ -736,6 +736,7 @@ static int csi2dc_probe(struct platform_device *pdev) return 0; csi2dc_probe_cleanup_notifier: + v4l2_async_nf_unregister(&csi2dc->notifier); v4l2_async_nf_cleanup(&csi2dc->notifier); csi2dc_probe_cleanup_entity: media_entity_cleanup(&csi2dc->csi2dc_sd.entity); -- 2.25.1