From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD104052B3 for ; Sat, 8 Aug 2026 12:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786192803; cv=none; b=RJVj4VDTWHBCpp5k5qOO3/DApVGrfBtJCPoJMbqi4sEulloucwYoA0RjOgsF0YT2G+WKZQoDkQqoOEjJEIE8Oj/0jf1aTLBq9jWmvx282DvDgW33X82wwSwVS4pino+v+LK8Y84QayEGgkau4y6b8yyHhGoqGFttmf9N5rJL5dE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786192803; c=relaxed/simple; bh=uEjBplFNYuYrwpvxRgEJ9erS1y7O3vfl/0AJuauZOQs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XTLRO1nNHNQJQbGV6+vH1Mtq0MpFetZV4z8fvo1yB+kFPvwrX/HmtNbh/CP5MAmjShiWuj2cuyMlrb+c9C6wZRbF/FGsubxMt3eANqQTznVgVnHEbTVMV9ybVXJW5dNAl5Fyra4nNDyaQlla1CfsNwzc1BkNebtxYFWFF0lyTkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aNiH2XVh; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aNiH2XVh" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4957952e0f8so454505e9.2 for ; Sat, 08 Aug 2026 05:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786192788; x=1786797588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/7Z80X9FpgglIlhnFzOdLw8386r1jX4AyfOgEB2R9U4=; b=aNiH2XVhmncRsfa1Ifsj+o+qGdfYuLd2cGKz6jp4mZOxvENinTrjrnUSdgz8colhsG yM3xQYXV1AQODl/+6D5ZhAtf8KWBAqhMwFhQkeopxA1+jc5U0xR6Mf7LjTjw0uW6eXm0 sg+9SFNug4TKnoM6+0XhEuq/OxfMFTAmPGrTDD6NnDrH7EJaqvHWjzPOVjQALliXD09P J7JEaP/V2eaVXcYvxNIEbKU+vIMHHhZ7q/rqi7vGla7VWwnTQNqKIpGaKDvQVPka6QdZ pLuLDeOSSU2hZpJNHo90NcZu7luV8PPJDYiF4rzM9mx5zupm50+jUTPFegTcrwbMGFPu TRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786192788; x=1786797588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/7Z80X9FpgglIlhnFzOdLw8386r1jX4AyfOgEB2R9U4=; b=oI2pTOiOtGm9qoUyKp5jzdhPlK7BKwtccuGLlpmkVsvbumJclxNbNj1Or/Du2OWjeo v3sdPNPOn1TvG/GBuJKsj8YWLgDYru76YWWbvDV35Kt2iT1vy95rI06h7ABa05CrNqgS IsscbzbHDIuoFVJvGlV8Cbyp2s7+JB9x5kwRNGoG2lAsYBr1vz1/UQzYXEtyeMyrQMZa 34d1tWakErU+sJNkEfmhyfpBTCkcXGkTkj5fSEXzgjkWKTQ6/AYaPGSHvi6MFLhLoAsq YlUykW2hGlFKSz6zloR6k9xNymFE8IRqUIxwpOEY2HQIbaGMd9Nq0TKi9WToNW1Z7fJn 8UIg== X-Forwarded-Encrypted: i=1; AHgh+RpQvjT1ygZwilkO9QQ2deH9UE19gRVQDvl38ZfKLWVuVJfKYjI/Yu0JhHt17y8fClXfDC2zfF+6DY94qwg=@vger.kernel.org X-Gm-Message-State: AOJu0YxERaipw3sIly+Ha/ex4zZ0mGsXjC+t7ATQIPRA7LSk/uwAj2Cb sB6stEHvd63zCoK5JdA2n8NGNKU7PdkmZViSMN4c/50CVxd6YyQcaNQ6 X-Gm-Gg: AR+sD10ikm8yr9imLGToEWCFZHnRkrFeLDGToEQz7wJI2sNECbH0RDJPqbi6awKOHHo /AdxwceL+RVe40SxpdvezYuy2x5mzLvrk/zYeSV/YeOTZcH5W/NDXHwXg0AZvGHy93jjOyyOkje o6v1hilDxkEVvXpoDIjcXWVjwoZRkOyQHxJQaCncD61SZUjtRuWb9kTIdmThJ27HtX9H3tLOYim iG0RHhajFVQ/2vtdPjTTlKDHIoHg72mm1ng4ePkMz6cluWBFLy49WUB3rebPwyeftmXLtiH/k/c MgPIM96tZzFklrTyfjuIIwOM67vwZTPJXMbU6kLqLFSYPMNV7EPHFZl/7fl8q4ffvPLyqmIQzv0 SoHQrLc8dgzFimFhOviCYa5Sh0XtcM3HJ6lIoWA0SDHZx+a3I2Lq/oJdPUiSapMI7CeINk27IWx f/skVT84yGFtttRtGDv3VFlKE3x6K2WkT9Ai9pvq0LxpNiOEoZ2opCbaULFwBXY7wN0iyf3fr6a nNTSKjYZ9Q52h2mTQCzr68GwhrOmZjjyEIeh2JDScAsNqKuFXq/Am0eNyNcMumaN98OtA== X-Received: by 2002:a05:600c:4ecb:b0:499:59a1:96f7 with SMTP id 5b1f17b1804b1-49959a19770mr126652915e9.1.1786192787600; Sat, 08 Aug 2026 05:39:47 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B8E20009911270F4BEC2300.dsl.pool.telekom.hu. [2001:4c4e:1b8e:2000:9911:270f:4bec:2300]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995ea2e038sm115426525e9.14.2026.08.08.05.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 05:39:47 -0700 (PDT) From: Igor Paunovic To: Jiaxing Hu Cc: Igor Paunovic , Robin Murphy , Diederik de Haas , Tomeu Vizoso , Heiko Stuebner , Alexey Charkov , Chaoyi Chen , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v6 7/9] accel/rocket: add RK3576 NPU (RKNN) support Date: Sat, 8 Aug 2026 14:39:24 +0200 Message-ID: <20260808123926.23903-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260807211629.1573228-1-gahing@gahingwoo.com> References: <20260807211629.1573228-1-gahing@gahingwoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Jiaxing, No need to apologise - you found it, and you found it properly. Diffing an ordered trace of every register write against the vendor driver on the same board is the right tool for exactly this class of problem, and a 12 bit versus 16 bit field in a header derived from another SoC is not something a reviewer was going to catch by reading. I had gone through v6 with the RK3588 side in mind and had a list of comments on the poll path in 7/9. Most of it goes away with the polling, so I will not spend your time on it. One item outlives it, because it is not part of the poll machinery. In rocket_core_init(), the new multi-power-domain attach returns without unwinding rocket_job_init(): > + if (core->soc->multi_power_domain) { > + struct dev_pm_domain_list *pd_list; > + > + err = devm_pm_domain_attach_list(dev, NULL, &pd_list); > + if (err < 0) > + return dev_err_probe(dev, err, > + "failed to attach NPU power domains\n"); > + } The path immediately above it shows what is missing: rocket_job_init()'s own failure path puts the iommu_group reference back before returning. If the attach fails here, the scheduler, the ordered workqueue and that iommu_group reference all stay behind. Since RK3576 still needs the attach in v7, I expect the same shape to survive the rewrite. Smaller, and it may disappear anyway now that you are splitting 6/9: the commit message says nothing changes for RK3588, but struct rocket_core's clks[] grows from 4 to 6 there while the two extra names only arrive in 7/9. Either a line in the message or moving the growth to the patch that uses it. For v7 on my side: once the poll is gone, the only change my hardware executes is the job_lock move, which you are taking out of the series anyway. I am happy to run the series on all three cores here - probe, multi-task jobs, all cores in parallel, a forced timeout and reset, and runtime-PM cycling checked against a bit-exact oracle - and report what I see. I would rather send you results than a tag that covers less than it looks like it does. Igor