From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8309F3C9890 for ; Sun, 9 Aug 2026 15:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287735; cv=none; b=RCvOoS3XfA9/x8EkSMnEAFKTj676LoweyLdeHhY9Yvl+r8ladFa6ameA4rCJoO++AZaqVWO0dGyfGruenbCh3PLwOSghDHMYbnWVDskqxIfmwART3kXXyimf4QlDcBRXbr2LoKW6gxeAILY9J94oRvRuqt8AYkHCjK/PbkyEsI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287735; c=relaxed/simple; bh=BEoCcAyF+R/sOKReri78++IeZsP6ZHkO2YpBECkJFOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U9xjL5AgxBQf2AwP3TOi4F9Zmwmq09gdAYFiImpxYuTCxG0KqUx9n7uYxt2ocJ26MyBAqNHE72tuMjNvZNyc2K5B0nSiqOKhcveFmUEhVNRYzIn0zQHFNUhvc/9MZgsn7Qgi4j30+SkyD64zCKsrwAYargbehSKHXYFYonb0a1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jraZSiFr; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jraZSiFr" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786287731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UvmPAjSTsp9C9P0krIgzdAKGfO6OEzvEZTGyYBjPPWc=; b=jraZSiFrWBbR17WCYVve0oahjZvxb//yOWl+2/23IGcg46nIn7usGNytHs1T8uMcx5MWq8 1j1GlQ+r/NxKs9JJViz8j2XFng86QT4dIMlPAoSd0jL9ADi5ga6t0iIUx0CmMwlXWGZobh /Bp/FSe2ZPmoZCYaL3QXYT5dVvJ0Qsc= From: Leon Hwang To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Quentin Monnet , Shuah Khan , Leon Hwang , Mykyta Yatsenko , Avinash Duduskar , Anton Protopopov , Amery Hung , Jordan Rife , Rong Tao , Eyal Birger , Pu Lehui , Jingguo Tan , Lin Ma , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf-next 03/13] bpf: Drop unnecessary ftrace_location() in update_fentry_multi() Date: Sun, 9 Aug 2026 23:01:01 +0800 Message-ID: <20260809150111.45000-4-leon.hwang@linux.dev> In-Reply-To: <20260809150111.45000-1-leon.hwang@linux.dev> References: <20260809150111.45000-1-leon.hwang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Since 'tr->ip' is already a 'ftrace_location()'-ed IP in bpf_trampoline_lookup(), it is unnecessary to call ftrace_location() again in update_fentry_multi(). Signed-off-by: Leon Hwang --- kernel/bpf/trampoline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index 6e1898e1b200..eddd259d3776 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -1573,12 +1573,11 @@ static int update_fentry_multi(struct bpf_trampoline *tr, u32 orig_flags, struct bpf_tracing_multi_data *data) { unsigned long addr = (unsigned long)(im ? im->image : tr->cur_image->image); - unsigned long ip = ftrace_location(tr->ip); if (bpf_trampoline_use_jmp(tr->flags)) addr = ftrace_jmp_set(addr); - ftrace_hash_add(hash, data->entry, ip, addr); + ftrace_hash_add(hash, data->entry, tr->ip, addr); tr->cur_image = im; return 0; } -- 2.55.0