From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA2F239E9B for ; Sun, 9 Aug 2026 22:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786315360; cv=none; b=os+AkDp/kjM+j/JsDFz3ek/AZKkPgpjALrI8N+palDASTb2f5CjRcHQkIck/q5pfrzCEsHZ4W8lZCNkNi4wq8y4LVyz3SIP15Jx2ei6l3YVlzjGxivP1nq/8qJ2Mx9vr1dEgei0no90qokF+UTqSwxZ1P5ghLISK5CP72dmDQgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786315360; c=relaxed/simple; bh=qI4/6zwpPOEe2bAZ5uGOohTd8n97feY+w5pvSvgzafU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iNIFRcpooFum7TrQ1O+fzqmV4N20EzLMel1UF2wSKNrr8HY01+LIAfDN7/2QVqmA93VqY7/tNdbpN5MFRu0Yi/vS52wzoDPJI31fOnuGauusjPSvJ89qolnhRLboe3ZJHf2WKFJKI1AX+7BhcFW+gJgZChhGH7fLUSGoqhesgNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=C2S+0hHI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qjZQof2F; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C2S+0hHI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qjZQof2F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786315357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ACu9vD6i/DX3GKdaGrdIviPy3rw+7pNVU92uMrfQFmY=; b=C2S+0hHIhCIadKFPiiQYtz4KtGXhCYeZwtV0JupxpffgWpTlqN6yxYxGutD38rBRxINUk8 3QI1yqC/fjzLHW/YniHzRXSAMIWK4mQrrkL9I5sr43Nhj3aHQczfbYo0mRU0laLxdHe0SZ ivDqkCLMUfwJa2pjQAhUNacD/X/b4CM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-UK1oPyw6MjCschLQBL_mDg-1; Sun, 09 Aug 2026 18:42:36 -0400 X-MC-Unique: UK1oPyw6MjCschLQBL_mDg-1 X-Mimecast-MFC-AGG-ID: UK1oPyw6MjCschLQBL_mDg_1786315355 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49571407d1dso7752065e9.0 for ; Sun, 09 Aug 2026 15:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786315355; x=1786920155; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ACu9vD6i/DX3GKdaGrdIviPy3rw+7pNVU92uMrfQFmY=; b=qjZQof2FTo/zcxSCU3hQDJV3d4wbq9XW9kJnAyhtVbTK+H5oe9FNOM7X4Vhk8sjnQv pX5XXa7WquxzrJmHotaEh76B8/sTasFE42eHZJgToRebFQfvpbMmn2KHFUzptquVkt0P E514Q9rnLeJUMtT/hGLNaKh6ilWxxEVZaaGgRni5hLTC+eTaNtriWm16+AZCOUTmny7L 2jnrFMMEulsmaWeqGho2uUI/crp5YTnMeX9+zojFW+1lnAf2BG/NLbbMo3cx+5vgxV2d 4v0oGhkVCZlHVtrbJ45BqhgQjS8ueMZ0Y9ZGhtQA30npo9S3IXfz+sLhACPPCZMC7oba gtwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786315355; x=1786920155; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ACu9vD6i/DX3GKdaGrdIviPy3rw+7pNVU92uMrfQFmY=; b=HOnmofumkmF8xYmXh/fKLFLgovBS0ZCsqQ5WehkTO5phRwKJE/f+U5u/YcaEYClMff /xf/Ee/3RtBD4DKn5Lcxb2M/0qsSyf5C3WnBv2omwkn81AMdUciZ22zPbaPdaI9hEeWk suDqEy6K/drjior9/GLj6CQaDX64NIhQZ2c+1InJwLLh0sQ24tbyM/6pGdIfak7+x1lr danz8FYo2LPTG1/kEoYFR0cvjipOH4RiEGVNwpuSyrmmyxwpKYW2hEew+SJYGmyg8ePs aOsOU2KqvZg0hE0vypKgilF4IF6mTPmOMnKb4SbbbY+ZmbBdIEwomOqQIi1nX/0/5M6l qB4Q== X-Forwarded-Encrypted: i=1; AHgh+RpxqLjTnEL0G3yD2jx1gbfavjCKqwnYeXDPCOqeKDBWAOTYWDGYheJIH1cNPL8TZHkWvJb3Wh699a6PI9Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzaj1MxM20y9DYNddevUOk5V+wZJULVu8vw/AoRZ34faqugwNPl t6CER3cMfAmFuTLbt5WhJNiTqIJXhhFp79C+UeFK35ugLPajyHgmoR5KTzppb5S/yiZ0Jg0BnM2 VlWKJShcVyGq+a+G3o9Lz2q/gOLo6OftqHiEJVEMTub6It3989z5u3bYpBI+zB2p96w== X-Gm-Gg: AR+sD10w6ZcWVZ439ZRtuhKYH4DQkHpISYFHbJeWDE+FR1DCzUuEsdGLjsrLi12BIyv FRxFaeJF7OMAtG12DdzjZv8QjzYadFBCE2z1oy5iRWEmBc7a2E+3Sx4CEJSfobkJcDXoXg0W/Yi HzSz4yNEnmjThUFBBzUviK1sf4XBUXC3rsf769FzD780yn31LlN2IBjLPUSbEuRKbv/ueXrY9fz fYVkvZRlX84Gy7ZnpyfLPz3htjIA+3cpey4Vby2Bsustpk9y9UcajbNXQNawJFj0GH0ouZPzSGx Fc7n0Z9J6hleOZ74k7otPz3JYk7BV4APOYam0R21yMY7jcSxA/uRLpemkf7bPtsNi2tw40RlT5W 7b04Y/vxLOH4jzdOR3awitw== X-Received: by 2002:a05:600c:1c19:b0:499:5220:db3d with SMTP id 5b1f17b1804b1-4995220db75mr447955995e9.16.1786315355161; Sun, 09 Aug 2026 15:42:35 -0700 (PDT) X-Received: by 2002:a05:600c:1c19:b0:499:5220:db3d with SMTP id 5b1f17b1804b1-4995220db75mr447955665e9.16.1786315354716; Sun, 09 Aug 2026 15:42:34 -0700 (PDT) Received: from redhat.com (IGLD-80-230-39-98.inter.net.il. [80.230.39.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542858b2sm389073335e9.14.2026.08.09.15.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 15:42:34 -0700 (PDT) Date: Sun, 9 Aug 2026 18:42:30 -0400 From: "Michael S. Tsirkin" To: Alexander Graf Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Yishai Hadas , Alex Williamson , Feng Liu , Jiri Pirko , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Parav Pandit , nh-open-source@amazon.com, Stefan Hajnoczi , Paolo Bonzini Subject: Re: [RFC PATCH 01/12] vdpa: correct the VIRTIO_DEVICE_F_MASK example value Message-ID: <20260809184139-mutt-send-email-mst@kernel.org> References: <20260809182010.32931-1-graf@amazon.com> <20260809182010.32931-2-graf@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260809182010.32931-2-graf@amazon.com> On Sun, Aug 09, 2026 at 06:19:59PM +0000, Alexander Graf wrote: > The comment above VIRTIO_DEVICE_F_MASK spells the mask out by hand as > 0xfffffc000fffffff, which was correct while VIRTIO_TRANSPORT_F_END was > 41. The bound is 42 now, so the macro expands to 0xfffff8000fffffff. > The comment is the only place we write the expansion out, so someone > checking a provisioned feature mask against it reads the wrong boundary > between transport and per-device bits. > > The macro derives its value from the bound and needs no change, so > correct the comment. Or better just drop it, we will forget to update when we chaange it again. > > Fixes: 838bebb4c926 ("virtio: Define feature bit for administration virtqueue") > Assisted-by: Kiro:claude-opus-5 checkpatch sparse > Signed-off-by: Alexander Graf > --- > drivers/vdpa/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c > index 47c6c3d23f5c..1757a33f298f 100644 > --- a/drivers/vdpa/vdpa.c > +++ b/drivers/vdpa/vdpa.c > @@ -548,7 +548,7 @@ vdpa_nl_cmd_mgmtdev_get_dumpit(struct sk_buff *msg, struct netlink_callback *cb) > > /* > * Bitmask for all per-device features: feature bits VIRTIO_TRANSPORT_F_START > - * through VIRTIO_TRANSPORT_F_END are unset, i.e. 0xfffffc000fffffff for > + * through VIRTIO_TRANSPORT_F_END are unset, i.e. 0xfffff8000fffffff for > * all 64bit features. If the features are extended beyond 64 bits, or new > * "holes" are reserved for other type of features than per-device, this > * macro would have to be updated.