Re: [PATCH] selftests/mm: fix read_file() return value check

[Hongfu Li <hongfu.li@linux.dev>]

> > diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c
> > index ef1ea11981a7..2697d50d07f4 100644
> > --- a/tools/testing/selftests/mm/vm_util.c
> > +++ b/tools/testing/selftests/mm/vm_util.c
> > @@ -755,7 +755,7 @@ unsigned long read_num(const char *path)
> >  {
> >  	char buf[21];
> >  
> > -	if (read_file(path, buf, sizeof(buf)) < 0)
> > +	if (!read_file(path, buf, sizeof(buf)))
> >  		ksft_exit_fail_perror("read_file()");
> >  
> >  	return strtoul(buf, NULL, 10);
> 
> 
> Yeah, that looks correct. Do we have Fixes: tags?
> 
> I think it was already wrong in read_num() in
> 
> 
> commit e0c13f9761df8f97cf5e81495d12ecbc4075684a
> Author: Kiryl Shutsemau <kas@kernel.org>
> Date:   Wed Jun 3 16:00:06 2020 -0700
> 
>     khugepaged: add self test
> 
> 
> where we had
> 
> +       ret = read_file(path, buf, sizeof(buf));
> +       if (ret < 0) {
> +               perror("read_file(read_num)");
> +               exit(EXIT_FAILURE);
> +       }
> 
> 
> So likely
> 
> Fixes: e0c13f9761df ("khugepaged: add self test")
> 
> Acked-by: David Hildenbrand (Arm) <david@kernel.org>

Thank you for the review and tracking down the original commit.
I will include the Fixes tag you mentioned in the next patch revision.

Best regards,
Hongfu