From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BA23939D7 for ; Mon, 10 Aug 2026 06:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786343938; cv=none; b=fq7Nn7TJtdT07QQMxVFDQQu9Zkpx3CvmeOYojjgsuplddNd2+42MtdE9fAQLGGSHhAyOqVc1QEh16sbBc2mZTXCs4me+ad4eGo3fgjhGkUs63Gloabc6UUKevr3tNa6wA+9iXBGLkfqzG/wPfUb9OajSXJWcSISQqJFsoDyE8+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786343938; c=relaxed/simple; bh=eOhyBaxVU3H5GsJyGAc5oPRoZW7pggT5TSaQxAt2Px0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FgMo244AWQokLmtU5iAh50UiakMaCUd02d6RRTaxVxR/VU36QOqfiACgOZTNHUh2AW+PwpkZftr1Ch3Bx8IvJ8rnUmX2Zz/4/iyWlHoEI/MKnEBBExbOIZwWW4B8uxMhgKiNHGE9ooCTbQDF7or4EOfHwsT6YTkQOktQy3J/L+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CqK0vVyf; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CqK0vVyf" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso796864a12.2 for ; Sun, 09 Aug 2026 23:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786343935; x=1786948735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cQPgo7/ImwAyna2sJScM9HYP43JmyinkJZImCKBlm+8=; b=CqK0vVyfiHcyBjSGlMVyRksfqw10qeiLe4vpUKJHI1wfNltlUuVHdMfQMVJd7e6/ER bUaVkkz5fA2qHPpUQZ12OWg79iF/WtZqxkcnlIrYzcz7tXvGtdIwzbevE+kwhVYcsM6l qeHFfoG/pEbaj/2TT6bEHbxiKhyXmUY2fM/1RcMGkBeQUI+Mhm9+P3UA24RVfivNRId7 YjKVwfKQlCtLbdXbawYINSsqGdvnpgNwwrksCp+O8QxXqmcb1u7c8cEtVyAk/WZiRl7g ZpE2f8RU1dqDOSJ1kGdQFOqDVWMUrVFgkv35OC9jqJPogVyPMFLDSQmzGlIn8rryaP7b 9eiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786343935; x=1786948735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cQPgo7/ImwAyna2sJScM9HYP43JmyinkJZImCKBlm+8=; b=iYneN7FybyIYswk8d/GxPGfCV+M028sx08q44HPrAyiYkhcPq0+DEwtNGaTA+rv+MA krwps7W8nfABxAXRDzK9MK9g+5jKRiCbq3nTSFYtAmj4Tbc+XUOXqUfxMw8pFJrJJiwH z1XXKbK1U0dQnTLqm6w2orzwydh+Laf1GB5WztTSxvbD1j/Pie5qbJKU8vPKq9dYZ8Ss qwt1hquijU/3vvnuCX8f9afO/BaF3qEWvytbn/lJnX/GX+oSupMqdi5pEMOrpZDCtjs9 aObqo2GHRYz3keJwBLkzlkHBQy0tyD+x7AFx7FvMKZNGfuMNy1W+FcTtPfHwVTr1920w 39Wg== X-Forwarded-Encrypted: i=1; AHgh+RqIKClMcF9uCNBxLtnQVjoRNNZq4SKlO/iorq0TwBndtoIvL9oul+wm+Z/pk+oHftgNV/vAjXlJbshUPfw=@vger.kernel.org X-Gm-Message-State: AOJu0YwncaifKft3v0JNmgBZMFcvY1Z9/xBmpkbpO7BG9lPNgSO0rd5w Le//FH5jz4UZJ7mtFNjYW+rwsKfQgYFQQFa3HUxRgRuU++xpfc6wfaJg X-Gm-Gg: AR+sD13kcnaWdY3tE/Nl/4DqLQ/aK+vSWiVyt+XyX5JASCeNHGPUW0Bfi1C5z/TNv3s lp96tFjpd8Y13V43+gutaEgxRUyPGOOrPNx8NqadTF/RS+w/B5OKNkquLFjMoLhu3XbfwGAQluo U2rMsXCkITteqwLVUunNd+JKyMNv50vNQxFKYLYUwULRWpGEsEWxIKg3o5D9tvPbmSR0FU31BeS Dt805GkD+i3290cYIZsMKh1Kbz3G/NILzpTKcCF0OVwS/3mEQVBHi61XnqeZ+EVWrcWusXGlPj2 5OrDcidyo9oExx5T9C10DBFQvv8Rx+kNacUop4oGV7DNX6K5/OgUMn8uTKPP6tl6UbAVOKtu2yz VD/LOL+olfxIPWHyT5gCKaFJaCN5gLHYriItosN5BllHr6jYdPUt18coYDo7wz29J72mT4DtGqe xCuoRXUnkA5q9varVxYeYtGALKZ/khSdpT53RAQ0eH6i0MidCQOvl1+2lPSrCxot9sKMuE3WhKt VO5LZF3YE3KbL20Corv6PyyxMA= X-Received: by 2002:a05:6a20:9c94:b0:3c3:91f5:82c2 with SMTP id adf61e73a8af0-3cbadb861admr30450624637.16.1786343935121; Sun, 09 Aug 2026 23:38:55 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bebde308sm39626282eec.20.2026.08.09.23.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 23:38:54 -0700 (PDT) From: Malathi To: Tony Nguyen , Przemek Kitszel Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Malathi , syzbot+e0abb1d45ac291ebebeb@syzkaller.appspotmail.com Subject: [PATCH net] e100: fix shift-out-of-bounds in e100_eeprom_load() Date: Mon, 10 Aug 2026 06:38:15 +0000 Message-ID: <20260810063815.151326-1-malathi.a2000@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit e100_eeprom_load() and e100_eeprom_save() start with an address length of 8 and call e100_eeprom_read() to auto-detect the real EEPROM address length. e100_eeprom_read() adjusts the length with *addr_len -= (i - 16); based on when the EEPROM drives a dummy zero onto EEDO. A malfunctioning or emulated device that drives EEDO low too early makes (i - 16) exceed the current length, underflowing the u16 addr_len to a large value such as 65529. That value is then used as a shift count: nic->eeprom_wc = 1 << addr_len; which is undefined behaviour and additionally overflows the fixed-size nic->eeprom[256] cache. UBSAN: shift-out-of-bounds in drivers/net/ethernet/intel/e100.c:768:21 shift exponent 65529 is too large for 32-bit type 'int' The EEPROM cache holds at most 256 words, so a valid address length is never larger than 8. Reject larger values before using addr_len. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+e0abb1d45ac291ebebeb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=e0abb1d45ac291ebebeb Signed-off-by: Malathi --- drivers/net/ethernet/intel/e100.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 29960762e64a..a236273f5e65 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -765,6 +765,11 @@ static int e100_eeprom_load(struct nic *nic) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); + if (addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "invalid EEPROM address length %u\n", addr_len); + return -EINVAL; + } nic->eeprom_wc = 1 << addr_len; for (addr = 0; addr < nic->eeprom_wc; addr++) { @@ -791,6 +796,11 @@ static int e100_eeprom_save(struct nic *nic, u16 start, u16 count) /* Try reading with an 8-bit addr len to discover actual addr len */ e100_eeprom_read(nic, &addr_len, 0); + if (addr_len > 8) { + netif_err(nic, probe, nic->netdev, + "invalid EEPROM address length %u\n", addr_len); + return -EINVAL; + } nic->eeprom_wc = 1 << addr_len; if (start + count >= nic->eeprom_wc) -- 2.43.0