From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA78236A356 for ; Mon, 10 Aug 2026 05:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786341455; cv=none; b=kRu53dtTkVDoFO5dAOI95/PeqCs7o0qnQt5Ej2tvyjjkVS9Hzxr2rB70z3vCAFbS7YhNRh/uyHYz3Y8/AL3hFYyYc2i5kKm2NElVN0jrMRwQ5q1GvQwDJwCBNwlcIy9usAfFMhQZ5YYu9rPWonqajdn/PrRRxOVtJ8OkZOeG690= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786341455; c=relaxed/simple; bh=yQGidt4pmHSscqeRrnyQ+tvHXxIdvWfAR3XNmGIutIE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=LYAiP9urU5ruz4Lu3DzbQYaXV9cCmtD/XwZhTlNOlaTJY+LTbpWPyvEd3XrA583nEjtSqoqHciF/XSv3M7Sv90u6uDFnVrkv0laoeknFMEoiqUT1NMJdMYGO7q7OSi94l5MEK6rQoLebJFySBMCBQ3ecqjl2SQ0G4aCj1R8dTTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qcS3NDl0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qcS3NDl0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4996f1ee4a4so3699895e9.2 for ; Sun, 09 Aug 2026 22:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786341452; x=1786946252; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7NK9slaUcp7pt1m4E6R7eQ5WHy7YplLrKlJA3Ixna6Q=; b=qcS3NDl0BAIWsgTHtdjH+cQ54LzhHrv5y1lB2aeqOn+9UyKaopXk19tq2uQwaW6flD GAHispRmnvDZ48Gs2nuPw7ZSFHUUmjOOBm7txsZrAY5plHXJZh860HpsStSOJjjIjUFv MKZcZ8iKc9dDO9JYuyBzrhauqR1FRPzaRgLoqucRMhDuvsNucpU0vrY7sTFVdJMrK80V r5AtO7m4Vy9sHflBzQ2n9K03Ym2cXMcqzV9zO19mD0dYMZ/R6HgPO34AA0v/fzLMI6kv JPYRsU6ugcOYaqhsw1Jz5/C/LqVv+fNT0yzBA78uM5+G5WO7e5AgjTpDjgNs/7lQtk1X 5gpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786341452; x=1786946252; h=content-transfer-encoding:content-type:mime-version:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=7NK9slaUcp7pt1m4E6R7eQ5WHy7YplLrKlJA3Ixna6Q=; b=hUuONqB2Ph5QEFzgNuu8MWBtUlbUarRUdZmJQpnLNRAgn+K7BhjOIT0KdmTyUB1s0m RB88u9BQKtLpgxWVWKnVkRuri2caVVbRuCj7d0jad44iZ+719g7/XzKwtEtvd0IBRvRA FVUQ3UNAur5tXPd97ZFrQpGu5MjQ4+QI38vnzJy6ur86WY4uPu+xAFvYRdMi81nM7rX4 xnxp586KmPPsoJecAjplPhjVBFzHYeUmO0i6U8aJns9JSKkJr/oB4KGcz+KXGIctubMo heHzWIXywWRsI/eKsPv8FE4uYgLHqgNBUKz5Z0SU5bgaQZUvEy58bGtDx6F5fLnMnO6R 0V+g== X-Forwarded-Encrypted: i=1; AHgh+RorGMCx8jM6GxhSVtKOh67znxJOI0NkDQAYcG5ztV1PjNKsGv1jysCqFVWI92yGG/FXuJ1KjJDEiGz3zbs=@vger.kernel.org X-Gm-Message-State: AOJu0YxtrdmwVhf6l+xxXMzBp7lL6lFpaa59ZgTgmBEu+SbjYg11fR1a 2SPbeQhfBVffUPZn42tj4yDxuuY2yK6aWBnaYW4Z8mnlHJ1ybSrtCQcm2uBQ3w== X-Gm-Gg: AR+sD13eC4CfK8EyKc/WcyjScnHDnLyx1vlQF9gnosH5GH1NOWxwqExr8DLbvA+RJAW 4RvHS9LZlnm2id/PaLYnGAHrQqwTZFSN5UlgpaUf1U6CR9GEknRWicghQ33YoZZ9XQe8FZj0zuR gmsduHfFNThnQ9Qmbnago4LLUdJ2OD/8JjGmBRzNFIOaTmguiUZY013uiIctWfDI4IBf4qXsK3K 7+8+Nurv3rFmzHC8EB8iRewyWlUudAEgKkNG2d0oW5fV15DrJHU7C6AvKJKGcyfItL31r9QayrT cam+7JnaAl8NLS3Xb6D2IHRkD22f/K77G3Tt6SlfG+z0DMAdjowFAwI7iGDqXYupwrzKmD4FMV/ qKXD6A/db0h8I3zpebdrnDfKiIF3Oop4+ljJacge69w1f5K9tsFCs4fhIaDBpNnx1l4InM/FbiY LC++Ar8eaTH2Z2n5+iy5Ho/07O8TMiNSgwR6RWCb6rB6HsTp8curEp72I0KPYgB/9hgR+XSqIo X-Received: by 2002:a05:600c:c8c:b0:496:c18c:f9a3 with SMTP id 5b1f17b1804b1-4994e79dc76mr487622485e9.5.1786341452120; Sun, 09 Aug 2026 22:57:32 -0700 (PDT) Received: from foxbook (bgt135.neoplus.adsl.tpnet.pl. [83.28.83.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995c69c777sm276712085e9.2.2026.08.09.22.57.31 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 09 Aug 2026 22:57:31 -0700 (PDT) Date: Mon, 10 Aug 2026 07:57:28 +0200 From: Michal Pecio To: Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: usx2y: Stop clearing urb->hcpriv before submission Message-ID: <20260810075728.483c827e.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit This is managed by USB core and drivers aren't expected to touch it. It should only be not NULL on a submitted URB, in which case clearing defeats the "submitted while active" sanity check in usb_submit_urb() and may crash the HCD handling the URB and panic the kernel. Signed-off-by: Michal Pecio --- sound/usb/usx2y/usbusx2yaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c index 3808df54727d..a3a0bc13632b 100644 --- a/sound/usb/usx2y/usbusx2yaudio.c +++ b/sound/usb/usx2y/usbusx2yaudio.c @@ -167,7 +167,6 @@ static int usx2y_urb_submit(struct snd_usx2y_substream *subs, struct urb *urb, i if (!urb) return -ENODEV; urb->start_frame = frame + NRURBS * nr_of_packs(); // let hcd do rollover sanity checks - urb->hcpriv = NULL; urb->dev = subs->usx2y->dev; /* we need to set this at each time */ err = usb_submit_urb(urb, GFP_ATOMIC); if (err < 0) { -- 2.48.1