From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF9773932CD for ; Mon, 10 Aug 2026 08:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786350401; cv=none; b=A0Oa0TzuL0gIzzdyS594YCfYSctAUGtp9FW7VpJ4KDDa3vlEEdnZCo7cD0E5NRM4uYhaDJnP7ECtSEA09+jU11sSj1LiS1s2oOBge6DX8S6ZhPYL+DFTxJUa/AjszC9LIVWxP4GB2TaToQgVVLxVlFBvbSCKHINU46aptJddlQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786350401; c=relaxed/simple; bh=62L9uynb/se0eilndyIIvfvtAW6tC/LHcDa5OnCWfwc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TQYUSPq8bqtBQrrbYxREhlBJvX3KgLekNxegmufRkK/sCIIgR+G5suVbN4y8/razSDt7C4mZb6WtBKBg+ibJH5y2Sz/x397I6loFWDcU/7GOL624+g3+MVqB3NO+gESMGO56xgMyQ6lvxBnIeWAGreIg3DkBkaXuM3vRZUbXCNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DDZOY7TU; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DDZOY7TU" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso1320484a91.1 for ; Mon, 10 Aug 2026 01:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786350399; x=1786955199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Nj9W1H0BK4w+o3hytXvjAjHkDEStVnmqIzc1JlXFMlw=; b=DDZOY7TUGDxmAH3jbz/VIofZTxxf25LIc/mzFoSqDo/bY7+kRx7h8R4m/B5MlDMFDb mkq/ytwisAAw0sosG+MB9Frsh/vS+JXsBYf7oqtYiqSwmsZRC4b5Mcav8c7pWbbEbObo oFl8wKHZ73WFqe+d20C6CyuZcQ1b0mn6clCpTy86ZuXst45LTsdYfIp7i/8wLUnWW8E1 tPMBiMlKuBYRfuevyfwODjx9mDEaTEGVsU2VEeAgTcEvcouA6ZvXbbHjiqzNLTfhgZ5O rEAntpkpFmK3TovPXIL+MTaEtE3on9IKflIvOL2e6mSaSF9WvcHoeKMJSvECQDRhqp8g a9MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786350399; x=1786955199; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nj9W1H0BK4w+o3hytXvjAjHkDEStVnmqIzc1JlXFMlw=; b=eC0zRNrwWQZdAhnQa1Y/RH2EV+Kr2mIWD7rhAZ57PRTqmBPr9l2BKWkTxkR1jSbTrm mQ4P+9lnsajMACbeV0UUdphvz9XDlCRGoimN0f9vNXV2Jaxg2R5AMcIjE0rTNdUKoPtn WLUN9lJGGvT7qAhQey2UR1pccZTcZozIOTzMf2pJysoTwFE/dfJlV6ti4Ywa8z8inuO3 8SWS6O+vLIHeDFXYYoadwC8GnvEbLR0l5vuVOCm81maqTrhWiXxVt9DECWLjeR/Q5+k1 y/R9ZB+EbTaqmXC6ITgfAoty78Bs+mkOPRch9TqGV0jYLg63jQVKI62FN2fFErklvrO5 N6UQ== X-Gm-Message-State: AOJu0Yzu94RwcnBGghB3zQqVfw15FTkItO2QdwmLaBXXfwls2qDXxjHG 9kWSNVKAOVHMFmQwrvLxlKJLnRrit7T03x24EWvG2zBt+SRHMV6ZFTqI X-Gm-Gg: AR+sD12ImpcD1XRenWmVBLtBTV3d9oVfy9Dsuq7FiHR6XKAiETnYWpJOyfCaQpwf2rI JwFoqrCv0+Bp04qKsx8koClydHuIe7w4Q5LF16dOlZ5nYhMlnGRi0hYZ/8dMX1mGmDQwZxASe5v ac8/KNlvxH6Rmmg4No3FkZUIchRlKGvMXiMJWnY6cJAIyThK+VPMBZ/19i6r9zRYXfjQLqAU+on RpiB6sweEWe+BqH0q+SuHoRgD1dwHcP8VrZBctFomcOVUfmRv90VqHYjIz7Op7chZXN0xCx8GJF F0OOMMK4uc7s03HQaXvlR89JVTmNwy7n/+i/Kkm3Kpe5DfOsDAIfLKpZN9UlJ77aVgATL1DpCl3 ew9XwJJHGIIGWX0Fxg+uIta2W0YGB163V864NpaXE+Wyx8xuovgXjzQf/azrgSpoZAAPOIwWlTL voQc8xSswKPut1FAlTDKNG3nq+f3Ns5SuIIww7LVj4EtpMF+Xcrp6mnsp+Ka1g1fTY3APjvMq+k 5v99HsdhW+FwOw06An4DZVZ8uhZbBDjPTC5jDEkP3Tt7Pp/j89rF5oCD1ff6OaWrff+z8Cn/9E9 Iee+ X-Received: by 2002:a17:90a:ec8b:b0:38f:aab1:5148 with SMTP id 98e67ed59e1d1-3903c5d313bmr43348272a91.13.1786350399025; Mon, 10 Aug 2026 01:26:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95c40sm11595151a91.8.2026.08.10.01.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 01:26:38 -0700 (PDT) From: phucduc.bui@gmail.com To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3] watchdog: orion_wdt: Propagate errors from optional IRQ lookup Date: Mon, 10 Aug 2026 15:26:05 +0700 Message-ID: <20260810082606.42623-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no IRQ is available, while other errors should be propagated. Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing probe without the IRQ. Signed-off-by: bui duc phuc --- Link v2 : https://lore.kernel.org/all/20260807080447.35479-1-phucduc.bui@gmail.com/ Changes in v3: - Use goto disable_clk instead of returning directly. - Add similar error handling for the second platform_get_irq_optional() call. drivers/watchdog/orion_wdt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c index 0e145f762f6f..6715186aeac4 100644 --- a/drivers/watchdog/orion_wdt.c +++ b/drivers/watchdog/orion_wdt.c @@ -606,6 +606,10 @@ static int orion_wdt_probe(struct platform_device *pdev) /* Request the IRQ only after the watchdog is disabled */ irq = platform_get_irq_optional(pdev, 0); + if (irq < 0 && irq != -ENXIO) { + ret = irq; + goto disable_clk; + } if (irq > 0) { /* * Not all supported platforms specify an interrupt for the @@ -621,6 +625,10 @@ static int orion_wdt_probe(struct platform_device *pdev) /* Optional 2nd interrupt for pretimeout */ irq = platform_get_irq_optional(pdev, 1); + if (irq < 0 && irq != -ENXIO) { + ret = irq; + goto disable_clk; + } if (irq > 0) { orion_wdt_info.options |= WDIOF_PRETIMEOUT; ret = devm_request_irq(&pdev->dev, irq, orion_wdt_pre_irq, -- 2.43.0