From: Jason Gunthorpe <jgg@ziepe.ca>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: Nicolin Chen <nicolinc@nvidia.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Pranjal Shrivastava <praan@google.com>,
Daniel Mentz <danielmentz@google.com>,
Mostafa Saleh <smostafa@google.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com, tudor.ambarus@linaro.org,
andre.draszik@linaro.org, willmcvicker@google.com,
jyescas@google.com
Subject: Re: [PATCH 2/2] iommu/arm-smmu-v3: Override for Inst/Data attribute
Date: Mon, 10 Aug 2026 11:15:53 -0300 [thread overview]
Message-ID: <20260810141553.GP200537@ziepe.ca> (raw)
In-Reply-To: <CADrjBPoOctsStZn84vtCymdKen2R9XcM880=wxXSv1tpQ5+vyg@mail.gmail.com>
On Fri, Aug 07, 2026 at 03:37:37PM +0100, Peter Griffin wrote:
> > > @@ -1222,7 +1224,8 @@ void arm_smmu_get_ste_used(const __le64 *ent, __le64 *used_bits)
> > > if (cfg & BIT(1)) {
> > > used_bits[1] |=
> > > cpu_to_le64(STRTAB_STE_1_S2FWB | STRTAB_STE_1_EATS |
> > > - STRTAB_STE_1_SHCFG | STRTAB_STE_1_MEV);
> > > + STRTAB_STE_1_SHCFG | STRTAB_STE_1_MEV |
> > > + STRTAB_STE_1_INSTCFG);
> > > used_bits[2] |=
> > > cpu_to_le64(STRTAB_STE_2_S2VMID | STRTAB_STE_2_VTCR |
> > > STRTAB_STE_2_S2AA64 | STRTAB_STE_2_S2ENDI |
> >
> > This adds for "stage-1" and "stage-2", while missing "bypass"?
>
> I need to follow up again on this point, but I don't believe currently
> we require the override for Laguna when it's in bypass.
Oh? Why not?
Is the issue the IOPTEs are set to no-exec or something like that?
Jason
next prev parent reply other threads:[~2026-08-10 14:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 12:39 [PATCH 0/2] Add arm-smmu-v3 support for instcfg data override feature Peter Griffin
2026-07-24 12:39 ` [PATCH 1/2] dt-bindings: iommu: add arm,instdata-override property documentation Peter Griffin
2026-07-24 12:39 ` [PATCH 2/2] iommu/arm-smmu-v3: Override for Inst/Data attribute Peter Griffin
2026-07-24 18:04 ` Nicolin Chen
2026-08-07 14:37 ` Peter Griffin
2026-08-07 16:43 ` Nicolin Chen
2026-08-10 14:15 ` Jason Gunthorpe [this message]
2026-08-10 14:43 ` Robin Murphy
2026-07-26 13:16 ` [PATCH 0/2] Add arm-smmu-v3 support for instcfg data override feature Will Deacon
2026-07-27 10:53 ` Robin Murphy
2026-08-07 15:25 ` Peter Griffin
2026-08-07 18:21 ` Daniel Mentz
2026-08-07 22:47 ` Rob Herring
2026-08-10 18:03 ` Robin Murphy
2026-08-10 11:00 ` Will Deacon
2026-08-10 17:16 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810141553.GP200537@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=danielmentz@google.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=peter.griffin@linaro.org \
--cc=praan@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox