From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01CE9443AA1 for ; Mon, 10 Aug 2026 19:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390826; cv=none; b=ERjhkw50SIXDJyNpp39oHr9sC/0Ya24iHICdMK7Mf/HV73HD7TpTyx5GwI0ot+9MUId9znhVAPfq8/TYOQOLassQbPlsXu90h2CQjqSfNsGtnmwcFPz9nUsqB9xNwpn/dM9eChtVFcqfYmF9DThChp5unrhusQ4ED1WNK/IGINQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390826; c=relaxed/simple; bh=fkhO9HAymugVq4OmMKfG9p3rUYCS/g1mLTnUWI2PGI4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eKYPR4AClodKyG0sJi6AGmg2WdmG3nVgIy1OC6TKnEuTas5eqr7Mo6bqL0Ss8fzcuOy9jHE1CL98msE2Qgt8VOI0OQlXBxvrudqiDcxAipbKNwV9DxmZhtr3JnSA41QaSR2/Xl0JjX/fxxVvR7UIlym/gJNIPGYuwMSvvdGOXII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IwWxG+ev; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IwWxG+ev" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c1712a04ddaso354575766b.2 for ; Mon, 10 Aug 2026 12:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786390816; x=1786995616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NFDzrFtlZRT9MfM2jyoJYH75f+Nc89HfWr6+v0kWxgs=; b=IwWxG+ev8YDZEsCEDXJBnR5/l6cz4mbv74B/iq98c3ZcAuoiP00/PA5BOLg7BQn4Tn qPddw/Ix2PaZt074WVfsmR2fksdDCQ8yDbirZxyVEw+i2RZA15DqL68YTEHJpeItuFul XH2dC6Yr69uIYQUP8KOKij21Z46aIzhTcM748+yOPmgc4vda1UIxZI5IxpmqQktDHOfG Gs/i5vO5xl4jy6byUqSXaHQFCtpUCrwjVGcxgpsf9xWNPbWfE+3LB03N6dWAAGZAnXh+ CTUOg054XnOfwzaySoibLU90b6eH/P7esVC1EoOwOQCqg5Rl1lSbMVqJSgwnqsM964/G aJQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786390816; x=1786995616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NFDzrFtlZRT9MfM2jyoJYH75f+Nc89HfWr6+v0kWxgs=; b=joBbTpO1vZEry21YWdcgB8WvP9n2/HG+zpW2UPzN67yq8wq6ZfS/X7PE+hMu5oSh6/ YCQ6NQVwXAj9BAAZlZO0zq5JyUILoyvnj1OcpQMS53csoS2CY+i/8r9jzUJ3goeRYA2F 8YGrSEYJ7eJ6h/OTarHgY2P4ug236+FenYNOBFgm+iVQSBSr5f7rmrOzOC/H3f6i+2Y7 fw41H7sxgbxmBEVqUk/pdvv7uVQ68LoS2YGrStJJnmesJF7kaLeM8cX/rc0pWfsBso6r Laltkmd+NY1KQzErMRHBal+Bbi7650sU5rwwN8Kk16RIbxI5nSksoNn3vSmkHr7/n3IK bY5A== X-Forwarded-Encrypted: i=1; AHgh+RoCk+kiREZO3Jc2cWh7dvplY8QPIURtVkvkEIMj26i/uyXBmwFOc208/YcIE3264iTOSqbWcCNl0l8Dgao=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ/AuWZH7abgouJC0UEdkrBtnv6VJ1w333Lb0BAjuXgvSBdczt LgsZ5FIAYUerRIjZqKQd+HNIeXW0zz/wXFyZ57RWfwLSTptGPfvWR8AC X-Gm-Gg: AR+sD127rxSSz6/BjWnX2J+1yTKGtkT0wPBLVh6LYqbxeDcIkrPBe5Ahy39trGUpUZk WM1jUHvHxDvsi0oqcjiVECgeXIqRRU9so5AFLf+f+uf762V92mgKN2KRBUhaVWu1qjaaTwBIOMu tCUmUOk2cYkroRfMHMkIkYzBe0fCCZQ7DkGaB6Eqp+ONC9TaF9z1icCNfdmFjiJ0Eq1p7OzOUh3 AcTzbJW/pXeS4AC7vB1qcs6tYYdjnXkHJQzHhsvmVKgJiCMeUE3ES9btuHO8Ql8SQX79kQZcoVu YlMkriKwK12c+Ct/P4I9vZdPHY/gGM1eagPcA4NRFzOsxLG7etwJgK8ZBYrSf02d0Oo60bVAOw/ ltRizyxtppq49EYmmTY/1+3HIDklxOYQ2UB+fpiazVOXQXoG5ZR56AwaZdRSm9VfoG3MOpxAaOm R761sP2lVwG2e2O74XTfivM4INEUxFpOYCG3Lb9uWV0gVdA3PO5GmURIB/w0RHR+FGdwfH0tXHT LAqb/UFt8gbY8hhwn6v6SRcaWY9ht0= X-Received: by 2002:a17:907:7245:b0:c20:899:b8bc with SMTP id a640c23a62f3a-c20c672433dmr236286366b.6.1786390815810; Mon, 10 Aug 2026 12:40:15 -0700 (PDT) Received: from buildhost.darklands.se ([2001:9b1:ff:d701:51eb:176f:63d9:53f8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080a29a84sm449928966b.3.2026.08.10.12.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 12:40:15 -0700 (PDT) From: Magnus Lindholm To: richard.henderson@linaro.org, mattst88@gmail.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org Cc: glaubitz@physik.fu-berlin.de, mcree@orcon.net.nz, ink@unseen.parts, macro@orcam.me.uk, Magnus Lindholm , stable@vger.kernel.org Subject: [PATCH v2 3/7] alpha: fix the local TLB invalidate in flush_tlb_page() Date: Mon, 10 Aug 2026 21:34:54 +0200 Message-ID: <20260810193902.3286353-4-linmag7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260810193902.3286353-1-linmag7@gmail.com> References: <20260810193902.3286353-1-linmag7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit flush_tlb_page() invalidates the calling CPU itself before asking the others, and gates that on current->active_mm. For a non-executable vma that means a targeted tbi(2, addr), which acts on the context currently loaded, so as in ipi_flush_tlb_page() it reaches nothing when only active_mm names the mm, and nothing forces the old ASN to be retired afterwards. Test current->mm instead. Reached in practice by folio_mkclean() from the writeback flusher kworker, which has no mm of its own: about half the calls during writeback of a shared mapping, and none at all on anonymous memory. The caller-CPU omission in the same function is fixed in the next patch. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Magnus Lindholm --- arch/alpha/kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c index 1ad448105201..7856d23b3384 100644 --- a/arch/alpha/kernel/smp.c +++ b/arch/alpha/kernel/smp.c @@ -684,7 +684,8 @@ flush_tlb_page(struct vm_area_struct *vma, unsigned long addr) preempt_disable(); - if (mm == current->active_mm) { + /* As in ipi_flush_tlb_page(): a targeted tbi() needs MM current. */ + if (mm == current->mm) { flush_tlb_current_page(mm, vma, addr); if (atomic_read(&mm->mm_users) <= 1) { int cpu, this_cpu = smp_processor_id(); -- 2.53.0