From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D919442B3F for ; Mon, 10 Aug 2026 19:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390834; cv=none; b=P0RISlLIyFeK1MxUQWaxmTQp4hUJEACMNLf9PL3R8m8o7MSVYZbxnkYzXOLrKF649GCnEd6HhEX2QTjhm/FQyWIvnQQP44va+gNCev8plUQSRq5UOX/I0lPz55El7meDEEdxgJD3HeEVhC01aq8+q0EWw5HPe8szVCgT8KI6jaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390834; c=relaxed/simple; bh=HHYWIbYZQXa9nFoSOde0y7v8SzeS8K4QFE8dQsCXdhs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pX889FeuyQFpv0m3CT01MpmW8B/1o330UH74pyLepRrK2uy9J2m0EKVMAf8ah3i67CBKIlKLUcLSx05bfMcOPX0egVZpg+2S0NVe3xxl3rg1/ssRYPqNPc355GLCo0XU9lrihbAsLPARhvdFMLS2RBXepJS5TMn02WEJ5JnYmJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aztu9krM; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aztu9krM" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c15b1da6b82so211759866b.1 for ; Mon, 10 Aug 2026 12:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786390819; x=1786995619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SMDjp/2Kph0Q/Gm3PYQzClsmsJVYRNh1rwgrPz5zZYY=; b=aztu9krMkzBKQde2jDf5M+Z9GZmONL/rsmIxCIp92K+m1GwhOqA9mUqXR2ISJ0qsO2 veVkeUtncRX4ZsQFianopBEpU+2zWwdsHyOJWylGaAqOh0dKDtTyI9Es2Go5rX+7RJGN ycb1nMlo44ImZHsAJXmpgAw3uwPT4zIpSDfo+ZdKZZx3no5hH0RVv8OGlC1bj+IBViMI LS7Q6tZrY4dDVkRE38FmdfyZR6tS6tOJ8NZSdcE80PQSZ24j+RNUbx9IMdgw3A9JkAGF RfnPiALFYfMpx+HqIYmR/Ahtz0pScXjf3hAqMZRcOfe0cwGdMQSQoCfBhAiFIBz2QUP9 bCkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786390819; x=1786995619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=SMDjp/2Kph0Q/Gm3PYQzClsmsJVYRNh1rwgrPz5zZYY=; b=QzZ3uyONFbtFpv6FsUJy3Jz6nnLuBkBbcWrfy1mseH2ibM/TgjQYL9sHgwkwykMDrm Z+JTNVjNzo2p4HZCX+dsf7vDFfJDE3Ea45FUdUKHZ+vzlMu7Q9CydJpuouid47HjyVsT 9RHVKWeYXoF0Z0qzHHHENDVc7iX+ugU1Bd3644suVXdWHb4bTkxvhsI0fOk4O+QBFACV 3X6zNNmG7RbWvMEOLstMXIUmR9dtVy5oUHG2G8zTA90vqzNeou9peFL952VVCXghftOb 0oQnsf77Aijf2lMY1zjzMhSbCAgCmtYhZvcslu/8bRbqp6MpS6D17zbvPtrLiRBlFrwj APNg== X-Forwarded-Encrypted: i=1; AHgh+Rq2GNx8FIIyzxai1DR1t2HYWguk+Ugaskb8LnIKc2Zb1F9RNr5pUbvULuqa0RwoVXJkqjnmlpKdRPGkITs=@vger.kernel.org X-Gm-Message-State: AOJu0YyV/yZFtgBUYet1vNVrrx6g5pefG2sIdatrh1scOj5LXZvWFx/O Tyk4NDUBdZOaOEiAxRnTQGXXFmuxMpvWjPtxf8jM/mOPyiJOcgjKzKvS X-Gm-Gg: AR+sD100ZkQPvEoAQg7rXPkwghlZjDnmVmiYAhnqW3eZ6Bi9FTiFQmj72Nj106dnlBS GKsZbpZxZSmkU46RAdM542K0x+rSLsdxWeLGhm38qepqVxfID+8z5JGaz9CeyeIEr7mtOVzj7yy KcbXQxC0/CdMEs8QHB+Na/vsK8BYw4UulhW55jvacEZHcrv3vthB0ttCFDMw9vdiWY+KnE7+WQZ lAViwZokgJQ30R4s0DWsfNF70s2GO1nhG2Hyeg09QjcJIl5t2DdqXjKrNLI5O0SyidQOAd6YiWD aTDgA2YAoDZuLZnk8k07X4CDCV/PnnT0OOAwLKS87vaLrvmexEghGBc7MeKG1t5uUyN1o6kyrsF ZpiZ/g0xDERbsNYewqYVq8n9Mq6/WxQUELmRUxT4ktYo4Lwoj8nx81uJy24KH0sp7CktTBBjaZr tWRp5DG2TL9oG6ZgM6ZN9YChkZYAVEh/Fqq5HldmNMaZWKt4Vnye27gSl/LYtmBSZdSGJ4yPGoD U2PAnCim4V5JcTBNdrJTjiHs1BrH8c= X-Received: by 2002:a17:907:3e0a:b0:c15:f4bb:e663 with SMTP id a640c23a62f3a-c20871dba75mr1097344966b.10.1786390819229; Mon, 10 Aug 2026 12:40:19 -0700 (PDT) Received: from buildhost.darklands.se ([2001:9b1:ff:d701:51eb:176f:63d9:53f8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080a29a84sm449928966b.3.2026.08.10.12.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 12:40:18 -0700 (PDT) From: Magnus Lindholm To: richard.henderson@linaro.org, mattst88@gmail.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org Cc: glaubitz@physik.fu-berlin.de, mcree@orcon.net.nz, ink@unseen.parts, macro@orcam.me.uk, Magnus Lindholm , stable@vger.kernel.org Subject: [PATCH v2 6/7] alpha: invalidate the local context in flush_tlb_mm() Date: Mon, 10 Aug 2026 21:34:57 +0200 Message-ID: <20260810193902.3286353-7-linmag7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260810193902.3286353-1-linmag7@gmail.com> References: <20260810193902.3286353-1-linmag7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit flush_tlb_mm() has the same caller-CPU omission that was fixed in flush_tlb_page(): when the target mm is not the calling CPU's active_mm nothing happens locally, and smp_call_function() handles only the other CPUs, so this CPU may later reuse the old ASN together with the translations it still holds. The active_mm test itself is left alone here. That path calls flush_tlb_current(), which loads a fresh context through __load_new_mm_context() rather than issuing a targeted tbi() against whatever ASN happens to be loaded, so it does not depend on which context is current. The uniprocessor implementation in asm/tlbflush.h already has the missing branch. Counted over a fork-heavy run, flush_tlb_mm() was entered with the mm not this CPU's active_mm 2934 times, and 632 times while otherwise idle. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Magnus Lindholm --- arch/alpha/kernel/smp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c index a5a42ae4a7d8..988e397b0b8a 100644 --- a/arch/alpha/kernel/smp.c +++ b/arch/alpha/kernel/smp.c @@ -649,6 +649,9 @@ flush_tlb_mm(struct mm_struct *mm) preempt_enable(); return; } + } else { + /* smp_call_function() does not call back into this CPU. */ + flush_tlb_other(mm); } smp_call_function(ipi_flush_tlb_mm, mm, 1); -- 2.53.0