From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A121C3290AF for ; Tue, 11 Aug 2026 04:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786421357; cv=none; b=fFidGcybrkat3F/Cns+c+S/tmtx83IyS6plhwpaUYApTaH01z+2fC0NFbkwTicvjhvlb/Co2WXAQ7bo3wBzbLNsUiYB5iwjDeS0CbQjrk/SyQ9/eHDY0a/ifqBx45XJLwF4iUqqcZHMZgm8PAi9yKhtZb3xnaYCDGaglzaVPv3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786421357; c=relaxed/simple; bh=7jf8gXmAi89QvIh4K2fPBdtAhr9vlyruFM62y0d0HCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JA54ZJVajfcMVbMcO1E74JbNZphDsqBABWyFTrpJiNkx23DMIHHF/FEBR8qm1869ysrUHi0GOMMa4ds1krtRB5VDs5ycsCaT+yIxtRqwX9TXXTBjdbz7/rpFOys0VrfcNGES+YNe4o49GaTX2Rh44PnzSBZCdUE2RTuJErO9lE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GWFGUb4B; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GWFGUb4B" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cace91f112so29845665ad.0 for ; Mon, 10 Aug 2026 21:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786421356; x=1787026156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=DJlEafp6iccF9h9o6L+laBWKHv5r162wbzlbDYkDTLA=; b=GWFGUb4B2LSUGRv9slO10YXG74mlJ6bwMNTz4CbyqNGcUowtviBnrA5PhoL7DBTD9/ DV3fg49GkRruwxNJuBN5bZ+7uvdQLF0ueTsTWn8QQVEK4UJ6hZHGsGVPCB/+2o4pt5ex YQugTgPyfd6AKUYP+GRGn1+SlFwA+eYy6y3xYPvvj1YJ9faS+uTQnn/AFL5I8XeUuy8c ZNX+qNU7ePUalBRdEach1zafSJef9pKR757OWBZWpp17NKggpC2pTku37uSsHAlj2pav UNSYP7i9VE/iLqsxmAfLMQqg3ImLpha4GWkXmQZbu3uGKg71GdUM4zmgT7rYJ43GBXkU LZbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786421356; x=1787026156; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DJlEafp6iccF9h9o6L+laBWKHv5r162wbzlbDYkDTLA=; b=R3I/8b4zEKWTWGQo08sNzwrWTsMRe/F6rdNiNVRiEbAMN3bRu+uL9elHlx39lJQoNf CIAleHo8wTd/53OlgxK87IO9Ygp2M/CSYhpgJVb9vBwqzg7D04DQF00wl1RfBhPmSicc 57GygIWHRFMGPiXz+3FHyIa5Wea2M6ODdhrmKztpxzzDyywS00mZK3tTlF2sk4hIiRJr NFfoG97QdgP58SIVPfuN2FyOMvfFT30Pke/kVQc37T+1TSi3/LibWydpDZWG+4p/3noh +wz/xsR/LlrGa1rLSWgIRPyIXbIZQeEFhmTcXq9Q6i0tde+gCIQmG4d3q74/O6959nzy z+rA== X-Forwarded-Encrypted: i=1; AHgh+RpxR8GD7wXVf2MJ0TgGLzfWiUgK+kRBz6cxOINFJAmcV6ZcI0vf7fDi9kgVchxLwuVAnjHLDXt09Kb9zFI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxhwnw9KqKRqXRy+wfnvz3DbMs5PbBk2MvSEx64SCdyJqjt3ON3 BqbXe9aKy33O920HldUmsitG4NMm3k0UMqolwWBlpWGXsGsty49FptuH X-Gm-Gg: AR+sD11p8cqoXlD5kmz1FhjgUIeYizbvpcAE+qkyq/Qr2127Wjm+RjRhJOflxOEFTkE BIYKIhoDmXkQSBh8l1HxY2CSoMmSWd70nW409YP4wQMkXyQEmoIzKaEvmibPVJ5Ao6VqQ5elsSy Odv6HC5UTsUhW3M/IUml4jKhzp8+zJBzSSrtj8N2ZFI5NEIWAFDVlKFN3o3+WamqbKUubT8dkiK MawCRrxfq8/dT3BOTB5JmM82i8VnmFNhGdXGpJ+QmPNqFJpyHAFK03YZVdU2iuE5pGOv/GkCZyB UrOPAauByGFCRPH69g9k6IDnFSWaUpYf9ApnmRZLaBqneg97kikLqQlrqWsxbrDBpQlOKN0nNll 6H0ydbixS6xlRjrlcc/8qaPaO9u457VTYFdGVlgVQniMRyErvi2LE3R9Vfhc4QMj4Cq0T856/it rxugwETYP88eKpvQOZvRMf+YywYYUymKTL7JaE9RBrZi/UjMFg0hF4yGQmAzYSZCoUlo3FA+pl1 2BJ+NLDcvF4z5/jDb+/7nAXyUR3FQaSucj/fjqclJtoQfbDD8eCnq00bkA309YE222yFtxogGRc s8kz4TXE37q+Kys= X-Received: by 2002:a05:6a20:bea6:b0:3c3:66c5:68cc with SMTP id adf61e73a8af0-3cc2bafad57mr930131637.21.1786421355638; Mon, 10 Aug 2026 21:09:15 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbed8e74420sm153602a12.15.2026.08.10.21.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 21:09:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Vinod Koul , Neil Armstrong , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Heiko Stuebner , bui duc phuc Subject: [PATCH] phy: rockchip: inno-usb2: Handle errors from optional IRQ lookup Date: Tue, 11 Aug 2026 11:09:00 +0700 Message-ID: <20260811040900.7151-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() can return errors such as -EPROBE_DEFER, but the driver currently stores the return value directly in rphy->irq and continues probing. Propagate negative errors other than -ENXIO using dev_err_probe(), and only assign the IRQ to rphy->irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 7d8a533f24ae..6079e776b4bb 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1390,7 +1390,12 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) phy_cfgs = device_get_match_data(dev); rphy->chg_state = USB_CHG_STATE_UNDEFINED; rphy->chg_type = POWER_SUPPLY_TYPE_UNKNOWN; - rphy->irq = platform_get_irq_optional(pdev, 0); + ret = platform_get_irq_optional(pdev, 0); + if (ret < 0 && ret != -ENXIO) + return dev_err_probe(dev, ret, "failed to get IRQ resource\n"); + if (ret > 0) + rphy->irq = ret; + platform_set_drvdata(pdev, rphy); if (!phy_cfgs) -- 2.43.0