linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Cui <cui.tao@linux.dev>
To: tj@kernel.org, corbet@lwn.net
Cc: rdunlap@infradead.org, skhan@linuxfoundation.org,
	arighi@nvidia.com, yphbchou0911@gmail.com, jpiecuch@google.com,
	ihor.solodrai@linux.dev, suzhidao@xiaomi.com,
	luoliang@kylinos.cn, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, cui.tao@linux.dev,
	Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH 2/2] sched_ext: fix stale references in doc comments
Date: Tue, 11 Aug 2026 15:38:01 +0800	[thread overview]
Message-ID: <20260811073801.342165-3-cui.tao@linux.dev> (raw)
In-Reply-To: <20260811073801.342165-1-cui.tao@linux.dev>

From: Tao Cui <cuitao@kylinos.cn>

- scx_bpf_dispatch() was renamed to scx_bpf_dsq_insert()
- drop reference to undefined %SCX_DEQ_SAVE
- @name is in /sys/kernel/sched_ext/root/ops, not a sysctl

Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
 kernel/sched/ext/inlines.h  | 2 +-
 kernel/sched/ext/internal.h | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/ext/inlines.h b/kernel/sched/ext/inlines.h
index d2d074cee1cb..812d67d18f54 100644
--- a/kernel/sched/ext/inlines.h
+++ b/kernel/sched/ext/inlines.h
@@ -14,7 +14,7 @@
 #include "cid.h"
 
 /*
- * One user of this function is scx_bpf_dispatch() which can be called
+ * One user of this function is scx_bpf_dsq_insert() which can be called
  * recursively as sub-sched dispatches nest. Always inline to reduce stack usage
  * from the call frame.
  */
diff --git a/kernel/sched/ext/internal.h b/kernel/sched/ext/internal.h
index b699e7c1103f..06aab2f75208 100644
--- a/kernel/sched/ext/internal.h
+++ b/kernel/sched/ext/internal.h
@@ -485,7 +485,6 @@ struct sched_ext_ops {
 	 * - sleeping (%SCX_DEQ_SLEEP)
 	 * - being moved to another CPU
 	 * - being temporarily taken off the queue for an attribute change
-	 *   (%SCX_DEQ_SAVE)
 	 *
 	 * This and ->dequeue() are related but not coupled. This operation
 	 * notifies @p's state transition and may not be preceded by ->dequeue()
@@ -966,8 +965,8 @@ struct sched_ext_ops {
 	 * @name: BPF scheduler's name
 	 *
 	 * Must be a non-zero valid BPF object name including only isalnum(),
-	 * '_' and '.' chars. Shows up in kernel.sched_ext_ops sysctl while the
-	 * BPF scheduler is enabled.
+	 * '_' and '.' chars. Exposed via
+	 * /sys/kernel/sched_ext/root/ops while the BPF scheduler is enabled.
 	 */
 	char name[SCX_OPS_NAME_LEN];
 
-- 
2.43.0


      parent reply	other threads:[~2026-08-11  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  7:37 [PATCH 0/2] sched_ext: minor doc and comment fixes Tao Cui
2026-08-11  7:38 ` [PATCH 1/2] Documentation: sched_ext: fix events sysfs path and show_state example Tao Cui
2026-08-11  7:38 ` Tao Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811073801.342165-3-cui.tao@linux.dev \
    --to=cui.tao@linux.dev \
    --cc=arighi@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=cuitao@kylinos.cn \
    --cc=ihor.solodrai@linux.dev \
    --cc=jpiecuch@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luoliang@kylinos.cn \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=suzhidao@xiaomi.com \
    --cc=tj@kernel.org \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).