The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "François Roux" <info@humanlearning.ch>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Harrison van der Byl <harrison.vanderbyl@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Surface Pro 12in (X1P42100): touchscreen variant, different GPIOs
Date: Tue, 11 Aug 2026 12:02:31 +0200	[thread overview]
Message-ID: <20260811100231.79480-1-info@humanlearning.ch> (raw)
In-Reply-To: <CAGA=SDgb93GiaZtdh85q6oWxywjHCiz-hXj4ebukEqM1_aTifQ@mail.gmail.com>

Thank you — and I owe the list a correction, because my report was wrong at
its root.

I claimed the upstream DTS describes the touchscreen on GPIO 51/52 while my
unit uses 38/48, and concluded this was a hardware variant. It is not. There
is no variant, and there is nothing here for anyone to act on.

What I actually did wrong
=========================

x1p42100-microsoft-sp12.dts does not exist in the tree I was working from
(next-20260626). It was created *in my own tree* by a patch I had applied
myself -- Harrison's v1, which carries the GPIO 51 that he has since
described as an early mistake copied from similar devices.

So when I wrote "upstream describes 51", I was reading an obsolete patch I
had applied, and reporting it as the state of upstream. One `git log` on the
file would have shown me that. I did not run it.

Two further claims of mine were also wrong:

  - I wrote that booting the upstream DTS would leave the touchscreen dead.
    Per Harrison, GPIO 51 works but with degraded performance and missing
    pen events. Degraded, not dead.

  - I wrote that both descriptions were "internally consistent, so this is
    not a typo in either". The consistency was real but proved nothing: a
    mistake copied consistently across the interrupt property and the
    pinctrl state is still a mistake.

Where things actually stand
===========================

Harrison's v2 already fixed this, and v4

  https://lore.kernel.org/all/20260609145906.40854-2-harrison.vanderbyl@gmail.com/

is the one expected to land in 7.3. My machine's wiring (38/48) is what that
patch describes. Nothing needs discriminating, and no separate board DTS is
warranted.

Sorry for the noise. Thanks to Harrison for the quick and precise answer.

François Roux

       reply	other threads:[~2026-08-11 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGA=SDgb93GiaZtdh85q6oWxywjHCiz-hXj4ebukEqM1_aTifQ@mail.gmail.com>
2026-08-11 10:02 ` François Roux [this message]
2026-08-04 13:05 Surface Pro 12in (X1P42100): touchscreen variant, different GPIOs François Roux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811100231.79480-1-info@humanlearning.ch \
    --to=info@humanlearning.ch \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=harrison.vanderbyl@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox