From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 164E64322EC for ; Tue, 11 Aug 2026 10:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786443015; cv=none; b=RJQYEICgyLaAMQ/kpcXxJcyObAGK7j0l1sV1VlXRKbOadujw117uN1iReOPyWuJJnSKpNUQJHY12aVAmmtH+H5jUFElEuhB4nykajvRlsr90HJnmeNl0ENQo/CfLdKrhj9/fTRocc3B2YVsW558f8hknuGO6ytV4aZcAep6E2sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786443015; c=relaxed/simple; bh=LDkL7QUnN4FVFemBwTfUF7bwBHp0F+iLG4wJh0jG3i0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Vb1MzJEyn2LOPZ+HBnhY+FReMM/FCxEjUZJyyuwlRT81LNFa/cbwHtUWrUgNBSm2NMxjKVsW/bJCV7bfDp3FoOL2DzHBbihWIhPnWSNDC8nW14TiLyPO6LSLqMjEXYI9i24yQrQEN0d7VtIHh9VGmYczpqEtWmI6rKcsBVv43dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q+c5bF/A; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q+c5bF/A" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2d004f135b1so7728655ad.3 for ; Tue, 11 Aug 2026 03:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786443007; x=1787047807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yi2AQubmBld0thtX/fIlK+IyfhDWkAZ51GVpdWF8ty4=; b=Q+c5bF/AfOEZke0JdQV3mDHGDINq7f+Lp1MuKAszvFd6dm9kHj7WYT7d/5GRDuuSxa X7WA65v2h4hEUy0WqcXPhCDSt40pwfC6ixQr/k9+h8bb1VgBhhVnp+dDCp4x/uG+I0XG oBt+ud+aBmOk5ejm2lNYtQ/3qd/c+/1P4VHR3UU+NKcm452wdBnpBJ6h4eTgFw+vtQdo FtOarqtK4YTV89eS0dG+M1lqZ74vV2WHDXub10y8WH4P6ohSv8r0k53kFzWnDWJIrKOl FjC7k3jMa/piKmk0A36kGbqc0dXsZxZc3LWgkFRgbjb97gAvmxOWNmdXBL0RjBCgtugj Gmtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786443007; x=1787047807; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yi2AQubmBld0thtX/fIlK+IyfhDWkAZ51GVpdWF8ty4=; b=k2uMAH0BA+2ZVM42QAB8wj+M/AIRclf97JaY7hxE6tatiqX5ulcioztlE0lIWo7JC6 ncltUqMAmGDW4+puEvKfuBVxuH+//2y6W6Lp/94nOmgEj5D9dqnIu8/hI1nUcNH6jdpq SvIaRM/XMfWfwkauUZScWAXOYceOHBHdacP3RVzZ0efZlRhMkzqw3GSK8c+2p8tLlI/H wuDAEXshDlSV3bXuXcC8cuLLbfjTYbkxZSc7OGymqynuB1VJ/D3F1E1ltZ7+gg+vGYcu ktpvnv74HxDSzD6GilCfAFxVd/O92/Bb/MOKbGdCWwVhWyZij8issa5hNoL4DyqsG0cc nRNw== X-Forwarded-Encrypted: i=1; AHgh+RrDUyHEJE1Gbufh863fz8iKUZh7GWVCw2Tnl1dbQzlENrEzWVD6Jbs0XYFczVfA/L14bX2XcEbum+DpMjk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+pvI4PcLq2Mna4i/GPIMFCM1+ILbZN4JIVh8AeyClJ86Dh5pn /tf2AaeZxy43GRgjiQze5xd9fjIN0RwK/4i57SMe6mddj4OSMyqDzQRP X-Gm-Gg: AR+sD13f0TUq+kwsSzbFLnb1QbfnMupzIxfvZxFjwdF1Jy+bvwDnUOYio++2x/tw3yS HOjMVfuRgMPNTYIYrADH6uG0rnC2FCS0ZqPCIBkMlSsQhieaA8GMmfxQByueLAPy71x1TYugF2d tPCeDr68QnmDVd2WnK1uMDyWkEgDe39NFp5rtbVz3D71PWtBNxCZ/xpfkeBFFUgcR2cMq/QCVCb CV7/4To4hAoZvPJsiX8oMvS8vVZ0+W+ZZLR2oQrjNT/v+/WqG2QSbgnhmaha9FhT9rJHY6Xxet1 PeFWYxtUpHN89axmNDOZW0hweClaMeKyJPhW9f4QM3n06yyXhaRbRJAB+9EwxWML/4U1JN5wMJx IiphtgJfwr0oThdj0AelPQtIDL/TcxsHolXLvP6Zvwax55ljSR+n1dnhyWxLMZib4Ig/ActoJ2f lP4aHR73yHYrsx3jK902Vs8CFRy0pctNEvoF13I6mAa5tTIWlo9M8dtowwJJgYJa7kRuuU8PJSD MAy5bw95i3t7JweXVzIBMwYzWmEF4bHyh28Bx4Zr1dauqKvZFO9HQES+xCmfQalKeS8W9+fMtnZ 5jot X-Received: by 2002:a17:903:4688:b0:2cf:4339:aaa with SMTP id d9443c01a7336-2d317925cbfmr22741185ad.12.1786443006674; Tue, 11 Aug 2026 03:10:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d315f4819dsm5189625ad.37.2026.08.11.03.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 03:10:06 -0700 (PDT) From: phucduc.bui@gmail.com To: Daniel Mack , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Haojian Zhuang , Robert Jarzmik Cc: linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [RFC PATCH] ASoC: pxa: Use devm_clk_get_optional() for extclk clock Date: Tue, 11 Aug 2026 17:09:49 +0700 Message-ID: <20260811100949.61142-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The Device Tree binding defines the extclk clock as an optional property, but the driver currently uses devm_clk_get() and manually handles the absence of the clock. Use devm_clk_get_optional() to match the binding and simplify the optional clock handling. This also propagates errors other than the absence of the optional clock, including -EPROBE_DEFER. This changes the existing behavior for errors other than -EPROBE_DEFER. RFC to discuss whether these errors should cause probe to fail rather than being treated as an unavailable optional clock. Fixes: 90eb6b59d311 ("ASoC: pxa-ssp: add support for an external clock in devicetree") Signed-off-by: bui duc phuc --- sound/soc/pxa/pxa-ssp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index f8054c1c59fa..3a0abcb0bfbd 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -769,13 +769,10 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai) goto err_priv; } - priv->extclk = devm_clk_get(dev, "extclk"); + priv->extclk = devm_clk_get_optional(dev, "extclk"); if (IS_ERR(priv->extclk)) { ret = PTR_ERR(priv->extclk); - if (ret == -EPROBE_DEFER) - goto err_priv; - - priv->extclk = NULL; + goto err_priv; } } else { priv->ssp = pxa_ssp_request(dai->id + 1, "SoC audio"); -- 2.43.0