From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8FD3B42D3 for ; Tue, 11 Aug 2026 15:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462895; cv=none; b=P4VqJO0mbHkHzdlLaO58sbok3N8RlYhj7Qa4ZmmhVirIuRacOVe8PCLWh9jY4tCeTOsgS9WbhoVgVK1SmSSlgsTQfBZxwLK49sgT4776z4tCRVd63lRir6rWhhYa/0J8arIaHtWiWUEImnK7rnlO2wCUnBwuLte731+euO6nPK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462895; c=relaxed/simple; bh=mKSMctdUiHV7v8CKYXwusXFPtIb1S1vJydiBFzUlq1s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Bs4Lb6zWAk5KzIZTqzExD7T/dzm0u3uHZ+3HbRtYL74IQ/q14KjhM98LtODhuF/2GBhwLY8BczNnsU0U7L4ijqYN6y2Rue2kiRR8NG08anKMyq9E0b3r6o6Z3ILJ9wwcQCjtMw4qM06Mw7+Mkfu8bUGvqdgbGISnrC9SVmg5GNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l7hkGREA; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l7hkGREA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49954b88fffso35363595e9.0 for ; Tue, 11 Aug 2026 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786462892; x=1787067692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QWD3Va6ASDeIp0J3iCIlcAhU+r4lUSfzKNfJdPGsleI=; b=l7hkGREA4GOoxqsOuT2yri6zNPUmkkSEuzKXL6NcAOP37gf8Vs+F3Q4EEjOuhKHi2Y G7qXbRLtSTkJDWo0aXQkB8r3Dy9XXBkzgrk3fGV3W1KXrRlbfe5QLMbnEoG+SlLMWZci TDAXkX9sYZkGzdYEvw5VchEIjNkI8Da1AJtHo8DqipnwDFivYHE6KHXZH7PdI90D59t6 5lTxC0h1Vj0g9sghw2ioU0zAlhxjm6mED2xvy07VVls/VkS6rm4pAQ6+pO3TjIdxvJzQ ca7r3KKjAR4sxnL8C6+CtWIPZEvzo9ce68zEtRC8jKZE5MjnPJuikKMlmSH7RSeHnlNm ccdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786462892; x=1787067692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QWD3Va6ASDeIp0J3iCIlcAhU+r4lUSfzKNfJdPGsleI=; b=Au84ke33iqLTIbEN00bc1ZFdud4SAX/MkCM+pWlpbJrcdDH6QNiguGmyBR9yaYw4vc oGd1PQ3ZyKCXppe5sQK1cVw16uDLtJt64pvo5XWq8SHeO7pUCbto1y+7Sh4kugZAoRlG ks7isDQ+jYpU3MlnH0nyYqTg5JkbjPw5ICozE6YyolYMHokaTJvoSfn24CzYaSBEtKDG rZZvcnLi7akLwNZD43BMjBD0KVtLZJZGgbHck5FGy6d/d6M9vsyPMyL/q97KRCCr9X6J 8mcO/1VgQ+RsseAZ2pfkK/QjOLDj3PkcXyYjdvCCp2HebKDFAS8kXOD8EMdLqGSwKLSN j2pQ== X-Forwarded-Encrypted: i=1; AHgh+RonRO+CfvQqOqlTkx+3HkiBTnLPw3CpSNKbQk87hzc3cQLqSU8+3QI3kchQnvVKD3TrAluciC+jYtIDRVI=@vger.kernel.org X-Gm-Message-State: AOJu0YzEuPaF9Evjk/xBjoPJhMjnhZR6Dkxhp9s53sCgijitd0Vb8Zx8 S/EXIFS1Vm/8LNOPD9aUU4rpk9QjJY+XGjesTA78Yk6mXwEiwIyxy/iK X-Gm-Gg: AR+sD132zPrno2AIM2ffbzmVPS1q1z5hzkUi6htIzavGp/4qhg/nK6jYbLOAR6qJdE2 GRIP5r1Ks+r8PyHnuPYjfpvsN5TnOF03F70AvGPBFMHEw+fiWDeEL2D/n3uFZhcXBELROJAQIH0 xM4XNDl0Wzm9WHhy3WGAXGxT+Gbyrz+YwojZBUMZia43haEx2HYcesznORzpweJUwfYG73jcdlg BKLgYhgJrfNt1feKPZw3jgXBhEbxFtABCTY29bmGtTk9zU4p83EfGxQXuoTrGbfWO1M2HL2XhSQ 71PPodqnQ0vEsIMjUDOuRhSWa/YuKjYyOlDBljeMXS+86Hf67SrtYN/e3zxA5dSAAA5aCNb1ogG isjJQrO9Cf/Oyc0wldAGBpBrCQEI3yDCM03x9K/FuEcFy9L60TfuHxblZzQtibdvBnkJWNjWM7k oi+RjF5CTqyEcEE3ErqQr7J0fR874j17tWxHtptM+gZ9N/vsa3LhRybFXkehaVpjCI3VMzUBcLl WtFshdfHFSgZS+Kh3jdchrIZm2QDXDQlUO8SBrKFOideJBlaXU/CoAYWyserMY50pgy9kjTrGZN TXGt8JbYdzgnyYY6nVRkrHTEgJpH6DYxNSaPiDA7R/pmkQV8sdGGpgO481DMa39/BS9o X-Received: by 2002:a05:600c:4443:b0:495:5e3d:15e1 with SMTP id 5b1f17b1804b1-4997846c13dmr52811515e9.16.1786462891646; Tue, 11 Aug 2026 08:41:31 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a133-e401-bc8e-d36c-2d08-c5e0.310.pool.telefonica.de. [2a02:3100:a133:e401:bc8e:d36c:2d08:c5e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997aaa7aabsm1670275e9.7.2026.08.11.08.41.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Aug 2026 08:41:31 -0700 (PDT) From: Karl Mehltretter To: Andrew Morton Cc: Karl Mehltretter , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Bradley Morgan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Sebastian Andrzej Siewior , Clark Williams , linux-rt-devel@lists.linux.dev, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] sched/core: Pause KCOV in try_to_wake_up() Date: Tue, 11 Aug 2026 17:41:10 +0200 Message-Id: <20260811154111.64669-6-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260811154111.64669-1-kmehltretter@gmail.com> References: <20260811154111.64669-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit try_to_wake_up() is uninstrumented, but it calls instrumented helpers such as kthread_is_per_cpu(), CPU capacity helpers and SCHED_HRTICK arming. They can record into current while in_task() is true. CONFIG_KCOV_SELFTEST exposes this under PREEMPT_RT. The interrupt selftest fails on x86_64 in kthread_is_per_cpu(): RT runs the timer softirq in a thread, so the wakeup runs in task context during the selftest's spin. The same helpers leak into non-RT syscall wakeups such as a pipe write waking a reader. Pause the wakeup body with the kcov_pause guard. Wrapping only select_task_rq() would miss SCHED_HRTICK arming during enqueue. Fixes: 5c9a8750a640 ("kernel: add kcov code coverage") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- Notes: v2: - take guard(kcov_pause)() - describe the paused wakeup body precisely kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index e49f0bfa0ca73..e863fac02e38f 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4253,6 +4253,9 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) guard(preempt)(); int cpu, success = 0; + /* Instrumented callees would leak coverage into current. */ + guard(kcov_pause)(); + wake_flags |= WF_TTWU; if (p == current) { -- 2.53.0