The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: devicetree@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	van Spriel <arend@broadcom.com>,
	linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS
	(WIRELESS)), linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address
Date: Tue, 11 Aug 2026 12:28:29 -0700	[thread overview]
Message-ID: <20260811192829.123410-1-rosenp@gmail.com> (raw)

The nvmem-cells and nvmem-cell-names properties are used to supply a
MAC address to the brcmfmac wireless controller. Nodes such as
bcm4709-linksys-ea9200.dts fail dtbs_check with:

    Unevaluated properties are not allowed ('nvmem-cell-names',
    'nvmem-cells' were unexpected)

nvmem-consumer.yaml cannot be referenced from the common
network-class.yaml because it does not constrain the number of entries
or their names, and not all network devices use the same cell names.
Each binding that uses nvmem must therefore define its own
nvmem-cells/nvmem-cell-names constraints, like ethernet-controller.yaml
and qca,ath9k.yaml already do.

Add the single-cell, mac-address-only constraints to the
brcm,bcm4329-fmac binding.

Assisted-by: opencode:deepseek-v4-flash-free
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v2: don't use nvmem-consumer.yaml
 .../bindings/net/wireless/brcm,bcm4329-fmac.yaml           | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index 81fd3e37452a..88d0099871b1 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -57,6 +57,13 @@ properties:
           - pci14e4,4434  # BCM4388
           - pci14e4,449d  # BCM43752
 
+  nvmem-cells:
+    maxItems: 1
+    description: Reference to an nvmem node for the MAC address
+
+  nvmem-cell-names:
+    const: mac-address
+
   reg:
     description: SDIO function number for the device (for most cases
       this will be 1) or PCI device identifier.
-- 
2.55.0


                 reply	other threads:[~2026-08-11 19:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811192829.123410-1-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=arend@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox