From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8193741687D for ; Wed, 12 Aug 2026 10:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786532118; cv=none; b=WrOAswWicPHtAD82rLm7nBt6H4RvB5tv8vtqxGmnQ3C+hlCf6Z2i0gh60n2GvB9WldA4vpNf0dD2b0IV+TL0wa3S+YhysgfvycrV/YSviPRxMz0hbW1k8TauvJwPPQ8KodLspyW/06NmigubuXrIybR67SWbc9gqGr1zpt8glJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786532118; c=relaxed/simple; bh=2o1eyljTRdeWeibAzaPwvsCtq+lmY/s64UExAH5FNNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t+wjuoZifPSHPBwUmlsc4nVh46OrH/Tm2FET6aTtYxXzzwQFdLYPo/PAmaPD/rjgN/Rgg6DU+MTMVURmPjZAJi2kWqEuTDO3kvlau/fEtGqmTv+KTh9+bsfwVh9rqLD6qsQT79QYNTKTcOhloC3Rgl68BpXr5z1a0/smr6UywrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nHkw9D+n; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHkw9D+n" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8486ac3f347so1962683b3a.1 for ; Wed, 12 Aug 2026 03:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786532117; x=1787136917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZEyXLqcxbr/SLsSUNviv8nzjhBE4ozvJHxIITTWu9ww=; b=nHkw9D+nQe4bqU6r0O/Ao2y2tMXlfUUPdQqZtwm21aRN0CGwtHx5zbeqEzwzXVxAhY DPxutUQp3mQYzXz1xEyp9i3ZlcNTLxfy9BhzayxPVZ7E5I1PFQARSurahJkKaXCsr9UE Oy5+u0iD3UeZsVBbOkC7pLBvwVeGjr+LUSOP0RH/c7ZqRf1aQ+F7jEpJXBHsfafPkUnq Sm9peT5WnJHJV4Wlgeszc7Fx7HTuA76HhA4jWiRTojF12cxSzm4Zp+zMz+XNTzLVmzu3 zxT4RNcE+WFwM294MtwyfDf8xx8RSu7SWYDE+U4XHMCQIYzbpSI1gRWeirBJ+86TXLJW u94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786532117; x=1787136917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZEyXLqcxbr/SLsSUNviv8nzjhBE4ozvJHxIITTWu9ww=; b=sWzqT0EylFIJgPbkWevQSeb0NlqN/TElTZkUo96nQYSXyHJvX5wD3ueQfp/6fUvG5A CrvsI37hDeeqIH6ECttsU9WVvuzkwAAw4KH6OYq7MfTlCW46UsHC3XPbaUqYPwfx+Fxc SvqzD8oITAM4KumT/+8P+/5f0TGr3JjvglzR6+a03qFvg/ttEN7R17xCGAUsLGDgYVy3 6dTwEUFzv25fbEusQ4bruS81Jx6iILwFST6wBT2E0/XJv4qXv4V6D/Ok8GJhrxde9uSS gFjVC5HDN7fmWixeVLwWLdjwDyVQwcnTGV9FyXwhD0Jsd9XzoujuBUaqDwjyY9kyIfpi kxpg== X-Forwarded-Encrypted: i=1; AHgh+RoHMxpYq/D5SzYBHD7H5+1xw3MDvaF/6ZzNoJMfBR3flR+Ixsj71lBi0yFjcutYCzsEXQlmhbByBbze9l4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr7V2B14Mf1gSQN/99YfM8jVcnvcgIzhahSkpHei0IQHzxwjbB Wy7HhdInvN9zJmVGsZeAWiEHpMrnqGK9qrLcDUu8VwEe7sOEaLm+vPaG X-Gm-Gg: AR+sD122W7MQCBqxpXmwbvETSW1XKj40S7l2MOqJG5Xo+QGobyIX8GmidZAAgToI6s5 K/cQinkAkBvdiOwvTKBGZ6fmerChub68HknZpu172OKCkFu8LeVcyb/G3QoaTYqDzV9ws16H3Tp q7toeMXOjgrS7LU4bEREaibFuCebO8ppd6dj4tFv9nzl5GeBevBbffzU/+5AgPgQ2eAY2DliYlF Y8O62mXkKSjM7QrZ10cvzJ9IeoGLfd3uOJn9+fAAt7jtNftzqulgwaWaqOhNE4hDJCXOrG3QZvN nVTjZbt8uy5z1lCnzHCiF0f+5H4vSRwVsH/XrtktfjKZRf2Zd1cjN7vDvAPnMgv6SbT8258LPMd tibVrtHIiMbhoIZhv5P3RBRw/u8+se8KdoGZd/qZmKkvtj05C61GhaHzpWSJnhBt2b/+8ClyiD/ e68T2iGCDJKUmZlJf7hm6RO0PGoLJyc+zSVK77gOhy8Nz0CxIHGx39RGHHbWHpk2BFzyPWgJtp X-Received: by 2002:a05:6a00:1c8f:b0:842:3838:cb03 with SMTP id d2e1a72fcca58-84fb6b3621emr3798390b3a.11.1786532116612; Wed, 12 Aug 2026 03:55:16 -0700 (PDT) Received: from ubuntu.. ([219.241.133.184]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84fb1f6743dsm811658b3a.52.2026.08.12.03.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 03:55:16 -0700 (PDT) From: Rihyeon Kim To: cassel@kernel.org Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk, justin.tee@broadcom.com, nareshgottumukkala83@gmail.com, paul.ely@broadcom.com, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-fc: fix double free of fabrics options when nvme_add_ctrl() fails Date: Wed, 12 Aug 2026 19:55:10 +0900 Message-ID: <20260812105510.53766-1-rihyeon8648@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, Thanks for the suggestion. > Wouldn't a nicer fix be to change nvme_fc_ctrl_free() to look more like > nvme_tcp_ctrl_free(), i.e. something like: > > + if (list_empty(&ctrl->ctrl_list)) > + goto free_ctrl; I am not sure whether that would work, and I may well be missing something. From what I could tell, nvme_tcp_create_ctrl() does its list_add_tail() last, while nvme_fc_init_ctrl() does it before the nvme_change_ctrl_state() and queue_delayed_work() checks, so on those two failure paths the controller is already on the list and opts would end up freed twice again. The early goto would also skip the ida_free(), put_device() and nvme_fc_rport_put() for what nvme_fc_alloc_ctrl() takes before the list_add. I am not familiar with this driver either, so please correct me if I have misread it. Keith suggested moving the existing clear from fail_ctrl: down to out_put_ctrl: instead, so I will send that as v2. Thanks, Rihyeon