From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AB8843BDA1 for ; Wed, 12 Aug 2026 12:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786537139; cv=none; b=PY6kTOA3sSK3i9/NvQSzYEjplTYjml+hOh4XvFwMB0uMZiBhHiCL0wjYHljeUlbMli+2SGkdnRvfoq7A+UrT8rr/fmiADOSridEUOMsKgJj4DQM6cK5U0o0vt44cyWyHvToF3S6oBLbvNnmSeaJgfo0FKr4AuvVdSfqFnO6p1mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786537139; c=relaxed/simple; bh=7EYCiJRcVCzHthjgLI3vVoahusfiqrUgf7UEd10aNGg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gs+nAHgl2pnmmjt9bPK9nIeP08laQ3bBsI9QV9id7y4KvczROcsuJ2PNnCkB5+93IjsmbFzp6lLmwHr2YtUmqdnp2QTFqL8TWLVXUZN9LnEoghsgVLD7T12TEiNt8yuEBY21FDzDQ4Cx5bAFg+BSbShQ7hqsP51HhFi9pVVzKF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KIQ1U2Fr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KIQ1U2Fr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A67211F00A3E; Wed, 12 Aug 2026 12:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786537136; bh=JQPoDdD5OLaDoL3cib3mD06LEWmyAGJqyFzrLrL7XwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KIQ1U2Frf0x661YHoG8mZNUjmwleI0PxWMk3/LU8npUPFUiSPNtjx/IhiwDh7OgiX Gna9MI2ipdDabXPGk2MZ91adiLzJg1kHYBPremNpuE3v6EL12cPGXSdBHDASEC8iNV Qp/Dfxv/F6TdJnIulo/qgrr3ssGVOqPTtG3rZTqp9ZeCvW7c3pqA19KzAfi30tOIMD 0sLlN7u/TSEy5ddjRa6FKZ9O4Tw2uLSMRscyDKiQYnqq01Gpg1QImxLgjIEPdFuBNr cSBHwzsKqccw2OO8LCBmR+FfZoUFkXziyxcH2qgSk5PyZi3C8CjG7j0hv0WyoB9PpW t7s/ACJ85q3Zw== From: "Barry Song (Xiaomi)" To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: axelrasmussen@google.com, chenridong@xiaomi.com, david@kernel.org, hannes@cmpxchg.org, kasong@tencent.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, ljs@kernel.org, lyugaofei@xiaomi.com, mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev, stevensd@chromium.org, wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com, zhangbo56@xiaomi.com, baolin.wang@linux.alibaba.com, baoquan.he@linux.dev, Barry Song Subject: [RFC PATCH v4 13/16] mm/mglru: remove redundant gens <= MIN_NR_GENS check in should_run_aging() Date: Wed, 12 Aug 2026 20:16:55 +0800 Message-Id: <20260812121658.69965-14-baohua@kernel.org> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20260812121658.69965-1-baohua@kernel.org> References: <20260812121658.69965-1-baohua@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bo Zhang If the following condition is true, if (min_seq[type] + MIN_NR_GENS > max_seq) return true; then this one must also be true, if (evictable_min_seq(min_seq, swappiness) + MIN_NR_GENS > max_seq) return true; The converse is not true, so the evictable_min_seq() check is redundant and can be removed. Signed-off-by: Bo Zhang Signed-off-by: Barry Song (Xiaomi) --- mm/vmscan.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 50f0bcf9576c..a276560bc66b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5098,10 +5098,6 @@ static bool should_run_aging(struct lruvec *lruvec, unsigned long max_seq, int type = get_type_to_scan(lruvec, swappiness); DEFINE_MIN_SEQ(lruvec); - /* have to run aging, since eviction is not possible anymore */ - if (evictable_min_seq(min_seq, swappiness) + MIN_NR_GENS > max_seq) - return true; - /* run aging if the preferred type is exhausted */ if (min_seq[type] + MIN_NR_GENS > max_seq) return true; -- 2.34.1