The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yunshui Jiang <jiangyunshui@kylinos.cn>
Cc: kees@kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, martyn@welchs.me.uk
Subject: Re: [PATCH v2] staging: vme_user: fake: stop tasklet before freeing its data
Date: Wed, 12 Aug 2026 09:23:16 +0900	[thread overview]
Message-ID: <2026081257-embattled-audience-3fe6@gregkh> (raw)
In-Reply-To: <20260811092557.373903-2-jiangyunshui@kylinos.cn>

On Tue, Aug 11, 2026 at 05:24:59PM +0800, Yunshui Jiang wrote:
> fake_init() arms a tasklet whose callback fake_VIRQ_tasklet()
> dereferences fake_bridge and fake_bridge->driver_priv. Both fake_exit()
> and the err_master error path of fake_init() free
> fake_bridge->driver_priv (which embeds int_tasklet) and fake_bridge
> without calling tasklet_kill(), so a pending or running tasklet may
> access already-freed memory (use-after-free).
> 
> Add tasklet_kill() before the frees in both paths.
> 
> Fixes: 658bcdae9c67 ("vme: Adding Fake VME driver")
> Assisted-by: Claude-Code:GLM-5.2
> Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
> ---
>  drivers/staging/vme_user/vme_fake.c | 3 +++
>  1 file changed, 3 insertions(+)

As per:
	https://lore.kernel.org/all/2026080354-skater-urgent-31b2@gregkh/T/#u
I can not take this change, sorry.

thanks,

greg k-h

      reply	other threads:[~2026-08-12  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  7:30 [PATCH] staging: vme_user: fake: stop tasklet before freeing its data Yunshui Jiang
2026-08-11  7:51 ` Greg KH
2026-08-11  9:18   ` [PATCH v2] " Yunshui Jiang
2026-08-11  9:18     ` Yunshui Jiang
2026-08-11  9:24   ` Yunshui Jiang
2026-08-11  9:24     ` Yunshui Jiang
2026-08-12  0:23       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026081257-embattled-audience-3fe6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jiangyunshui@kylinos.cn \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martyn@welchs.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox