From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH 2/3] Revert "mm/damon/lru_sort: error out for >10000 active_mem_bp"
Date: Wed, 12 Aug 2026 22:44:29 -0700 [thread overview]
Message-ID: <20260813054432.101197-3-sj@kernel.org> (raw)
In-Reply-To: <20260813054432.101197-1-sj@kernel.org>
This reverts commit 06befa61c427e74319781e6f35a364cfc32dbae8.
The commit was made to avoid zero damos quota goal target value, because
it can trigger division-by-zero. Now the core layer handles the corner
case. It returns an error for any attempt setting the aero
target_value. The corner case handling in DAMON_LRU_SORT is hence no
more needed. Remove it.
Note that this slightly changes the user behavior. It still disallows
active_mem_bp of 10,002. But now it allows other >10,000 active_mem_bp
values. Setting >10,000 active_mem_bp makes not much sense. But it
doesn't cause critical problems such as memory leak or crash, either.
Arguably that doesn't deserve additional code complexity. Just allow
it.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/lru_sort.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index f25ee7326e87c..ad8e86dd3a93e 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -233,8 +233,6 @@ static int damon_lru_sort_add_quota_goals(struct damos *hot_scheme,
if (!active_mem_bp)
return 0;
- if (10000 < active_mem_bp)
- return -EINVAL;
goal = damos_new_quota_goal(DAMOS_QUOTA_ACTIVE_MEM_BP, active_mem_bp);
if (!goal)
return -ENOMEM;
--
2.47.3
next prev parent reply other threads:[~2026-08-13 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 5:44 [RFC PATCH 0/3] mm/damon: move zero damos quota target_value handling to the core layer SJ Park
2026-08-13 5:44 ` [RFC PATCH 1/3] mm/damon/core: error damos_commit_quota_goal() for zero target_value SJ Park
2026-08-13 5:44 ` SJ Park [this message]
2026-08-13 5:44 ` [RFC PATCH 3/3] Revert "samples/damon/mtier: error out for zero quota goal target values" SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813054432.101197-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox